Repository navigation
Upload verified combined bundles without rebuilding - #15
Merged
Merged
Conversation
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a signed combined ZIP to be tested and reviewed before uploading those same bytes.
releaseAll.useExistingBundleschedules the source guard instead ofbundleAlland requires externally retainedexpectedBundleSha256andexpectedManifestSha256values. Normal build-and-upload behavior remains the default.Upload graphs validate digest presence and syntax before tasks execute, reject simultaneous bundling, and verify source state, both files and their receipt entries. The guard checks the reviewed manifest digest before source/selection diagnostics. Hashing and parsing use the same manifest bytes. Upload uses a private ZIP snapshot checked against the verified digest; the journal records that same digest. Snapshot creation/copy failures explain remediation and assure that no upload was attempted. Cleanup failures identify paths for manual removal.
Digest binding occurs only when
releaseAllis in the resolved graph. Plain bundling, signing checks and guard runs ignore exported upload evidence; graph configuration logs this at info level without realizingreleaseAllfor the diagnostic. The regression cases explicitly require the guard to succeed on both initial and cached runs; the plain:core:checkcase was removed because it did not execute the guard. A code comment records the graph-time input-binding assumption for Gradle upgrades.Resume remains status-only and ignores evidence settings. Reviewed manifest digests cover polling in the upload invocation; later resumes trust the journal's manifest copy. The README documents this trust boundary, persistent Gradle properties, writable snapshot directories and crash cleanup.
Validation: 101 tests passed with no skips across
ModuleReleaseTest,CombinedReleaseDslTest, andCombinedReleaseTest, including configuration-cache-enabled TestKit fixtures. Coverage includes exact multipart bytes, source/manifest/receipt tampering, missing files, malformed/uppercase digests, mixed graphs, resume precedence, check/use mutations, snapshot failures/cleanup and shared checksum formatting.git diff --checkpassed. Windows timeout/locked-file cleanup was not exercised on Windows. No artifacts were published.