Repository navigation
Order the source guard after planned POM regeneration (fix flaky CI) - #18
Merged
Merged
Conversation
releaseAllGuard hashes the POM files recorded by releaseAllPlan, but had no ordering against the generatePomFile tasks that bundleAll staging runs in the same build. With the configuration cache, tasks run in parallel, so the guard could hash a POM while it was being rewritten and fail with "Stale manifest input: <module>/build/publications/maven/pom-default.xml". This made embeddedProjectsMustAlsoBeRemovedFromGradleMetadata and namedSubsetPlansBuildsSignsAndBundlesRealPublications fail intermittently in CI, including on main after #15. Make the guard mustRunAfter the planned POM tasks. The ordering only applies when both are scheduled, so existing-bundle uploads and resume are unaffected. A regression test forces POM regeneration with a delayed rewrite; it failed reliably before this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the intermittent CI failures on
mainsince #15. The same failures appeared in #15's later runs, in #16, and back on 2026-11-05 on #13/#14 branches.Cause
The failing tests (
embeddedProjectsMustAlsoBeRemovedFromGradleMetadata [1]/[2]andnamedSubsetPlansBuildsSignsAndBundlesRealPublications) all failed with:releaseAllGuardhashes the POM files thatreleaseAllPlanrecorded. Staging forbundleAllregenerates those POMs in the same build, and nothing ordered the guard after that regeneration. With the configuration cache, tasks run in parallel, so the guard could read a POM that was missing or only partly written.Fix
releaseAllGuardnowmustRunAfterthe planned POM tasks (the same tasksreleaseAllPlanalready depends on).Test
guardHashesPomsOnlyAfterPomRegenerationFinishesforces POM regeneration and keeps the POM missing for 1.5 s during the rewrite. It failed reliably before the fix with the CI error above, and passed three runs in a row after it.Validation
./gradlew checkon macOS: 194 tests, 0 failures. The original failures were intermittent on CI runners, so CI on this PR is the real confirmation.🤖 Generated with Claude Code