Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ final class ModuleReleaseConfigurer {
task.dependsOn(extension.guardTask)
}
extension.guardTask.configure { task ->
// The guard hashes the planned POMs. When staging regenerates them in the same
// build, hash only after regeneration finishes, never a missing or partial file.
task.mustRunAfter(model.call().pomTasks)
task.versionsJson.convention(model.call().versionsJson)
task.modulePaths.set(paths)
task.unpublishedProjectPaths.set(unpublishedPaths)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,26 @@ if (gradle.startParameter.taskNames == ['help']) {
}
}

@Test void guardHashesPomsOnlyAfterPomRegenerationFinishes() {
withServer { String base, List requests ->
fixture(base, "modules = [':core']")
// CI regenerated POMs during bundleAll; force that and widen the window in which
// the guard intermittently saw a missing or partially written POM.
new File(root, 'core/build.gradle') << '''
tasks.named('generatePomFileForMavenPublication') {
outputs.upToDateWhen { false }
doFirst { destination.delete(); Thread.sleep(1500) }
}
'''
commit()
run('releaseAllPlan')
def bundle = run('bundleAll')
assertEquals(org.gradle.testkit.runner.TaskOutcome.SUCCESS, bundle.task(':releaseAllGuard')?.outcome)
assertEquals(org.gradle.testkit.runner.TaskOutcome.SUCCESS, bundle.task(':core:generatePomFileForMavenPublication')?.outcome)
assertTrue(new File(root, BUNDLE).isFile())
}
}

@Test void namedSubsetPlansBuildsSignsAndBundlesRealPublications() {
withServer { String base, List requests ->
fixture(base, "modules = [':api', 'core']")
Expand Down
Loading