Repository navigation
Tighten non-upload evidence test and log ignored upload digests - #17
Merged
Merged
Conversation
The :core:check case in nonUploadGraphsIgnoreExportedUploadEvidence never scheduled releaseAllGuard (check only depends on the guard when bundleAll wires staging), so it passed vacuously. Drop it and assert the guard ran in every case, on both the fresh and the configuration-cache reuse run; the bundleAll case also asserts that the staged :core:check ran. When a release-preparation graph schedules releaseAllGuard without releaseAll, log at info level that exported upload digests were not checked, to help diagnose CI jobs where evidence was set but not applied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15, addressing the review findings that remained when it merged.
Test fix
nonUploadGraphsIgnoreExportedUploadEvidencehad a:core:checkcase that never ranreleaseAllGuard:checkonly depends on the guard whenbundleAllsets up staging. That case passed regardless of how the evidence was handled, so it is removed.bundleAll,releaseAllSigningCheck,releaseAllGuard) now asserts that the guard ran withSUCCESS, on both the fresh run and the configuration-cache reuse run. ThebundleAllcase also asserts that the staged:core:checkran, so check graphs are still covered.Diagnostic
releaseAllGuardwithoutreleaseAlland aexpectedBundleSha256orexpectedManifestSha256value is set, an info-level message says the evidence was not checked. This helps diagnose CI jobs where the digests were exported but never applied.releaseAllis only created for this check when the guard is already part of the build, so ordinary builds stay as lazy as before.Not changed
taskGraph.whenReady. Configuration-cache reuse was verified during the Upload verified combined bundles without rebuilding #15 review, and the existing digest tests would catch a future Gradle change that rejects this.Validation
./gradlew checkon macOS: 192 tests, 0 failures (one fewer than before because of the removed case).🤖 Generated with Claude Code