Skip to content

Tighten non-upload evidence test and log ignored upload digests - #17

Merged
perNyfelt merged 2 commits into
mainfrom
fix/upload-evidence-followups
Nov 15, 2026
Merged

perNyfelt merged 2 commits into
mainfrom
fix/upload-evidence-followups

Conversation

@perNyfelt

Copy link
Copy Markdown
Member

Follow-up to #15, addressing the review findings that remained when it merged.

Test fix

  • nonUploadGraphsIgnoreExportedUploadEvidence had a :core:check case that never ran releaseAllGuard: check only depends on the guard when bundleAll sets up staging. That case passed regardless of how the evidence was handled, so it is removed.
  • Every remaining case (bundleAll, releaseAllSigningCheck, releaseAllGuard) now asserts that the guard ran with SUCCESS, on both the fresh run and the configuration-cache reuse run. The bundleAll case also asserts that the staged :core:check ran, so check graphs are still covered.

Diagnostic

  • When a build runs releaseAllGuard without releaseAll and a expectedBundleSha256 or expectedManifestSha256 value is set, an info-level message says the evidence was not checked. This helps diagnose CI jobs where the digests were exported but never applied.
  • releaseAll is only created for this check when the guard is already part of the build, so ordinary builds stay as lazy as before.
  • The message is logged when Gradle calculates the build's configuration, so it is not repeated when the configuration cache is reused. The README documents the message.

Not changed

Validation

  • ./gradlew check on macOS: 192 tests, 0 failures (one fewer than before because of the removed case).

🤖 Generated with Claude Code

The :core:check case in nonUploadGraphsIgnoreExportedUploadEvidence never
scheduled releaseAllGuard (check only depends on the guard when bundleAll
wires staging), so it passed vacuously. Drop it and assert the guard ran
in every case, on both the fresh and the configuration-cache reuse run;
the bundleAll case also asserts that the staged :core:check ran.

When a release-preparation graph schedules releaseAllGuard without
releaseAll, log at info level that exported upload digests were not
checked, to help diagnose CI jobs where evidence was set but not applied.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@perNyfelt
perNyfelt merged commit e709b98 into main Nov 15, 2026
5 checks passed
@perNyfelt
perNyfelt deleted the fix/upload-evidence-followups branch November 15, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant