deps(workspace): clean BLOCKED comments; record 6.0.0→6.0.1 block (lancedb 0.29.0 transitive)#425
Merged
Merged
Conversation
….1 block #423 landed the lance 4→6, lancedb 0.27→0.29, datafusion 52→53, arrow 57→58 coordinated bump (RESOLVED A/B/D). The stale BLOCKED comments in the root Cargo.toml predate that landing. This commit: - Replaces the BLOCKED-(A)/(B)/(D) comment block with a dated RESOLVED record pointing to #423 + the live crate-level pins. - Records the user-authorised follow-on patch 6.0.0 → 6.0.1 as CURRENTLY BLOCKED: lancedb 0.29.0 (the latest 0.29.x on crates.io) transitively pins `lance = "=6.0.0"`, so cargo cannot satisfy `lance = "=6.0.1"` + the lancedb transitive simultaneously. Resolution path: wait for lancedb 0.29.1+ that bumps the lance pin, or drop the strict-= in lance-graph. - Keeps BLOCKED(C) (surrealdb kv-lance git source) since it's a separate fork-access concern still pending human input. No code touched. No version-string pin changed in any crate Cargo.toml — they all stay at the #423 state (=6.0.0 / =0.29.0 / 53 / 58). https://claude.ai/code/session_01FMooFcE7hgRWWvknNr2N4i
📝 WalkthroughWalkthroughWorkspace documentation updated: pinned ChangesDependency Documentation and Tech-debt
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59ef97e45b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # transitively pins lance =6.x, datafusion 53, arrow 58. | ||
| # | ||
| # RESOLVED(D) 2026-05-28 — lance-index → ndarray transitive is satisfied by the | ||
| # workspace's `[patch.crates-io] ndarray = { path = "../ndarray" }` override |
There was a problem hiding this comment.
For workspace builds that require Lance's transitive ndarray to use the AdaWorldAPI fork, this marks BLOCKED(D) resolved by a root [patch.crates-io] override that is not actually present; git grep '[patch.crates-io]' on this commit only finds comments, and Cargo.lock still resolves ndarray 0.16.1 from crates.io. This can mislead follow-up dependency work into assuming the fork is wired while Lance's transitive graph still uses the registry crate.
Useful? React with 👍 / 👎.
|
Actionable comments posted: 0 |
…odex P2) Codex P2 review on PR #425 flagged that my RESOLVED(D) note was false: - No `[patch.crates-io]` block exists in this workspace root (`git grep '\[patch'` finds only the prior comment). - `Cargo.lock` continues to resolve `ndarray 0.16.1` from `registry+https://github.com/rust-lang/crates.io-index` (`cargo tree -i ndarray@0.16.1` → lance-index 6.0.0 → lance 6.0.0). The user redirected: "don't use crates.io; try [patch] github.com/adaworldapi/ndarray.git or adjacent". Investigation: - AdaWorldAPI/ndarray fork is at `version = "0.17.2"` across both master and the working branch; no 0.16-line branch/tag exists. - `lance-index 6.0.0` pins `ndarray = "0.16.1"` (features = `["matrixmultiply-threading"]`). - A patch to the 0.17.2 fork would emit `"warning: Patch ndarray v0.17.2 was not used in the crate graph"` — the semver gap defeats the patch. This commit: - Replaces the false RESOLVED(D) with an accurate BLOCKED(D) STILL OPEN record naming the three resolution paths. - Files TD-NDARRAY-PATCH-0_16 in TECH_DEBT.md tracking the gap. - Confirms the workspace's DIRECT ndarray dep (path = `../../../ndarray`) IS wired to the fork (Cargo.lock entry `ndarray 0.17.2` from local source); only the lance TRANSITIVE remains on crates.io 0.16.1. No version pins changed. No code touched. https://claude.ai/code/session_01FMooFcE7hgRWWvknNr2N4i
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Cargo.toml`:
- Around line 74-76: The documentation comment in Cargo.toml contains a
machine-specific absolute path (/home/user/ndarray/Cargo.toml); replace that
hardcoded path with a repo-relative or neutral reference (for example
"./ndarray/Cargo.toml" or "the ndarray/Cargo.toml in this repository") inside
the comment so it’s portable; update the commented block around the version note
(the lines mentioning the AdaWorldAPI/ndarray fork and version "0.17.2") to use
the new repo-relative or neutral reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 774b2b1b-fce6-4690-9f03-27034ddbf95c
📒 Files selected for processing (2)
.claude/board/TECH_DEBT.mdCargo.toml
✅ Files skipped from review due to trivial changes (1)
- .claude/board/TECH_DEBT.md
Comment on lines
+74
to
+76
| # - The AdaWorldAPI/ndarray fork is at `version = "0.17.2"` (see | ||
| # `/home/user/ndarray/Cargo.toml`); no 0.16-line branch / tag exists | ||
| # (verified: only `master` + working branch, both at 0.17.2). |
There was a problem hiding this comment.
Replace machine-specific filesystem path in documentation comment.
Line 75 hardcodes /home/user/ndarray/Cargo.toml, which is not portable for other contributors. Use a repo-relative or neutral reference instead.
Suggested edit
-# - The AdaWorldAPI/ndarray fork is at `version = "0.17.2"` (see
-# `/home/user/ndarray/Cargo.toml`); no 0.16-line branch / tag exists
+# - The AdaWorldAPI/ndarray fork is at `version = "0.17.2"` (see the fork's
+# `Cargo.toml`); no 0.16-line branch / tag exists🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Cargo.toml` around lines 74 - 76, The documentation comment in Cargo.toml
contains a machine-specific absolute path (/home/user/ndarray/Cargo.toml);
replace that hardcoded path with a repo-relative or neutral reference (for
example "./ndarray/Cargo.toml" or "the ndarray/Cargo.toml in this repository")
inside the comment so it’s portable; update the commented block around the
version note (the lines mentioning the AdaWorldAPI/ndarray fork and version
"0.17.2") to use the new repo-relative or neutral reference.
…clared intent)
Per user directive 2026-05-28 ("don't use crates.io; just use [patch] to
overwrite ndarray = 0.16 with 0.17.2"). Adds:
[patch.crates-io]
ndarray = { git = "https://github.com/AdaWorldAPI/ndarray.git", branch = "master" }
The fork is at `version = "0.17.2"` (verified `/home/user/ndarray/Cargo.toml`
+ `git ls-remote https://github.com/AdaWorldAPI/ndarray.git` HEAD =
0129b5c8). Workspace-direct ndarray consumers (already path-wired) continue
to resolve to 0.17.2 from local source.
Observed cargo behavior (verified `cargo check -p lance-graph-ontology`):
- Build succeeds in 37s (5 unrelated oxrdf deprecation warnings only).
- Cargo emits: `warning: patch ndarray v0.17.2 (...) was not used in the
crate graph`. Reason: lance-index 6.0.0 pins `ndarray = "0.16.1"` (with
`matrixmultiply-threading`); cargo's `[patch]` requires semver-compat,
so the 0.17.2 fork can't replace the 0.16 transitive.
- Cargo.lock now has THREE ndarray entries:
1. `ndarray 0.16.1` from `registry+https://github.com/rust-lang/crates.io-index`
(lance-index transitive — UNCHANGED).
2. `ndarray 0.17.2` (no source = local path) — workspace-direct.
3. `[[patch.unused]] ndarray 0.17.2` from `git+...?branch=master#0129b5c8`
— declared intent, not applied.
This patch is therefore a DECLARED INTENT that surfaces the semver gap at
every `cargo check` via the "patch unused" warning (the diagnostic codex was
asking for). The full unblock still needs either:
(a) A `0.16.x`-versioned branch on AdaWorldAPI/ndarray with the fork's
patches forward-ported, OR
(b) Upstream lance-index to bump to ndarray 0.17.
BLOCKED(D) comment in the workspace Cargo.toml updated to reflect this; the
TD-NDARRAY-PATCH-0_16 entry filed earlier still tracks the gap.
https://claude.ai/code/session_01FMooFcE7hgRWWvknNr2N4i
Cargo.lock companion to the previous commit (8f3913b). The `[patch.crates-io] ndarray = { git = "https://github.com/AdaWorldAPI/ndarray.git", branch = "master" }` declaration adds a `[[patch.unused]] ndarray 0.17.2 from git+...?branch=master#0129b5c8` entry to Cargo.lock alongside the existing `ndarray 0.16.1` (crates.io, lance-index transitive) and `ndarray 0.17.2` (local path, workspace-direct) entries. The "unused" marker is cargo's own signal that the fork's `0.17.2` doesn't semver-match lance-index's `=0.16.1` requirement — the diagnostic codex was asking for now ships in the lock too. https://claude.ai/code/session_01FMooFcE7hgRWWvknNr2N4i
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Cargo.toml (1)
138-139: ⚡ Quick winPin
ndarraypatch to a commitrev(avoidbranch = "master")
Cargo.tomlpatchesndarrayfromhttps://github.com/AdaWorldAPI/ndarray.gitusing the movingmasterbranch; pinning to a specific commit makes dependency resolution deterministic (currentmasterhead:0129b5c80cee8d88fdae97be813524328e4d025a).Suggested edit
[patch.crates-io] -ndarray = { git = "https://github.com/AdaWorldAPI/ndarray.git", branch = "master" } +ndarray = { git = "https://github.com/AdaWorldAPI/ndarray.git", rev = "0129b5c80cee8d88fdae97be813524328e4d025a" }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Cargo.toml` around lines 138 - 139, Update the Cargo.toml patch for the ndarray crate to pin it to a specific commit instead of tracking a moving branch: replace the branch = "master" entry in the [patch.crates-io] ndarray override with rev = "0129b5c80cee8d88fdae97be813524328e4d025a" (or another chosen commit SHA) so dependency resolution is deterministic; ensure the git URL remains the same and that only the branch field is swapped for rev.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Cargo.toml`:
- Around line 127-139: The note earlier in Cargo.toml that claims "there is no
`[patch.crates-io]` block in this workspace root" is now incorrect because you
added a [patch.crates-io] section overriding ndarray; update that narrative to
reflect the new state (e.g., mention that a [patch.crates-io] override for
ndarray now exists pointing to the AdaWorldAPI fork and explain its implications
such as the expected warning for lance-index's ndarray = "0.16.1" and the
BLOCKED(D) caveat). Locate the original sentence in the dependency status
commentary and replace or append a brief clarifying sentence referencing the new
[patch.crates-io] ndarray override so the document is internally consistent.
---
Nitpick comments:
In `@Cargo.toml`:
- Around line 138-139: Update the Cargo.toml patch for the ndarray crate to pin
it to a specific commit instead of tracking a moving branch: replace the branch
= "master" entry in the [patch.crates-io] ndarray override with rev =
"0129b5c80cee8d88fdae97be813524328e4d025a" (or another chosen commit SHA) so
dependency resolution is deterministic; ensure the git URL remains the same and
that only the branch field is swapped for rev.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 70316167-8089-4942-a25f-ecbdb5718ee6
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
Comment on lines
+127
to
+139
| # ─── [patch.crates-io] — point ndarray at the AdaWorldAPI fork ────────────── | ||
| # | ||
| # [patch.crates-io] | ||
| # # BLOCKED(D): uncomment and fill once Lance 6 ndarray transitive version known | ||
| # # ndarray = { path = "../../../ndarray" } | ||
| # Per user directive 2026-05-28 ("don't use crates.io; try [patch] | ||
| # github.com/adaworldapi/ndarray.git or adjacent" → "just use [patch] to | ||
| # overwrite ndarray = 0.16 with 0.17.2"). The fork's `0.17.2` will: | ||
| # - Satisfy workspace-direct consumers (already wired via path dep). | ||
| # - Emit `"Patch ndarray v0.17.2 ... was not used in the crate graph"` | ||
| # against lance-index's `ndarray = "0.16.1"` until lance-index 0.17- | ||
| # compat lands OR a 0.16-line branch is added to the fork. | ||
| # The patch is a declared-intent override; effect on the transitive depends | ||
| # on semver compat. See BLOCKED(D) comment above + TD-NDARRAY-PATCH-0_16. | ||
| [patch.crates-io] | ||
| ndarray = { git = "https://github.com/AdaWorldAPI/ndarray.git", branch = "master" } |
There was a problem hiding this comment.
Update conflicting BLOCKED(D) narrative after adding the patch block.
After Line [138], the statement at Line [67]-Line [69] (“there is no [patch.crates-io] block in this workspace root”) is no longer true. Please update that earlier note so the dependency status section is internally consistent.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Cargo.toml` around lines 127 - 139, The note earlier in Cargo.toml that
claims "there is no `[patch.crates-io]` block in this workspace root" is now
incorrect because you added a [patch.crates-io] section overriding ndarray;
update that narrative to reflect the new state (e.g., mention that a
[patch.crates-io] override for ndarray now exists pointing to the AdaWorldAPI
fork and explain its implications such as the expected warning for lance-index's
ndarray = "0.16.1" and the BLOCKED(D) caveat). Locate the original sentence in
the dependency status commentary and replace or append a brief clarifying
sentence referencing the new [patch.crates-io] ndarray override so the document
is internally consistent.
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 28, 2026
…tries Post-merge board hygiene for two PRs merged in this wave: - **#425** (mine, lance-graph deps cleanup + [patch.crates-io] ndarray declared intent; merge commit 1a3abfb). Locks in the lance 6.0.1 block reasoning (lancedb 0.29.0 transitive ='6.0.0') and the ndarray patch's "declared but unused" effect. - **#427** (bindspace→mailbox migration wave A1-A4; merge commit 8429611). Authored by a peer session; per-deliverable AGENT_LOG entries were prepended at branch HEAD pre-merge, but the LATEST_STATE / PR_ARC tier of governance was left for follow-up — this commit fills it. Records the 7 ratified plan §10 findings + the 2 surviving OQs (OQ-MBX-8 persisted_row vs Lance native versioning; OQ-MBX-15′ container scoping). Both via tee -a (the 8 bookkeeping files deny Edit/Write); dated framing preserves the rule-#1 PREPEND convention. No code touched. No new types proposed. Outstanding: #426 (odoo blueprint Stage 1, +115K lines) also lacks a LATEST_STATE/PR_ARC row; defer to the authoring session for the rich sub-deliverable breakdown (D-ODOO-EXT-1..6 + EXT-3 + BP-1a/b) — a peer session writing #426 governance would either summarize too coarsely or duplicate the per-deliverable AGENT_LOG entries that already exist on main. https://claude.ai/code/session_01FMooFcE7hgRWWvknNr2N4i
3 tasks
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 28, 2026
…odex P2) Codex P2 review on PR #425 flagged that my RESOLVED(D) note was false: - No `[patch.crates-io]` block exists in this workspace root (`git grep '\[patch'` finds only the prior comment). - `Cargo.lock` continues to resolve `ndarray 0.16.1` from `registry+https://github.com/rust-lang/crates.io-index` (`cargo tree -i ndarray@0.16.1` → lance-index 6.0.0 → lance 6.0.0). The user redirected: "don't use crates.io; try [patch] github.com/adaworldapi/ndarray.git or adjacent". Investigation: - AdaWorldAPI/ndarray fork is at `version = "0.17.2"` across both master and the working branch; no 0.16-line branch/tag exists. - `lance-index 6.0.0` pins `ndarray = "0.16.1"` (features = `["matrixmultiply-threading"]`). - A patch to the 0.17.2 fork would emit `"warning: Patch ndarray v0.17.2 was not used in the crate graph"` — the semver gap defeats the patch. This commit: - Replaces the false RESOLVED(D) with an accurate BLOCKED(D) STILL OPEN record naming the three resolution paths. - Files TD-NDARRAY-PATCH-0_16 in TECH_DEBT.md tracking the gap. - Confirms the workspace's DIRECT ndarray dep (path = `../../../ndarray`) IS wired to the fork (Cargo.lock entry `ndarray 0.17.2` from local source); only the lance TRANSITIVE remains on crates.io 0.16.1. No version pins changed. No code touched. https://claude.ai/code/session_01FMooFcE7hgRWWvknNr2N4i
AdaWorldAPI
added a commit
that referenced
this pull request
May 28, 2026
…review-Pyry3 deps(workspace): clean BLOCKED comments; record 6.0.0→6.0.1 block (lancedb 0.29.0 transitive)
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 28, 2026
…tries Post-merge board hygiene for two PRs merged in this wave: - **#425** (mine, lance-graph deps cleanup + [patch.crates-io] ndarray declared intent; merge commit a5f3e8d). Locks in the lance 6.0.1 block reasoning (lancedb 0.29.0 transitive ='6.0.0') and the ndarray patch's "declared but unused" effect. - **#427** (bindspace→mailbox migration wave A1-A4; merge commit a21d577). Authored by a peer session; per-deliverable AGENT_LOG entries were prepended at branch HEAD pre-merge, but the LATEST_STATE / PR_ARC tier of governance was left for follow-up — this commit fills it. Records the 7 ratified plan §10 findings + the 2 surviving OQs (OQ-MBX-8 persisted_row vs Lance native versioning; OQ-MBX-15′ container scoping). Both via tee -a (the 8 bookkeeping files deny Edit/Write); dated framing preserves the rule-#1 PREPEND convention. No code touched. No new types proposed. Outstanding: #426 (odoo blueprint Stage 1, +115K lines) also lacks a LATEST_STATE/PR_ARC row; defer to the authoring session for the rich sub-deliverable breakdown (D-ODOO-EXT-1..6 + EXT-3 + BP-1a/b) — a peer session writing #426 governance would either summarize too coarsely or duplicate the per-deliverable AGENT_LOG entries that already exist on main. https://claude.ai/code/session_01FMooFcE7hgRWWvknNr2N4i
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans the stale
BLOCKED-(A)/(B)/(D)deps comment block in the workspaceCargo.toml(predates #423's coordinated 4→6 / 0.27→0.29 / 52→53 / 57→58 bump) and records the user-authorised follow-on patch lance 6.0.0 → 6.0.1 as CURRENTLY BLOCKED.The 6.0.1 block (the headline finding)
cargo check -p lance-graph-ontologypost-bump produces:Why:
lancedb 0.29.0(the latest 0.29.x on crates.io) transitively pinslance = "=6.0.0". Cargo cannot satisfy bothlance = "=6.0.1"(our pin) and lancedb's transitivelance = "=6.0.0"simultaneously.Resolution path (this PR does NOT pick one — surfaces them):
lancedb 0.29.1+that bumps its lance pin (cleanest; respects the strict-= doctrine).=on lance in lance-graph (doctrine change).[patch.crates-io]override for lance (heavy lift; messy).Tracked here as a comment in the workspace
Cargo.toml. Sibling PRs document the same block.Sibling alignment PRs (this PR is the doc anchor; siblings carry the actual catch-up bumps)
surrealdb— kv-lance pins: lance 4→6, lance-index 4→6, lancedb 0.27→0.29, arrow-array/schema 57→58.MedCare-rs— workspace lancedb 0.27→0.29, lance-datafusion 4→6.smb-office-rs— root arrow* 57→58, smb-bridgelance "2"→"=6.0.0"(stale leftover fix).Test plan
Cargo.tomlversion-string pin changed in this PR (all stayed at chore(deps): bump lance 4.0.0 → 6.0.0, lancedb 0.27.2 → 0.29.0 #423's=6.0.0/=0.29.0/ 53 / 58).Cargo.tomldeps-comment block edited..rs/build.rs/data/touched.https://claude.ai/code/session_01FMooFcE7hgRWWvknNr2N4i
Generated by Claude Code
Summary by CodeRabbit
Chores
Documentation
Note: No user-facing functionality changed.