build(deps): lance 6.0.0 → =7.0.0 + lancedb 0.29.0 → =0.30.0 (object_store 0.13 aligns surrealdb kv-lance)#445
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThis PR updates workspace documentation and crate manifests to pin Lance-family crates to =7.0.0 and LanceDB to =0.30.0, recording the dependency-coherence investigation and tech-debt entry about an object_store compatibility mismatch with a SurrealDB fork. ChangesLance 7.0 and LanceDB 0.30 Alignment
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/board/TECH_DEBT.md:
- Line 16: The heading "TD-SURREALDB-KVLANCE-LANCE7" currently uses a
third-level marker (###) causing a markdownlint MD001 heading-increment error;
change that heading to second-level (##) or insert the missing intermediate
heading level above it so the sequence is incrementally correct, e.g., replace
"### TD-SURREALDB-KVLANCE-LANCE7" with "## TD-SURREALDB-KVLANCE-LANCE7" to
satisfy markdownlint.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4b5b62ad-80c1-4ad8-bf27-59bd74913307
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (10)
.claude/board/EPIPHANIES.md.claude/board/TECH_DEBT.mdCargo.tomlcrates/holograph/Cargo.tomlcrates/lance-graph-benches/Cargo.tomlcrates/lance-graph-callcenter/Cargo.tomlcrates/lance-graph-catalog/Cargo.tomlcrates/lance-graph-ontology/Cargo.tomlcrates/lance-graph/Cargo.tomlcrates/surreal_container/Cargo.toml
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a294133a8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| lance = "=6.0.0" | ||
| lancedb = { version = "=0.29.0", optional = true, default-features = false } | ||
| lance = "=7.0.0" |
There was a problem hiding this comment.
For consumers building surreal_container at its declared rust-version = "1.82", this new non-optional Lance pin no longer resolves: Lance 7 pulls lance-core 7, whose published manifest declares Rust 1.91 / edition 2024, so cargo +1.82 build -p surreal_container fails before compiling this crate. Please either keep this crate on a 1.82-compatible Lance stack or bump the crate's rust-version to the new minimum.
Useful? React with 👍 / 👎.
…kstep) Move the lance family to =7.0.0 and lancedb to =0.30.0 across all 7 crates that pin them (lance-graph, -benches, -callcenter, -catalog, -ontology, holograph, surreal_container; lance-arrow/-index/-linalg/-namespace lockstep). - lancedb 0.30.0 transitively pins lance =7.0.0, satisfying the exact-equals lockstep. Supersedes the dead 6.0.1 path: no lancedb release ever pinned lance =6.0.1 (0.29.0 → 6.0.0, then 0.30.0 → 7.0.0, skipping 6.0.1). - arrow stays 58, datafusion stays 53 (lance 7 + lancedb 0.30 keep ^58 / ^53). - object_store moves 0.12 → 0.13.2 transitively, ALIGNING with the AdaWorldAPI/surrealdb fork (its workspace object_store = "0.13.0"): lance 6's 0.12 conflicted with surrealdb's 0.13, lance 7's 0.13 does not. - Cargo.lock re-resolved: lance/lance-index 7.0.0, lancedb 0.30.0, object_store 0.13.2 (pulls lance-7 xet-* storage crates). Dep graph resolves clean; lance-7 API-level compile is unverified here (disk-limited sandbox) and left to CI. Caveat: surrealdb-core's kv-lance feature still pins lance =6.0.0 / lancedb =0.29.0 — that fork needs the same bump before kv-lance wires against this workspace. https://claude.ai/code/session_012SorR8UbtEvYmbX8cXftj7
…NCE7 Board hygiene for the lance 6→7 / lancedb 0.29→0.30 bump (a07fe26): - EPIPHANIES: the object_store 0.12→0.13 alignment finding — the surrealdb fork's kv-lance =6.0.0 pins were already contradictory with its own object_store 0.13, so lance 7 is a coherence fix, not a version chase. - TECH_DEBT: TD-SURREALDB-KVLANCE-LANCE7 — surrealdb-core kv-lance still on =6.0.0/=0.29.0; paid by the companion adaworldapi/surrealdb PR. https://claude.ai/code/session_012SorR8UbtEvYmbX8cXftj7
AdaWorldAPI
force-pushed
the
claude/jolly-cori-clnf9
branch
from
a294133 to
da79b8c
Compare
AdaWorldAPI
pushed a commit
that referenced
this pull request
May 31, 2026
Full-breadth integration spec wiring D-MBX kanban contract through witness commit (D-ATOM-5), surreal LIVE -> Rubicon kanban flip, ExecTarget backends, head2head two-view superposition in the shader driver, EW64-Markov Hebbian prefetch, language->SPO landing (D-LWS), and BindSpace decommission. Grounded against current main (#437/#439/ #444/#445) + two recon passes; flags the two hard blockers (lance-7 witness API, surreal fork dep / OQ-11.6) and the stale-branch caveat. https://claude.ai/code/session_01PLf95mURCY96TvKBFvSWEQ
AdaWorldAPI
pushed a commit
that referenced
this pull request
Jun 14, 2026
…AUDE.md + plans + boards Workspace shipped lance/lance-linalg =7.0.0, lancedb =0.30.0, object_store 0.13.2 via PR #445 (E-LANCE7). CLAUDE.md 'Key Dependencies' + the D-MBX-11 plan/board refs were months-stale at =6.0.0 / =0.29.0 / planned =6.0.1. - CLAUDE.md: Key Dependencies block -> 7.0.0 / 0.30.0 (+ object_store coupling note) - STATUS_BOARD / D-MBX-COMPLETION-MAP: D-MBX-11 -> Superseded (#445 jumped past =6.0.1) - plans (unified-soa-convergence, bindspace->mailbox-soa, reliability-arc, wikidata-lazy-spine): SUPERSEDED-annotated; factual Cargo.lock refs -> 7.0.0 - INTEGRATION_PLANS: dated inline correction (append-only preserved) - AGENT_LOG: prepended sweep entry + canon pointer + self-correction - Append-only history (EPIPHANIES/PR_ARC/LATEST_STATE/handover) left intact; TD-SURREALDB-KVLANCE-LANCE7 remains the only residual (fork still pins 6) https://claude.ai/code/session_01D2WSmezQBNC3bUdHuGfGmo
AdaWorldAPI
pushed a commit
that referenced
this pull request
Jun 15, 2026
…eResidue TD Address PR #496 review comments: - CodeRabbit (plan §3:164): HHT tier widths are struct-defined fixed (u16 = 4 nibbles each), NOT cache-allocated; DOLCE is a static canonical enum ordering, not a dynamic cache. from_guid_prefix must deterministically subset 20→≤16 nibbles. Corrected. - CodeRabbit (STATUS_BOARD:656): "Superseded" is not in the status legend (Deferred/Abandoned only; :115 says superseded rows use Abandoned + cite replacement). D-MBX-11 -> Abandoned (superseded by #445). - codex (canonical_node.rs:336): real (pre-existing) gap — EdgeCodecFlavor:: CoarseResidue residue has no dedicated ValueTenant (only Pq32x4/TurbovecResidue does). Per §0 anti-invention guardrail, NOT reflexively adding a tenant; tracked as TD-COARSERESIDUE-NO-VALUE-TENANT (sign-off-gated; reuse-TurbovecResidue is the guardrail-preferred option). codex (class_view.rs:247, FULL default): intentional (decision a), tracked TD-VALUESCHEMA-FULL-POC-DEFAULT — no revert. https://claude.ai/code/session_01D2WSmezQBNC3bUdHuGfGmo
AdaWorldAPI
pushed a commit
that referenced
this pull request
Jun 22, 2026
Full-breadth integration spec wiring D-MBX kanban contract through witness commit (D-ATOM-5), surreal LIVE -> Rubicon kanban flip, ExecTarget backends, head2head two-view superposition in the shader driver, EW64-Markov Hebbian prefetch, language->SPO landing (D-LWS), and BindSpace decommission. Grounded against current main (#437/#439/ #444/#445) + two recon passes; flags the two hard blockers (lance-7 witness API, surreal fork dep / OQ-11.6) and the stale-branch caveat. https://claude.ai/code/session_01PLf95mURCY96TvKBFvSWEQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the lance family to
=7.0.0and lancedb to=0.30.0(lockstep) across the 7 crates that pin them, and re-resolveCargo.lock. Manifest + lock only — no source changes.Crates touched:
lance-graph,-benches,-callcenter,-catalog,-ontology,holograph,surreal_container(lance/lance-arrow/lance-index/lance-linalg/lance-namespacemove together;lancedbinlance-graph+surreal_container).Why 7, and why now
lancedb 0.30.0transitively pinslance =7.0.0, so the exact-equals lockstep is satisfied. This supersedes the dead 6.0.1 path: no lancedb release ever pinnedlance =6.0.1(0.29.0 → 6.0.0, then0.30.0 → 7.0.0, skipping 6.0.1 entirely).^58/^53. The only transitive move isobject_store 0.12 → 0.13.2.object_store = "0.13.0". lance 6's object_store 0.12 conflicted with surrealdb's 0.13; lance 7's 0.13 does not. The fork'ssurrealdb-corekv-lancefeature was therefore already shaped for lance 7 — its=6.0.0pins are a latent contradiction this bump resolves.xet-*storage crates (HF content-addressed storage) and dropstar/virtue/yada.Full reasoning on the board:
EPIPHANIES.mdE-LANCE7-OBJECTSTORE-SURREALDB; debt tracked asTECH_DEBT.mdTD-SURREALDB-KVLANCE-LANCE7; rootCargo.tomlRESOLVED(A2/B2).Verification
cargo update -p lance -p lancedbproduced the versions above cleanly (single major of each; arrow/datafusion unchanged).protoc(lance-encoding's build-time dep), socargo checkagainst the lance-7 Rust surface can't run locally. CI (with protoc) is the gate for any 6→7 API breakage. If CI surfaces breaks, they'll be fixed as follow-ups.Companion
A paired PR on adaworldapi/surrealdb (branch
claude/jolly-cori-clnf9) bumpssurrealdb-core'skv-lancepins (lance/lance-index=6.0.0 → =7.0.0,lancedb =0.29.0 → =0.30.0) so thekv-lancestorage engine can resolve against this workspace.https://claude.ai/code/session_012SorR8UbtEvYmbX8cXftj7
Generated by Claude Code
Summary by CodeRabbit
Chores
Tech Debt
Documentation