build(deps): kv-lance lance =7.0.0 / lancedb =0.30.0 (object_store 0.13 coherence)#32
Conversation
surrealdb-core's `kv-lance` feature pinned lance/lance-index `=6.0.0` + lancedb `=0.29.0`, which require object_store ^0.12.3 — contradicting this workspace's own `object_store = "0.13.0"` (lance 6 needs object_store 0.12; only lance 7 moves to 0.13). Bump the kv-lance pins to `=7.0.0` / `=0.30.0` so the storage engine resolves consistently on object_store 0.13, and against the AdaWorldAPI/lance-graph workspace which moved to lance 7 in parallel (lance-graph PR surrealdb#445). arrow-array/arrow-schema stay 58 (lance 7 keeps arrow ^58). https://claude.ai/code/session_012SorR8UbtEvYmbX8cXftj7
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughOptional Lance-related dependencies in the core Cargo manifest are updated to newer versions: ChangesLance Dependency Version Updates
Possibly Related PRs
Poem
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35e7c06f40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| lance = { version = "=7.0.0", optional = true } | ||
| lance-index = { version = "=7.0.0", optional = true } | ||
| lancedb = { version = "=0.30.0", optional = true } |
There was a problem hiding this comment.
Update Cargo.lock with the bumped Lance pins
When the kv-lance feature is enabled, these exact =7.0.0 / =0.30.0 requirements no longer match the checked-in lockfile, which still records lance and lance-index at 6.0.0 and lancedb at 0.29.0. Any reproducible build or CI path using --locked for this feature will fail before compiling because Cargo is not allowed to rewrite Cargo.lock; the manifest bump needs the corresponding lockfile update in the same change.
Useful? React with 👍 / 👎.
Summary
Bump
surrealdb-core'skv-lancefeature pins:lance=6.0.0=7.0.0lance-index=6.0.0=7.0.0lancedb=0.29.0=0.30.0(
arrow-array/arrow-schemastay58— lance 7 keepsarrow ^58.)Why
The
kv-lancepins were already self-contradictory against this workspace's ownobject_store:[workspace.dependencies]declaresobject_store = "0.13.0".object_store ^0.12.3; only lance 7.0.0 moves to^0.13.2.So
kv-lance = ["dep:lance", …]withlance =6.0.0could never coexist with the workspace's object_store 0.13 — the engine was already shaped for lance 7. This bump makes the dependency graph coherent on object_store 0.13.Companion
Paired with AdaWorldAPI/lance-graph#445, which moves that workspace to lance
=7.0.0/ lancedb=0.30.0. With both in,surrealdb-core --features kv-lanceresolves against the lance-graph workspace at a single object_store major.Note
Manifest-only; no source change. Full build verification (rocksdb/tikv/wasmtime/lance-7 tree) is left to CI — it wasn't run in the authoring sandbox (disk + no
protoc).https://claude.ai/code/session_012SorR8UbtEvYmbX8cXftj7
Generated by Claude Code
Summary by CodeRabbit