Skip to content

build(deps): kv-lance lance =7.0.0 / lancedb =0.30.0 (object_store 0.13 coherence)#32

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/jolly-cori-clnf9
May 31, 2026
Merged

build(deps): kv-lance lance =7.0.0 / lancedb =0.30.0 (object_store 0.13 coherence)#32
AdaWorldAPI merged 1 commit into
mainfrom
claude/jolly-cori-clnf9

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented May 31, 2026

Copy link
Copy Markdown
Owner

Summary

Bump surrealdb-core's kv-lance feature pins:

dep before after
lance =6.0.0 =7.0.0
lance-index =6.0.0 =7.0.0
lancedb =0.29.0 =0.30.0

(arrow-array / arrow-schema stay 58 — lance 7 keeps arrow ^58.)

Why

The kv-lance pins were already self-contradictory against this workspace's own object_store:

  • [workspace.dependencies] declares object_store = "0.13.0".
  • lance 6.0.x requires object_store ^0.12.3; only lance 7.0.0 moves to ^0.13.2.

So kv-lance = ["dep:lance", …] with lance =6.0.0 could never coexist with the workspace's object_store 0.13 — the engine was already shaped for lance 7. This bump makes the dependency graph coherent on object_store 0.13.

Companion

Paired with AdaWorldAPI/lance-graph#445, which moves that workspace to lance =7.0.0 / lancedb =0.30.0. With both in, surrealdb-core --features kv-lance resolves against the lance-graph workspace at a single object_store major.

Note

Manifest-only; no source change. Full build verification (rocksdb/tikv/wasmtime/lance-7 tree) is left to CI — it wasn't run in the authoring sandbox (disk + no protoc).

https://claude.ai/code/session_012SorR8UbtEvYmbX8cXftj7


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Updated Lance-related vector database dependencies to the latest versions for improved performance and stability.

surrealdb-core's `kv-lance` feature pinned lance/lance-index `=6.0.0` +
lancedb `=0.29.0`, which require object_store ^0.12.3 — contradicting this
workspace's own `object_store = "0.13.0"` (lance 6 needs object_store 0.12;
only lance 7 moves to 0.13). Bump the kv-lance pins to `=7.0.0` / `=0.30.0`
so the storage engine resolves consistently on object_store 0.13, and against
the AdaWorldAPI/lance-graph workspace which moved to lance 7 in parallel
(lance-graph PR surrealdb#445). arrow-array/arrow-schema stay 58 (lance 7 keeps arrow ^58).

https://claude.ai/code/session_012SorR8UbtEvYmbX8cXftj7
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f9d66f19-e49d-48f1-b031-91aec9566bcf

📥 Commits

Reviewing files that changed from the base of the PR and between 1686c57 and 35e7c06.

📒 Files selected for processing (1)
  • surrealdb/core/Cargo.toml

📝 Walkthrough

Walkthrough

Optional Lance-related dependencies in the core Cargo manifest are updated to newer versions: lance and lance-index move from 6.0.0 to 7.0.0, and lancedb moves from 0.29.0 to 0.30.0. No other manifest changes.

Changes

Lance Dependency Version Updates

Layer / File(s) Summary
Lance dependency version updates
surrealdb/core/Cargo.toml
Optional lance, lance-index, and lancedb dependencies are bumped to newer pinned versions.

Possibly Related PRs

Poem

🐰 A carrot-colored shift, from six to seven,
Lance dependencies rise toward the sky's heaven,
Versions bumped with care, so precise and clean,
The finest dependencies the SurrealDB has seen!

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: updating Lance-related dependencies to resolve object_store version coherence issues across the workspace.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/jolly-cori-clnf9

Comment @coderabbitai help to get the list of available commands and usage tips.

@AdaWorldAPI AdaWorldAPI merged commit 0d3632f into main May 31, 2026
1 check was pending

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35e7c06f40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread surrealdb/core/Cargo.toml
Comment on lines +110 to +112
lance = { version = "=7.0.0", optional = true }
lance-index = { version = "=7.0.0", optional = true }
lancedb = { version = "=0.30.0", optional = true }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update Cargo.lock with the bumped Lance pins

When the kv-lance feature is enabled, these exact =7.0.0 / =0.30.0 requirements no longer match the checked-in lockfile, which still records lance and lance-index at 6.0.0 and lancedb at 0.29.0. Any reproducible build or CI path using --locked for this feature will fail before compiling because Cargo is not allowed to rewrite Cargo.lock; the manifest bump needs the corresponding lockfile update in the same change.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant