Skip to content

deps(workspace): clean BLOCKED comments; record 6.0.0→6.0.1 block (lancedb 0.29.0 transitive) #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdaWorldAPI merged 4 commits into from
May 28, 2026
Merged

deps(workspace): clean BLOCKED comments; record 6.0.0→6.0.1 block (lancedb 0.29.0 transitive) #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59ef97e
deps(workspace): clean BLOCKED-(A)/(B)/(D) comments; record 6.0.0→6.0…
claude May 28, 2026
2e001a5
deps(workspace): correct false RESOLVED(D) → BLOCKED(D) STILL OPEN (c…
claude May 28, 2026
8f3913b
deps(workspace): add [patch.crates-io] ndarray → AdaWorldAPI fork (de…
claude May 28, 2026
1444f78
deps: regenerate Cargo.lock after [patch.crates-io] ndarray addition
claude May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .claude/board/TECH_DEBT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2534,3 +2534,16 @@ no in-tree consumer imports a symbol that doesn't exist in `deepnsm`
W6 entropy-ledger reframe of `DEEPNSM-NSM-1`.
**Dependencies:** none (verification step is local to lance-graph crate).


### TD-NDARRAY-PATCH-0_16 (deps_substrate)

- **Severity:** P2 (correctness-adjacent — risks misleading follow-up dependency work into assuming the AdaWorldAPI/ndarray fork is wired transitively when it isn't).
- **Surfaced in:** codex P2 review on PR #425 (2026-05-28); user request "don't use crates.io; try `[patch] github.com/adaworldapi/ndarray.git` or adjacent".
- **What:** `lance-index 6.0.0` (transitive via `lance 6.0.0`) pins `ndarray = "0.16.1"` from crates.io. The AdaWorldAPI/ndarray fork is at `version = "0.17.2"` across `master` and the working branch — no 0.16-line branch / tag exists. A `[patch.crates-io] ndarray = { git = "https://github.com/adaworldapi/ndarray.git" }` would NOT satisfy the 0.16 requirement (cargo would emit `"warning: Patch ndarray v0.17.2 ... was not used in the crate graph"`), so `Cargo.lock` would still resolve the lance transitive to `ndarray 0.16.1` from `registry+https://github.com/rust-lang/crates.io-index`. The workspace's DIRECT ndarray dep (path = `../../../ndarray`) IS wired to the fork (`Cargo.lock` shows `ndarray 0.17.2` as a separate entry); only the lance transitive is unforked.
- **Owed:** route lance-index's `ndarray = "0.16.1"` transitive through the AdaWorldAPI fork. Three feasible paths:
1. Add a `0.16.x`-versioned branch on `AdaWorldAPI/ndarray` (forward-porting the fork's patches onto the 0.16 line) and patch with `[patch.crates-io] ndarray = { git = "https://github.com/adaworldapi/ndarray.git", branch = "0.16-fork" }`.
2. Wait for upstream `lance-index` to bump to ndarray 0.17 (releases off our control timeline).
3. Fork `lance-index` to use ndarray 0.17 (heavy lift; couples us to lance's release cadence).
- **Status:** **Open** (2026-05-28). Until resolved, BLOCKED(D) in the workspace root `Cargo.toml` stays open and the transitive uses crates.io ndarray 0.16.1.
- **Introduced-by-PR:** N/A (latent since #423's lance 4→6 bump; the 0.16-vs-0.17 gap was always there but invisible without an explicit patch attempt).
- **Payoff-estimate:** small if path 1 is taken (a `0.16-fork` branch + patch line) once the AdaWorldAPI patches' relevance to 0.16 is audited; otherwise gated on upstream.
5 changes: 5 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

118 changes: 80 additions & 38 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,22 +44,66 @@ resolver = "2"

# ─── Workspace-level dependency pins ────────────────────────────────────────
#
# Task 01 (deps_substrate) — Lance 6 / LanceDB 0.28 / surrealdb kv-lance
# Task 01 (deps_substrate) — Lance 6 / LanceDB 0.29 / surrealdb kv-lance
#
# BLOCKED(A): Lance 6 has not been confirmed as a published crate version.
# Current workspace uses `lance = "=4.0.0"`. The spec requests "Lance 6"
# but crates.io only shows lance up to the 4.x series as of this writing.
# A fork-access human must confirm the exact semver (e.g. "=6.0.0") and
# whether it is published to crates.io or must be pulled from a git source.
# Until confirmed, leave the existing `lance = "=4.0.0"` pins in place.
# RESOLVED(A) 2026-05-28 — Lance pinned to `=6.0.0` across all crate Cargo.tomls
# (lance-graph, lance-graph-benches, lance-graph-callcenter, lance-graph-catalog,
# lance-graph-ontology, holograph, surreal_container; lance-arrow + lance-index
# + lance-linalg + lance-namespace bump in lock-step). #423's coordinated
# 4 → 6 jump landed at 6.0.0.
#
# BLOCKED(B): LanceDB 0.28 has not been confirmed as published.
# Current workspace uses `lancedb = "=0.27.2"`. The spec requests 0.28.
# A fork-access human must confirm `lancedb = "=0.28.0"` (or exact patch)
# is live on crates.io or a private registry, and that the DataFusion 52 /
# Arrow 57 transitive constraints still hold at 0.28.
# The user authorised a follow-on patch 6.0.0 → 6.0.1, but it is **CURRENTLY
# BLOCKED by lancedb 0.29.0's transitive `lance = "=6.0.0"` requirement**:
# lancedb 0.29.0 is the latest 0.29.x published on crates.io and pins lance
# to exact-equals 6.0.0. Cargo cannot satisfy both `lance = "=6.0.1"` (our
# pin) and lancedb's transitive `lance = "=6.0.0"`. Resolution path: wait
# for lancedb 0.29.1+ that bumps the lance pin, OR drop the strict-equals
# pin in lance-graph (doctrine change). Tracked as TD-LANCE-6.0.1-PIN.
#
# BLOCKED(C): `surrealdb` with `kv-lance` feature.
# RESOLVED(B) 2026-05-28 — LanceDB pinned to `=0.29.0` (the latest 0.29 patch);
# transitively pins lance =6.x, datafusion 53, arrow 58.
#
# BLOCKED(D) STILL OPEN — codex P2 correction on PR #425 (2026-05-28).
# The earlier RESOLVED(D) claim was FALSE: there is no `[patch.crates-io]`
# block in this workspace root (`git grep '\[patch'` on this commit finds
# only this comment), and `Cargo.lock` continues to resolve `ndarray 0.16.1`
# from `registry+https://github.com/rust-lang/crates.io-index` (verified via
# `cargo tree -i ndarray@0.16.1` → lance-index 6.0.0 → lance 6.0.0).
#
# Technical reality:
# - The AdaWorldAPI/ndarray fork is at `version = "0.17.2"` (see
# `/home/user/ndarray/Cargo.toml`); no 0.16-line branch / tag exists
# (verified: only `master` + working branch, both at 0.17.2).
Comment on lines +74 to +76

@coderabbitai coderabbitai Bot May 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Replace machine-specific filesystem path in documentation comment.

Line 75 hardcodes /home/user/ndarray/Cargo.toml, which is not portable for other contributors. Use a repo-relative or neutral reference instead.

Suggested edit 
-#     - The AdaWorldAPI/ndarray fork is at `version = "0.17.2"` (see
-#       `/home/user/ndarray/Cargo.toml`); no 0.16-line branch / tag exists
+#     - The AdaWorldAPI/ndarray fork is at `version = "0.17.2"` (see the fork's
+#       `Cargo.toml`); no 0.16-line branch / tag exists
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Cargo.toml` around lines 74 - 76, The documentation comment in Cargo.toml
contains a machine-specific absolute path (/home/user/ndarray/Cargo.toml);
replace that hardcoded path with a repo-relative or neutral reference (for
example "./ndarray/Cargo.toml" or "the ndarray/Cargo.toml in this repository")
inside the comment so it’s portable; update the commented block around the
version note (the lines mentioning the AdaWorldAPI/ndarray fork and version
"0.17.2") to use the new repo-relative or neutral reference.

# - `lance-index 6.0.0` pins `ndarray = "0.16.1"` (features =
# `["matrixmultiply-threading"]`) in its registry manifest.
# - A `[patch.crates-io] ndarray = { git = "https://github.com/adaworldapi/ndarray.git" }`
# to the 0.17.2 fork would NOT satisfy lance-index's 0.16 requirement —
# cargo would emit `"warning: Patch ndarray v0.17.2 ... was not used in
# the crate graph"`. The semver gap defeats a fork-by-git patch.
#
# What IS wired to the fork: the workspace's DIRECT ndarray dep
# (`ndarray = { path = "../../../ndarray" }` declared by lance-graph's own
# `crates/lance-graph/Cargo.toml`) — `Cargo.lock` lists `ndarray 0.17.2` as
# a separate entry from the local source. So the fork IS reachable for
# workspace-direct consumers. Only the lance TRANSITIVE remains on the
# crates.io 0.16.1.
#
# Attempted resolution (2026-05-28, user directive "just use [patch] to
# overwrite ndarray = 0.16 with 0.17.2"): the `[patch.crates-io]` block
# below points `ndarray` at the AdaWorldAPI fork. Cargo's `[patch]` does
# NOT force a version downgrade — if the fork's `0.17.2` doesn't semver-
# match lance-index's `0.16.1` requirement, cargo emits the warning
# `"Patch ndarray v0.17.2 ... was not used in the crate graph"` and the
# transitive continues to resolve to crates.io 0.16.1 in `Cargo.lock`.
# This patch is therefore a DECLARED INTENT (not a guaranteed effect):
# - It DOES wire workspace-direct ndarray consumers to the fork
# (already wired via the path dep in lance-graph's own Cargo.toml).
# - It DOES NOT guarantee the lance transitive switches off crates.io
# until upstream lance-index supports ndarray 0.17 OR the fork ships
# a `0.16.x`-versioned branch (see TD-NDARRAY-PATCH-0_16).
# Cross-ref: TECH_DEBT.md TD-NDARRAY-PATCH-0_16; PR #425 codex review.
#
# STILL OPEN — BLOCKED(C): `surrealdb` with `kv-lance` feature.
# Upstream surrealdb (crates.io) does NOT ship a `kv-lance` feature. This
# feature lives in the AdaWorldAPI fork (core/src/kvs/lance/ per
# cognitive-substrate.md). A fork-access human must supply:
Expand All @@ -68,30 +112,28 @@ resolver = "2"
# - the exact feature flag name (confirmed: `kv-lance` from spec)
# - whether a published crate path or `[patch.crates-io]` override is
# required for workspace compilation.
# Until resolved, surreal_container's `surrealdb` dep stays commented out.
#
# BLOCKED(D): lance-index → ndarray 0.16 transitive constraint.
# Lance 6 may pull lance-index which depends on ndarray 0.16.x. The
# workspace currently uses AdaWorldAPI/ndarray (a path dep). If Lance 6's
# transitive closure requires ndarray "0.16" from crates.io, a
# `[patch.crates-io]` entry must alias it to the fork path. This must be
# verified by the human with access to Lance 6's full Cargo.lock.
#
# Placeholder [workspace.dependencies] entries are left as comments below so
# that the draft is ready to uncomment once BLOCKED items are resolved:
#
# [workspace.dependencies]
# # BLOCKED(A): replace "=4.0.0" with confirmed Lance 6 semver
# lance = "=4.0.0" # TODO: bump to Lance 6 once BLOCKED(A) resolved
# lance-linalg = "=4.0.0" # TODO: bump in lock-step with lance
# lance-index = "=4.0.0" # TODO: bump in lock-step; see BLOCKED(D)
# lance-namespace = "=4.0.0" # TODO: bump in lock-step with lance
#
# # BLOCKED(B): replace "=0.27.2" with confirmed LanceDB 0.28 semver
# lancedb = "=0.27.2" # TODO: bump to 0.28 once BLOCKED(B) resolved
#
# # BLOCKED(C): replace stub with real git source + feature name
# # surrealdb = { git = "BLOCKED_SEE_C", branch = "BLOCKED_SEE_C", features = ["kv-lance"] }
# Crate-level pins (canonical source of truth — workspace.dependencies is not
# used; each consumer crate declares its own pin with exact-equals so the
# whole graph resolves to the same semver):
# lance = "=6.0.0" (lance-arrow / lance-index / lance-linalg /
# lance-namespace bump in lock-step)
# lancedb = "=0.29.0"
# datafusion = "53" (+ datafusion-common / -expr / -sql /
# -functions-aggregate)
# arrow-array = "58" (+ arrow-schema / -buffer / -ipc / arrow)

# ─── [patch.crates-io] — point ndarray at the AdaWorldAPI fork ──────────────
#
# [patch.crates-io]
# # BLOCKED(D): uncomment and fill once Lance 6 ndarray transitive version known
# # ndarray = { path = "../../../ndarray" }
# Per user directive 2026-05-28 ("don't use crates.io; try [patch]
# github.com/adaworldapi/ndarray.git or adjacent" → "just use [patch] to
# overwrite ndarray = 0.16 with 0.17.2"). The fork's `0.17.2` will:
# - Satisfy workspace-direct consumers (already wired via path dep).
# - Emit `"Patch ndarray v0.17.2 ... was not used in the crate graph"`
# against lance-index's `ndarray = "0.16.1"` until lance-index 0.17-
# compat lands OR a 0.16-line branch is added to the fork.
# The patch is a declared-intent override; effect on the transitive depends
# on semver compat. See BLOCKED(D) comment above + TD-NDARRAY-PATCH-0_16.
[patch.crates-io]
ndarray = { git = "https://github.com/AdaWorldAPI/ndarray.git", branch = "master" }
Comment on lines +127 to +139

@coderabbitai coderabbitai Bot May 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Update conflicting BLOCKED(D) narrative after adding the patch block.

After Line [138], the statement at Line [67]-Line [69] (“there is no [patch.crates-io] block in this workspace root”) is no longer true. Please update that earlier note so the dependency status section is internally consistent.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Cargo.toml` around lines 127 - 139, The note earlier in Cargo.toml that
claims "there is no `[patch.crates-io]` block in this workspace root" is now
incorrect because you added a [patch.crates-io] section overriding ndarray;
update that narrative to reflect the new state (e.g., mention that a
[patch.crates-io] override for ndarray now exists pointing to the AdaWorldAPI
fork and explain its implications such as the expected warning for lance-index's
ndarray = "0.16.1" and the BLOCKED(D) caveat). Locate the original sentence in
the dependency status commentary and replace or append a brief clarifying
sentence referencing the new [patch.crates-io] ndarray override so the document
is internally consistent.

Loading