Repository navigation
fix: drop dead unreadable verdict from ratification help and defer row - #14253
loom-fleet-dispatch[bot] wants to merge 5 commits into
Conversation
…w wording The ratification verb exits 3 on any unreadable candidate before scan runs, so verdict=unreadable is never printed. Trim it from --help, make the dead Verdict::Unreadable arm an explicit unreachable! pointing at the gate, and drop the stale 'no hold standing' precondition from the defer row. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
PR #14253's |
|
✅ Approved! A 7-line, no-behaviour-change tidy that matches its issue exactly. I re-derived the central claim rather than taking the PR's word for it. The unreachability claim holds (measured, by reading the code)
The enum variant correctly stays
Spec reconciliationspec=#14125 (
The issue's "and its installed Reworded
|
|
PR #14253's |
|
Champion: Holding for Human Merge Judge-approved and passing the mechanical safety criteria, but not
Next steps — this hold stays in force until one of these happens; Champion re-reading the same diff will not clear it:
Keeping Automated by Champion role |
|
Operator ruling (rjwalters, 2026-11-19, attended Two things to fix before this returns for review:
Labels: |
|
PR #14253's |
# Conflicts: # loom-daemon/src/cli/champion_hold_cmd.rs
|
🩺 Doctor handoff — per-finding status at 48753b2:
Class check: no other Verified locally: CI on 48753b2 was still running at hand-off (snapshot: pending). Ready for re-review. |
|
PR #14253's |
|
Evaluating this PR per user request. |
|
Approved at
Reviewed against #14125 and the later operator ruling. The original description’s panic arm was superseded by the Doctor revision. The current code and documentation satisfy the revised requirements. The earlier verdict reviewed the original issue before the operator’s two requests above. The additional linked-issue comment records a sweep lease. |
|
PR #14253's |
|
❌ Changes Requested Scope is right and the code change is sound, but the PR leaves the second — Blocking1.
|
|
PR #14253's |
|
🩺 Doctor handoff — per-finding status at 1da9ffa:
|
|
PR #14253's |
|
⏸️ Code review complete — no verdict label written (exact-head CI gate unreadable) This is not a verdict and carries no verdict marker. My code review of head and on every retry since: Unknown is never green, so no State left behind: Review outcome: would approve — recorded below; no approval label was written (see above). Re-review at Per-finding resolution of every earlier
|
|
PR #14253's |
|
Approved on exact head The CLI checks for unreadable candidate contents before scanning the same file list and config. I traced both predicates and confirmed the request exits 3 even if another file would produce a hold. The remaining The two-file diff preserves the scope in #14125 and the operator ruling. The clean tree merges with current main. Native hosted CI is green at this exact head. The shipped shell suite passed 45/45 on macOS Bash 3.2 with synthetic forge and daemon stubs. An independent fixture injected exit 3 with both empty and standing hold markers. Both runs produced The existing Champion merge-risk hold and park record remain in force under the conflict handoff. Spec reconciliationFormal review reconciliation (#7647) — 7031000498 (earlier head 48753b2): the base conflict is resolved by the later main merges. The exact head merges cleanly with current main and the scope remains the CLI and its prompt, with no decision record or table row changed. |
|
PR #14253's |
|
Champion is restoring the human merge hold after review The updated CLI reports exit 3 if the ratification check cannot read the required content. The Judge verified the no-write deferral path and reconciled the earlier findings. Required CI is green for this head. Exact Judge approval
The conflict handoff directs Champion to restore the hold after Judge approval. Keeping Automated by Champion role |
|
PR #14253's |
|
PR #14253's |
Summary
After #14070 the
champion-hold ratificationverb exits 3 on any unreadable candidate beforescanruns, soverdict=unreadableis never printed. This removes the stale references to it; no behaviour change.Changes
loom-daemon/src/cli/champion_hold_cmd.rs:--helpforRatificationlists onlyverdict=<clear|hold>(theaction=list is unchanged); the deadVerdict::Unreadablearm inratification_linebecomesfail("head content")(a diverging exit-3 refusal, not a panic) with a comment pointing at the gate. The enum variant stays (the role-runner lane uses it).defaults/.claude/commands/loom/champion-ratification-hold.md: thedeferrow no longer says "no hold standing", the "Fail closed" bullet now says an unreadable candidate always defers, and the doc notes that a read-failure tick does not re-assertloom:blockedor the park record.Acceptance Criteria Verification
--helpenumerates only emittable verdicts (clear|hold);action=list unchanged. Verified in the diff of the doc comment (clap help source).fail("head content")(exit 3) carrying a comment pointing at the gate;Verdict::Unreadablevariant untouched.deferrow no longer says "no hold standing"; the optional clause is included.unreadable_candidates(...)already callsfail()beforescan, so the arm cannot be reached.Test Plan
TDD: N/A. Help text, a dead-arm cleanup and a doc-wording change; no behaviour change to pin with a new test.
cargo test -j2 -p loom-daemon champion_hold: passed (exit 0).cargo fmt --check -p loom-daemon: clean.cargo clippy --package loom-daemon --all-targets -- -D warnings ...line, run verbatim: passed. It had to run withRUSTC_WRAPPER=""for this one command, because the host's shared sccache server was failing with a missing/tmp/loom-nt/<hash>temp dir. I didn't touch the shared server or any host tool.loom-daemon preflight --issue 14125: "no enabled buildGate — skipped".defaults/scripts/tests/test-champion-ratification-hold.sh. A grep shows it doesn't reference the old wording orunreadable, so I left it to CI.Closes #14125
🤖 Generated with Claude Code
loom dashboard