Repository navigation
fix: drop unreachable action=defer from champion-hold ratification --help - #14322
Conversation
|
PR #14322's |
|
✅ Approved! A one-line doc-comment narrowing in Spec reconciliationReviewed against #14271's current body (Observed section + Curator Enhancement Premise re-verified independently (not taken from the PR body)The claim is that
Consumer contract is unaffected — the Champion tick derives Out-of-scope boundaries held: Class sweepSearched for other stale enumerations of the same shape, as a pattern not a Single source of truth, now correct. No other instance in the repo. Test ExecutionTest plan from PR description:
Live-verification triggers (A) and (B) both checked and neither fires: the
Non-blocking follow-up filedFiled #14332: Merge sequencing#14253 (open,
|
|
PR #14322's |
|
Champion: Holding for Human Merge Judge-approved and passing the mechanical safety criteria, but not
Next steps — this hold stays in force until one of these happens; Champion re-reading the same diff will not clear it:
Whichever path releases it, Champion will post a comment naming what changed before it merges. Keeping Automated by Champion role |
|
clear the hold — operator ruling (rjwalters, 2026-11-19, attended The kept-set hold is right in general (the gate cannot vouch for itself); this diff at |
|
Champion hold released by operator @rjwalters released the human-merge hold on this PR and is merging it at approved head
|
Summary
The
Ratificationdoc comment still advertisedaction=defereven though the #13932 fail-closed gate inratification_lineexits 3 on an unreadable head beforedecidecan ever produceAction::Deferon this verb's stdout. This narrows theaction=enumeration to the values the verb can actually emit, mirroring what #14253 did forverdict=.Changes
loom-daemon/src/cli/champion_hold_cmd.rs: removed|deferfrom theaction=list in theRatificationdoc comment (help text only; no behaviour change).Acceptance Criteria Verification
Ratificationdoc comment listsaction=<none|hold|stands|release|clear>git diffshows exactly that enumeration; live./target/debug/loom-daemon champion-hold ratification --helpprintsaction=<none|hold|stands|release|clear>with 0deferoccurrencesAction::Defer,decide, role-runner lane, tick table unchangedaction=line only);git grep Action::Deferstill finds the variant untouched inratification.rsandrole_runner/ratification_lane.rscargo check -p loom-daemonpassesdevprofile in 2m 11s (run withRUSTC_WRAPPER=— the host sccache server has a stale temp dir,/tmp/loom-nt/.../sccachetNoLMC, which fails every cold compile; likely why prior builder passes on this issue died unclassified. Not fixed here — host-tool issue, out of scope)Test Plan
RUSTC_WRAPPER= cargo check -p loom-daemon -j 2— green.RUSTC_WRAPPER= cargo build -p loom-daemon -j 2thenloom-daemon champion-hold ratification --help— nodefer, enumeration readsnone|hold|stands|release|clear.grep -rn 'action=<' loom-daemon/src— no other stale enumeration (single hit, this line).grep -rn 'clear|defer\|defer>' defaults .loom .claude— no stale doc-side enumeration; tick table derivesdeferfrom exit code as the issue notes.TDD: no — help-text-only change, no executing behaviour to test first (per builder-pr.md § "Test-First Discipline", docs/config-only diffs omit the line's test leg).
Note: PR #14253 (open,
loom:pr) narrows the adjacentverdict=line of the same comment and is not yet onorigin/main(verifiedgit show origin/main:...still listsunreadable). This PR branches from main and does not touchverdict=, so merging both leaves at most a trivial adjacent-line conflict, per the curation sequencing note. That conflict is expected, not an oversight.Closes #14271
loom dashboard