Skip to content

champion-hold ratification: --help still advertises action=defer, which the verb can no longer emit #14271

Closed

Description

@loom-fleet-dispatch

Observed

Measured by reading origin/main + PR #14253's diff (no live verb run):

PR #14253 (issue #14125) narrowed the Ratification --help verdict
enumeration to verdict=<clear|hold> because the #13932 fail-closed gate in
ratification_line exits 3 before scan can return Verdict::Unreadable.
The same gate makes one of the advertised action= values dead for the
same reason, and that half was explicitly held out of #14125's scope
("action= list unchanged").

decide (loom-daemon/src/champion_hold/ratification.rs:359-374) produces
Action::Defer from exactly one arm:

(Verdict::Unreadable(_), Episode::None | Episode::Released { .. }) => Action::Defer,

ratification_line (loom-daemon/src/cli/champion_hold_cmd.rs:283-312) calls
decide(&verdict, &comments, &head) only after the gate, so verdict there
is Clear or Hold — never Unreadable. Therefore action=defer can never
appear on this verb's stdout, yet the doc comment at
champion_hold_cmd.rs:60-62 still lists
action=<none|hold|stands|release|clear|defer>.

grep -rn "LOOM-CHAMPION-RATIFICATION" confirms ratification_line is the
only producer of that line, so there is no second code path that could emit it.

The tick table in defaults/.claude/commands/loom/champion-ratification-hold.md
is already correct on this point and needs no change: it derives defer
from the exit code, not from action= ("Exit 3 or no stdout (a failed read)
is defer"), and its RT_ACTION sed only reads action= on a rc=0 line.

Changes Needed

  • Narrow the action= enumeration in the Ratification doc comment
    (champion_hold_cmd.rs:60-62) to the values the verb can emit
    (none|hold|stands|release|clear), the same way fix: drop dead unreadable verdict from ratification help and defer row #14253 narrowed verdict=.
  • Leave the Action::Defer enum variant alone — it is live in decide and in
    the role-runner lane (role_runner/ratification_lane.rs), which calls scan
    directly and so does see Verdict::Unreadable.
  • No behaviour change; help text only.

Out of Scope

Discovered while evaluating PR #14253.

loom dashboard


Curator Enhancement (2026-11-18)

Problem Statement

loom-daemon champion-hold ratification --help lists action=defer, which the verb can never print (verified on origin/main @ e401ea26e, 2026-11-18: ratification_line exits 3 via fail("head content") before decide runs, so verdict is only Clear/Hold; Action::Defer comes solely from the (Verdict::Unreadable(_), …) arm at ratification.rs:369). Help text misleads readers about reachable outputs.

Acceptance Criteria

  • The Ratification doc comment in champion_hold_cmd.rs (currently lines 59-62 on main) lists action=<none|hold|stands|release|clear> — defer removed.
  • Action::Defer, decide, the role-runner lane and the tick table are unchanged.
  • cargo check -p loom-daemon passes (doc-comment-only diff).

Implementation Guidance

Single doc-comment edit. Sequencing: PR #14253 (open, loom:pr, not yet on origin/main as of this curation) edits the same comment (verdict=<clear|hold|unreadable> → <clear|hold>). Builder: check git show origin/main:loom-daemon/src/cli/champion_hold_cmd.rs | sed -n 55,65p — if it still says unreadable>, #14253 hasn't merged; rebase onto it once it does (or expect a trivial conflict on adjacent lines) rather than reverting its verdict= change. Rejected: folding into #14253 (already reviewed/approved).

Out of Scope

Affected Files

  • loom-daemon/src/cli/champion_hold_cmd.rs - narrow action= list in Ratification doc comment

Test Plan

  • Manual verification: loom-daemon champion-hold ratification --help shows no defer.
  • Automated tests: N/A (help text only); run cargo check -p loom-daemon.
  • Edge cases: confirm grep -rn "action=<" loom-daemon/src has no other stale enumeration.

Duplicate check: only related open work is PR #14253 (absorbed — sequencing note above).

Activity

  1. added
    loom:triageNew issue awaiting Curator enhancement. Applied by: humans or any agent filing an issue (intake).
    on Nov 18, 2026
  2. loom-fleet-dispatch commented on Nov 18, 2026

    @loom-fleet-dispatch
    ContributorAuthor

    PR #14271's loom:curating claim is held by the curator of sweep step-curator-14271-1795007307 on host host-d0749b00. This comment is a PR lease record (#9401): its liveness signal is its own forge-assigned updated_at, renewed while the curator works and released when it is done. Another curator that finds this lease live stands down before touching a worktree. See defaults/docs/lease-record.md § "PR-phase leases".

  3. added
    loom:curatingCurator is enhancing this issue. Applied by: Curator only (claim label).
    loom:curatedCurator-enriched, awaiting approval. Additive; coexists with loom:issue. Applied by: Curator only.
    points:1Story-point size class 1. Applied by: Curator via loom-daemon curation-complete.
    and removed
    loom:curatingCurator is enhancing this issue. Applied by: Curator only (claim label).
    loom:triageNew issue awaiting Curator enhancement. Applied by: humans or any agent filing an issue (intake).
    on Nov 18, 2026
  4. loom-fleet-dispatch commented on Nov 18, 2026

    @loom-fleet-dispatch
    ContributorAuthor

    PR #14271's loom:evaluating claim is held by the champion of sweep step-champion_promote-14271-1795007735 on host host-e1d4c843. This comment is a PR lease record (#9401): its liveness signal is its own forge-assigned updated_at, renewed while the champion works and released when it is done. Another champion that finds this lease live stands down before touching a worktree. See defaults/docs/lease-record.md § "PR-phase leases".

  5. added
    loom:evaluatingChampion is evaluating this proposal (claim label, stale after 15m). Applied by: Champion only.
    loom:issueApproved for work. Applied by: humans, Champion, sweep gate — see curator.md.
    and removed
    loom:evaluatingChampion is evaluating this proposal (claim label, stale after 15m). Applied by: Champion only.
    on Nov 18, 2026
  6. loom-fleet-dispatch commented on Nov 18, 2026

    @loom-fleet-dispatch
    ContributorAuthor

    Champion Review: APPROVED

    This issue has been evaluated and promoted to loom:issue status. All 8 quality criteria passed. Re-verified against origin/main: ratification_line exits 3 on an unreadable candidate before decide runs, so action=defer is unreachable on this verb's stdout, and the Ratification doc comment still lists it.

    Goal Alignment: Keeps CLI help text truthful. It is a 1-point, doc-comment-only change.

    Builder note: PR #14253 (open) edits the adjacent verdict= lines of the same doc comment. Rebase onto it once it merges, or expect a trivial conflict. Do not revert its change.

    Ready for Builder to claim.


    Automated by Champion role

    loom dashboard

  7. loom-fleet-dispatch commented on Nov 18, 2026

    @loom-fleet-dispatch
    ContributorAuthor

    PR #14271's loom:evaluating claim is held by the champion of sweep step-champion_promote-14271-1795007799 on host host-a6032f0c. This comment is a PR lease record (#9401): its liveness signal is its own forge-assigned updated_at, renewed while the champion works and released when it is done. Another champion that finds this lease live stands down before touching a worktree. See defaults/docs/lease-record.md § "PR-phase leases".

  8. added
    loom:buildingBuilder is implementing this issue. Applied by: Builder only (claim label).
    and removed
    loom:issueApproved for work. Applied by: humans, Champion, sweep gate — see curator.md.
    on Nov 18, 2026
  9. loom-fleet-dispatch commented on Nov 18, 2026

    @loom-fleet-dispatch
    ContributorAuthor

    This issue's loom:building claim was acquired by builder step step-builder-14271-1795007963 on host host-d0749b00 at 2026-11-18T13:19:25.522323561+00:00. This comment is a lease record (Issue #6179, Epic #6165) — its liveness signal is this comment's own forge-assigned updated_at, never a timestamp embedded in this text. See defaults/docs/lease-record.md for the format contract this establishes, and defaults/docs/lease-renewal.md for how the owning sweep keeps it fresh for the lifetime of its claim.

    loom dashboard

  10. added
    loom:issueApproved for work. Applied by: humans, Champion, sweep gate — see curator.md.
    and removed
    loom:buildingBuilder is implementing this issue. Applied by: Builder only (claim label).
    on Nov 18, 2026
  11. loom-fleet-dispatch commented on Nov 18, 2026

    @loom-fleet-dispatch
    ContributorAuthor

    Builder step ended without a PR (reason: unclassified). It left no .no-changes-needed conclusion, so this is a failed pass, not a deliberate no-op. The daemon will retry under its failure ladder.

  12. added
    loom:buildingBuilder is implementing this issue. Applied by: Builder only (claim label).
    and removed
    loom:issueApproved for work. Applied by: humans, Champion, sweep gate — see curator.md.
    on Nov 18, 2026
  13. loom-fleet-dispatch commented on Nov 18, 2026

    @loom-fleet-dispatch
    ContributorAuthor

    This issue's loom:building claim was acquired by builder step step-builder-14271-1795009843 on host host-e1d4c843 at 2026-11-18T13:50:45.652120048+00:00. This comment is a lease record (Issue #6179, Epic #6165) — its liveness signal is this comment's own forge-assigned updated_at, never a timestamp embedded in this text. See defaults/docs/lease-record.md for the format contract this establishes, and defaults/docs/lease-renewal.md for how the owning sweep keeps it fresh for the lifetime of its claim.

    loom dashboard

  14. removed
    loom:buildingBuilder is implementing this issue. Applied by: Builder only (claim label).
    on Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    loom:curatedCurator-enriched, awaiting approval. Additive; coexists with loom:issue. Applied by: Curator only.points:1Story-point size class 1. Applied by: Curator via loom-daemon curation-complete.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions