Repository navigation
Description
Observed
Measured by reading origin/main + PR #14253's diff (no live verb run):
PR #14253 (issue #14125) narrowed the Ratification --help verdict
enumeration to verdict=<clear|hold> because the #13932 fail-closed gate in
ratification_line exits 3 before scan can return Verdict::Unreadable.
The same gate makes one of the advertised action= values dead for the
same reason, and that half was explicitly held out of #14125's scope
("action= list unchanged").
decide (loom-daemon/src/champion_hold/ratification.rs:359-374) produces
Action::Defer from exactly one arm:
(Verdict::Unreadable(_), Episode::None | Episode::Released { .. }) => Action::Defer,ratification_line (loom-daemon/src/cli/champion_hold_cmd.rs:283-312) calls
decide(&verdict, &comments, &head) only after the gate, so verdict there
is Clear or Hold — never Unreadable. Therefore action=defer can never
appear on this verb's stdout, yet the doc comment at
champion_hold_cmd.rs:60-62 still lists
action=<none|hold|stands|release|clear|defer>.
grep -rn "LOOM-CHAMPION-RATIFICATION" confirms ratification_line is the
only producer of that line, so there is no second code path that could emit it.
The tick table in defaults/.claude/commands/loom/champion-ratification-hold.md
is already correct on this point and needs no change: it derives defer
from the exit code, not from action= ("Exit 3 or no stdout (a failed read)
is defer"), and its RT_ACTION sed only reads action= on a rc=0 line.
Changes Needed
- Narrow the
action=enumeration in theRatificationdoc comment
(champion_hold_cmd.rs:60-62) to the values the verb can emit
(none|hold|stands|release|clear), the same way fix: drop dead unreadable verdict from ratification help and defer row #14253 narrowedverdict=. - Leave the
Action::Deferenum variant alone — it is live indecideand in
the role-runner lane (role_runner/ratification_lane.rs), which callsscan
directly and so does seeVerdict::Unreadable. - No behaviour change; help text only.
Out of Scope
- The champion-hold ratification returns a non-deterministic files= evidence list at rc=0: a subset of the changed paths is silently omitted against an unchanged head #13932 gate, exit codes, or re-asserting
rt_parkondefer. - The tick table wording (already accurate, see above).
Discovered while evaluating PR #14253.
Curator Enhancement (2026-11-18)
Problem Statement
loom-daemon champion-hold ratification --help lists action=defer, which the verb can never print (verified on origin/main @ e401ea26e, 2026-11-18: ratification_line exits 3 via fail("head content") before decide runs, so verdict is only Clear/Hold; Action::Defer comes solely from the (Verdict::Unreadable(_), …) arm at ratification.rs:369). Help text misleads readers about reachable outputs.
Acceptance Criteria
- The
Ratificationdoc comment inchampion_hold_cmd.rs(currently lines 59-62 on main) listsaction=<none|hold|stands|release|clear>—deferremoved. -
Action::Defer,decide, the role-runner lane and the tick table are unchanged. -
cargo check -p loom-daemonpasses (doc-comment-only diff).
Implementation Guidance
Single doc-comment edit. Sequencing: PR #14253 (open, loom:pr, not yet on origin/main as of this curation) edits the same comment (verdict=<clear|hold|unreadable> → <clear|hold>). Builder: check git show origin/main:loom-daemon/src/cli/champion_hold_cmd.rs | sed -n 55,65p — if it still says unreadable>, #14253 hasn't merged; rebase onto it once it does (or expect a trivial conflict on adjacent lines) rather than reverting its verdict= change. Rejected: folding into #14253 (already reviewed/approved).
Out of Scope
- The champion-hold ratification returns a non-deterministic files= evidence list at rc=0: a subset of the changed paths is silently omitted against an unchanged head #13932 gate, exit codes,
Action::Defervariant, role-runner lane, tick-table wording (already accurate).
Affected Files
loom-daemon/src/cli/champion_hold_cmd.rs- narrowaction=list inRatificationdoc comment
Test Plan
- Manual verification:
loom-daemon champion-hold ratification --helpshows nodefer. - Automated tests: N/A (help text only); run
cargo check -p loom-daemon. - Edge cases: confirm
grep -rn "action=<" loom-daemon/srchas no other stale enumeration.
Duplicate check: only related open work is PR #14253 (absorbed — sequencing note above).
Activity
loom-fleet-dispatch commentedon Nov 18, 2026
PR #14271's
loom:curatingclaim is held by the curator of sweepstep-curator-14271-1795007307on hosthost-d0749b00. This comment is a PR lease record (#9401): its liveness signal is its own forge-assignedupdated_at, renewed while the curator works and released when it is done. Another curator that finds this lease live stands down before touching a worktree. Seedefaults/docs/lease-record.md§ "PR-phase leases".loom-fleet-dispatch commentedon Nov 18, 2026
PR #14271's
loom:evaluatingclaim is held by the champion of sweepstep-champion_promote-14271-1795007735on hosthost-e1d4c843. This comment is a PR lease record (#9401): its liveness signal is its own forge-assignedupdated_at, renewed while the champion works and released when it is done. Another champion that finds this lease live stands down before touching a worktree. Seedefaults/docs/lease-record.md§ "PR-phase leases".loom-fleet-dispatch commentedon Nov 18, 2026
Champion Review: APPROVED
This issue has been evaluated and promoted to
loom:issuestatus. All 8 quality criteria passed. Re-verified againstorigin/main:ratification_lineexits 3 on an unreadable candidate beforedecideruns, soaction=deferis unreachable on this verb's stdout, and theRatificationdoc comment still lists it.Goal Alignment: Keeps CLI help text truthful. It is a 1-point, doc-comment-only change.
Builder note: PR #14253 (open) edits the adjacent
verdict=lines of the same doc comment. Rebase onto it once it merges, or expect a trivial conflict. Do not revert its change.Ready for Builder to claim.
Automated by Champion role
loom dashboard
loom-fleet-dispatch commentedon Nov 18, 2026
PR #14271's
loom:evaluatingclaim is held by the champion of sweepstep-champion_promote-14271-1795007799on hosthost-a6032f0c. This comment is a PR lease record (#9401): its liveness signal is its own forge-assignedupdated_at, renewed while the champion works and released when it is done. Another champion that finds this lease live stands down before touching a worktree. Seedefaults/docs/lease-record.md§ "PR-phase leases".loom-fleet-dispatch commentedon Nov 18, 2026
This issue's
loom:buildingclaim was acquired by builder stepstep-builder-14271-1795007963on hosthost-d0749b00at 2026-11-18T13:19:25.522323561+00:00. This comment is a lease record (Issue #6179, Epic #6165) — its liveness signal is this comment's own forge-assignedupdated_at, never a timestamp embedded in this text. Seedefaults/docs/lease-record.mdfor the format contract this establishes, anddefaults/docs/lease-renewal.mdfor how the owning sweep keeps it fresh for the lifetime of its claim.loom dashboard
loom-fleet-dispatch commentedon Nov 18, 2026
Builder step ended without a PR (reason:
unclassified). It left no.no-changes-neededconclusion, so this is a failed pass, not a deliberate no-op. The daemon will retry under its failure ladder.loom-fleet-dispatch commentedon Nov 18, 2026
This issue's
loom:buildingclaim was acquired by builder stepstep-builder-14271-1795009843on hosthost-e1d4c843at 2026-11-18T13:50:45.652120048+00:00. This comment is a lease record (Issue #6179, Epic #6165) — its liveness signal is this comment's own forge-assignedupdated_at, never a timestamp embedded in this text. Seedefaults/docs/lease-record.mdfor the format contract this establishes, anddefaults/docs/lease-renewal.mdfor how the owning sweep keeps it fresh for the lifetime of its claim.loom dashboard