Skip to content

ci: qualify released analyzer and shared lint pilot - #31

Merged
ss-o merged 1 commit into
mainfrom
feature-30-lint-pilot
Sep 27, 2026
Merged

ss-o merged 1 commit into
mainfrom
feature-30-lint-pilot

Conversation

@ss-o

@ss-o ss-o commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Summary

Enroll the shared lint observation pilot for build.zsh only, preserving Zsh 5.5.1 as the declared compatibility floor. Migrate the canonical config to schema v2 and identifier zunit, and update the existing caller to released analyzer v1.3.0 because that release rejects the old schema. Keep the existing required check name and native/functional workflows unchanged.

Refs #30; supports z-shell/.github#673. The config and pin migration was explicitly approved after isolated qualification. Required-check settings remain unchanged.

Verification

  • Passed: all 125 native tests on Zsh 5.9.2, build, native syntax/compilation of build.zsh, and scoped Trunk checks. This does not add runtime-floor evidence for Zsh 5.5.1.
  • Original analyzer/config: one file, zero diagnostics. New v1.3.0 direct invocation and shared wrapper with schema v2: identical reports, one file and zero diagnostics.
  • The shared pinned wrapper/analyzer combination passed isolated clean, warning observe/strict and malformed-config probes during annex qualification.
  • Passed: hosted pilot, with exact pins and one-file zero-diagnostic artifact; existing lint, native tests, syntax and all other PR checks passed. Fork qualification subsequently passed; see the completion record below.

Agent handoff

Pilot qualification is complete. Main, ordinary PR and documentation-only fork runs passed; read-only token permissions, no secrets and artifact provenance were verified. Complete qualification evidence is recorded on #30, which is closed. The new observation check remains advisory; required-check settings remain separate.

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback review under ADR-0026: Copilot request not registered on 5902bef

No actionable findings in the complete four-file diff.

Note

This is the maintainer-authorized self-review fallback, not an independent review. Copilot returned no reviewer and no Copilot request event registered; cause unconfirmed. The canonical organization code-review skill and checklist were used because this repository has no local delivery copy.

  • Configuration and compatibility: pass. Schema v2 requires identifier and rejects the old namespace field. The config and analyzer pin move together under the approved migration, retaining tool kind, Zsh 5.5.1 floor and the single standalone build.zsh input. The previous analyzer/config and both new direct/wrapped invocations all report one file with zero diagnostics. Runtime sources and build behavior are unchanged.
  • Workflow and security: pass. Both workflows select released v1.3.0 by its verified commit. The new reusable workflow pin is the reviewed implementation, uses explicit observe mode and configuration, has unfiltered main PR/push triggers and distinct concurrency. Permissions are contents-read only; no secrets are passed and the callee disables persisted credentials and shared caches. The existing required check name is preserved.
  • Verification: pass. All 125 native tests passed on Zsh 5.9.2, including the existing lint-trigger contract. Native syntax, compilation, build and Trunk passed. The hosted pilot artifact confirms both pins and one file with zero diagnostics; existing lint, native tests, syntax and all PR checks passed. The pinned wrapper/analyzer pair passed isolated clean, warning observe/strict and malformed-config probes during annex qualification.
  • Documentation and rollback: pass. The guide limits inventory explicitly, distinguishes declared floor from runtime evidence, and requires restoring config and analyzer together on rollback. Required-check changes remain separate.

Limits: The current validation does not newly prove runtime compatibility on Zsh 5.5.1. Actual documentation-only fork execution remains to be qualified after merge. Keep #30 open until that proof is recorded; the new check remains advisory.

@ss-o
ss-o merged commit 94bf8d6 into main Sep 27, 2026
13 checks passed
@ss-o
ss-o deleted the feature-30-lint-pilot branch September 27, 2026 06:08
@ss-o ss-o added area:ci Continuous integration or GitHub Actions work. type:feature A request for new behavior or capability. labels Sep 27, 2026
@ss-o ss-o moved this to Done in Z-shell Delivery Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci Continuous integration or GitHub Actions work. type:feature A request for new behavior or capability.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant