Repository navigation
ci: qualify released analyzer and shared lint pilot - #31
Merged
Merged
Conversation
ss-o
commented
Sep 27, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on 5902bef
No actionable findings in the complete four-file diff.
Note
This is the maintainer-authorized self-review fallback, not an independent review. Copilot returned no reviewer and no Copilot request event registered; cause unconfirmed. The canonical organization code-review skill and checklist were used because this repository has no local delivery copy.
- Configuration and compatibility: pass. Schema v2 requires
identifierand rejects the old namespace field. The config and analyzer pin move together under the approved migration, retaining tool kind, Zsh 5.5.1 floor and the single standalonebuild.zshinput. The previous analyzer/config and both new direct/wrapped invocations all report one file with zero diagnostics. Runtime sources and build behavior are unchanged. - Workflow and security: pass. Both workflows select released v1.3.0 by its verified commit. The new reusable workflow pin is the reviewed implementation, uses explicit observe mode and configuration, has unfiltered main PR/push triggers and distinct concurrency. Permissions are contents-read only; no secrets are passed and the callee disables persisted credentials and shared caches. The existing required check name is preserved.
- Verification: pass. All 125 native tests passed on Zsh 5.9.2, including the existing lint-trigger contract. Native syntax, compilation, build and Trunk passed. The hosted pilot artifact confirms both pins and one file with zero diagnostics; existing lint, native tests, syntax and all PR checks passed. The pinned wrapper/analyzer pair passed isolated clean, warning observe/strict and malformed-config probes during annex qualification.
- Documentation and rollback: pass. The guide limits inventory explicitly, distinguishes declared floor from runtime evidence, and requires restoring config and analyzer together on rollback. Required-check changes remain separate.
Limits: The current validation does not newly prove runtime compatibility on Zsh 5.5.1. Actual documentation-only fork execution remains to be qualified after merge. Keep #30 open until that proof is recorded; the new check remains advisory.
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enroll the shared lint observation pilot for
build.zshonly, preserving Zsh 5.5.1 as the declared compatibility floor. Migrate the canonical config to schema v2 and identifierzunit, and update the existing caller to released analyzer v1.3.0 because that release rejects the old schema. Keep the existing required check name and native/functional workflows unchanged.Refs #30; supports z-shell/.github#673. The config and pin migration was explicitly approved after isolated qualification. Required-check settings remain unchanged.
Verification
build.zsh, and scoped Trunk checks. This does not add runtime-floor evidence for Zsh 5.5.1.Agent handoff
Pilot qualification is complete. Main, ordinary PR and documentation-only fork runs passed; read-only token permissions, no secrets and artifact provenance were verified. Complete qualification evidence is recorded on #30, which is closed. The new observation check remains advisory; required-check settings remain separate.