Feature: Override template backdrop container name

[Tilix4]

Changelog Description

Add override name support for Harmony template loading (backdrop containers)

Additional review information

This allows more flexibility over how data are published and loaded. Also allows to add {folder[name} in container name while it is not handled in core side ynput/ayon-core#1213

Testing notes:

• configure TemplateLoader setting override_name to a bracketed template (e.g. {folder[name]}_{product[name]})
• load a tpl representation and verify the loaded backdrop is renamed accordingly
• load without override set; ensure default naming still works and no errors occur when no backdrops are initially selected

[kalisp]

This doesn't seem right, this will result in duplicate names if overrideName and same template will be loaded.

[Tilix4]

You're right, I don't know why I over thought this. Fixed

[kalisp]

This will also break logic:

        var backdropName = allBackdrops[i].title.text;
        var splitted = splitByLastDelimiter(backdropName, '_');
        var count = splitted[1] !== undefined ? splitted[1] : 1;
        backdropName = splitted[0];

where it was assumed, that there won't be any other '_' delimiter but possibly at the end denoting unique ordinal number of backdrop. (Same template loaded multiple times should have different name 'harmony.templeteMain_1, harmony.template_2`.

[Tilix4]

This will also break logic:

Fixed weeks ago.

[Tilix4]

Hi @kalisp I'm facing something strange: the incremental naming feature you asked me to preserve in this PR is no longer working (has it even worked?). Is it working on your side in the develop branch? Because it doesn't on mine and I cannot remember it did for sure...

[kalisp]

the incremental naming feature you asked me to preserve in this PR is no longer working (has it even worked?).

It seems to be working for me in develop for me (see harmony.templateMain_3, harmony.templateMain_4)

(Not completely sure where the color of main backdrop wrapper go, but naming changes.)

[kalisp]

In this PR is somehow understood, that there are already 2 templateMain, but then it kept using same name for all additional loads.

(And I thinks it should had be sq01_harmony.templateMain (without 3) as that name would be unique when first loaded as harmony.templateMain vs sq01_harmony.templateMain)

(Override container name used {folder[name]}_{product[name]})

[kalisp]

And later change to template didnt propagate. It kept using sq01_harmony.templateMain.

[Tilix4]

And later change to template didnt propagate. It kept using sq01_harmony.templateMain.

Did you restart your harmony?

[kalisp]

Did you restart your harmony?

Fck, damn project overrides, skillz issue :/.

But there is still some issue. According to log (left column) it thinks there should be new_sq01_harmony.templateMain used (which is expected), but it still names it harmony.templateMain)

Next two same loads use correct value for the first time, but will not increment for second time.

(Double checked everything if it is not problem between chair and keybord, won't be first time, wont be last :/)

[Tilix4]

It seems to be working for me in develop for me (see harmony.templateMain_3, harmony.templateMain_4)

I'm really sorry but I cannot make it work 😭 Could list the steps you're following?
On my side I'm basically loading twice in a row the exact same product. Is that what you're doing too? Or do you have any other step?

[kalisp]

[kalisp]

Hm, multiple render names are bit wonky (as I would expect _0 resp _1 at the end), but Manage still differentiate between two nodes/instances, which is more important.

[Tilix4]

I found the issue, I proposed a fix there #105. Will update the current PR when the fix will be merged because working code relies on it.

[Tilix4]

@kalisp ready to be tested

[kalisp]

Now it works fine.

Thanks for contribution.