Fix: Incremental template container naming#105
Merged
Conversation
kalisp
approved these changes
Feb 6, 2026
Member
kalisp
left a comment
kalisp
left a comment
There was a problem hiding this comment.
Works for both, with or without underscores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Incremental container naming works even for product with
_character in the name.Additional review information
Because of the
_splitting, the increment detection was messy.Kind of related to #97 and from the discussion in #95.
Testing notes:
_in its name (e.g. change the product name pattern setting for{product[type]}_{variant}