Skip to content

[Backport stable-26-3-1] PR #59838: Change fetch for seed-nodes permissions - #59953

Open
ydbot wants to merge 2 commits into
stable-26-3-1from
robots/backport/cherry-pick-stable-26-3-1-261118-183548
Open

ydbot wants to merge 2 commits into
stable-26-3-1from
robots/backport/cherry-pick-stable-26-3-1-261118-183548

Conversation

@ydbot

@ydbot ydbot commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Changelog entry

Change fetch for seed-nodes permissions: Change fetch for seed-nodes permissions

Description for reviewers

Original PR(s)

Metadata

Conflict resolution

Resolved the SDK changelog conflict. Preserved existing stable-26-3-1 entries and added only the seed-node fetch fix.

Git Cherry-Pick Log

=== Cherry-picking eb24e03 ===
Auto-merging ydb/core/grpc_services/rpc_config.cpp
Auto-merging ydb/public/sdk/cpp/CHANGELOG.md
CONFLICT (content): Merge conflict in ydb/public/sdk/cpp/CHANGELOG.md
Auto-merging ydb/public/sdk/cpp/tests/unit/client/ya.make
Auto-merging ydb/services/config/bsconfig_ut.cpp
Auto-merging ydb/tests/functional/config/test_distconf.py
Auto-merging ydb/tests/library/harness/kikimr_runner.py

error: could not apply eb24e03bf75... Change fetch for seed-nodes permissions (#59838)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

PR was created by cherry-pick workflow run

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-18 18:39:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9df699f has started.
⚪ 2026-11-18 18:40:38 UTC Artifacts will be uploaded here
⚪ 2026-11-18 18:42:02 UTC ya make is running...
⚫ 2026-11-18 19:13:42 UTC Check cancelled

@mregrock mregrock changed the title [CONFLICT] [Backport stable-26-3-1] PR #59838: Change fetch for seed-nodes permissions [Backport stable-26-3-1] PR #59838: Change fetch for seed-nodes permissions Nov 18, 2026
@mregrock
mregrock marked this pull request as ready for review November 18, 2026 19:14
@mregrock
mregrock requested a review from a team as a code owner November 18, 2026 19:14
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-18 19:16:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for c2d86dd has started.
⚪ 2026-11-18 19:18:29 UTC Artifacts will be uploaded here
⚪ 2026-11-18 19:19:50 UTC ya make is running...
🟡 2026-11-18 22:13:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58138 56405 0 5 1716 12

⚪ 2026-11-18 22:14:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2026-11-18 22:18:05 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 69 0 0 3 1

🟢 2026-11-18 22:18:08 UTC Build successful.
🔴 2026-11-18 22:18:30 UTC ydbd size 2.6 GiB changed* by +3.8 MiB, which is >= 2.0 MiB vs stable-26-3-1: Alert

ydbd size dash stable-26-3-1: 40d9e3a merge: c2d86dd diff diff %
ydbd size 2 837 812 288 Bytes 2 841 803 840 Bytes +3.8 MiB +0.141%
ydbd stripped size 590 585 304 Bytes 591 208 568 Bytes +608.7 KiB +0.106%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@robot-vibe-db robot-vibe-db Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review Summary

Verdict: ✅ No Critical or Major issues found

Critical and Major issues

No Critical or Major issues found.

Other findings

None.


This review was generated automatically. Critical and Major issues require attention; Minor and Nit findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants