Repository navigation
Change fetch for seed-nodes permissions - #59838
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
✅ Documentation buildRevision built successfully |
✅ Documentation buildRevision built successfully |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| if (!NKikimr::IsAdministrator(AppData(), userToken) && | ||
| !(isNodeBootstrap && NKikimr::IsTokenAllowed(userToken, AppData()->RegisterDynamicNodeAllowedSIDs))) { | ||
| self->Reply(Ydb::StatusIds::UNAUTHORIZED, "User is not a cluster administrator.", | ||
| NKikimrIssues::TIssuesIds::ACCESS_DENIED, self->ActorContext()); | ||
| return; |
There was a problem hiding this comment.
Я бы разделил сообщения об ошибке для разных случаев. Register-node всё-таки не админ.
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
✅ Documentation buildRevision built successfully |
|
Backport results:
|
Changelog entry
Change fetch for seed-nodes permissions
Description for reviewers
...