Skip to content

Change fetch for seed-nodes permissions - #59838

Merged
mregrock merged 4 commits into
ydb-platform:mainfrom
mregrock:change_seed_nodes_permissions
Nov 18, 2026
Merged

mregrock merged 4 commits into
ydb-platform:mainfrom
mregrock:change_seed_nodes_permissions

Conversation

@mregrock

Copy link
Copy Markdown
Contributor

Changelog entry

Change fetch for seed-nodes permissions

Description for reviewers

...

@mregrock
mregrock marked this pull request as ready for review November 17, 2026 14:51
@mregrock
mregrock requested a review from a team as a code owner November 17, 2026 14:51
Copilot AI balanced review requested due to automatic review settings November 17, 2026 14:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-17 14:54:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 71477ee has started.
⚪ 2026-11-17 14:54:56 UTC Artifacts will be uploaded here
🔴 2026-11-17 14:55:57 UTC Graph compare failed, see the logs.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions

Copy link
Copy Markdown
Contributor

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-17 15:25:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 889c475 has started.
⚪ 2026-11-17 15:26:16 UTC Artifacts will be uploaded here
⚪ 2026-11-17 15:27:46 UTC ya make is running...
🟡 2026-11-17 17:26:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65555 63754 0 2 1793 6

⚪ 2026-11-17 17:26:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2026-11-17 17:28:14 UTC Tests successful.

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 64 0 0 0 1

🟢 2026-11-17 17:28:18 UTC Build successful.
🟡 2026-11-17 17:28:45 UTC ydbd size 2.9 GiB changed* by +26.4 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7c1bcec merge: 889c475 diff diff %
ydbd size 3 045 473 272 Bytes 3 073 125 000 Bytes +26.4 MiB +0.908%
ydbd stripped size 643 672 192 Bytes 646 871 488 Bytes +3.1 MiB +0.497%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Comment on lines +537 to 541
if (!NKikimr::IsAdministrator(AppData(), userToken) &&
!(isNodeBootstrap && NKikimr::IsTokenAllowed(userToken, AppData()->RegisterDynamicNodeAllowedSIDs))) {
self->Reply(Ydb::StatusIds::UNAUTHORIZED, "User is not a cluster administrator.",
NKikimrIssues::TIssuesIds::ACCESS_DENIED, self->ActorContext());
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я бы разделил сообщения об ошибке для разных случаев. Register-node всё-таки не админ.

@mregrock
mregrock requested a review from a team as a code owner November 18, 2026 10:02
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

⚪ 2026-11-18 10:04:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 232ebf2 has started.
⚪ 2026-11-18 10:07:45 UTC Artifacts will be uploaded here
⚪ 2026-11-18 10:09:16 UTC ya make is running...
🟡 2026-11-18 12:11:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65691 63886 0 5 1793 7

⚪ 2026-11-18 12:11:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2026-11-18 12:13:09 UTC Tests successful.

Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
725 (only retried tests) 724 0 0 0 1

🟢 2026-11-18 12:13:13 UTC Build successful.
🟡 2026-11-18 12:13:37 UTC ydbd size 2.9 GiB changed* by +27.5 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7c1bcec merge: 232ebf2 diff diff %
ydbd size 3 045 473 272 Bytes 3 074 314 544 Bytes +27.5 MiB +0.947%
ydbd stripped size 643 672 192 Bytes 647 011 008 Bytes +3.2 MiB +0.519%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions

Copy link
Copy Markdown
Contributor

✅ Documentation build

Revision built successfully
Revision preview link

@mregrock
mregrock merged commit eb24e03 into ydb-platform:main Nov 18, 2026
14 of 15 checks passed
@ydbot

ydbot commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-26-3-1, stable-26-4-1 ▶  Backport
stable-26-4-1 ▶  Backport

▶  Backport manual

@ydbot

ydbot commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Backport results:

workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants