Skip to content

Fix macOS CMake build compatibility #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shfdis merged 2 commits into from
Jul 22, 2026
Merged

Fix macOS CMake build compatibility #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
065e04c
build: skip libc compatibility fallbacks on macOS
aral01 Jul 21, 2026
080b18d
build: respect the configured macOS deployment target
aral01 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions contrib/libs/libc_compat/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,18 @@ target_compile_options(contrib-libs-libc_compat PRIVATE

target_sources(contrib-libs-libc_compat PRIVATE
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/string.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/explicit_bzero.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/memfd_create.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/strlcat.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/strlcpy.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/reallocarray/reallocarray.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/random/getrandom.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/random/getentropy.c
)

if(NOT APPLE)
target_sources(contrib-libs-libc_compat PRIVATE
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/explicit_bzero.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/memfd_create.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/strlcat.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/strlcpy.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/reallocarray/reallocarray.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/random/getrandom.c
${YDB_SDK_SOURCE_DIR}/contrib/libs/libc_compat/random/getentropy.c
)
endif()

_ydb_sdk_install_targets(TARGETS contrib-libs-libc_compat)
3 changes: 1 addition & 2 deletions tools/enum_parser/enum_parser/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
)
elseif (CMAKE_SYSTEM_NAME STREQUAL "Darwin")
target_link_options(enum_parser PRIVATE
-Wl,-platform_version,macos,11.0,11.0
-framework
CoreFoundation
)
endif()
endif()
1 change: 0 additions & 1 deletion tools/rescompiler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
)
elseif (CMAKE_SYSTEM_NAME STREQUAL "Darwin")
target_link_options(rescompiler PRIVATE
-Wl,-platform_version,macos,11.0,11.0
-framework
CoreFoundation
)
Expand Down
Loading