Fix macOS CMake build compatibility#640
Merged
Merged
Conversation
Use the libc implementations provided by macOS instead of compiling bundled Linux-oriented replacements. Keep the existing compatibility sources unchanged for non-Apple platforms.
Remove hard-coded platform_version flags from SDK host tools. CMake and the selected toolchain now provide one consistent macOS deployment target without duplicate linker settings.
Shfdis
marked this pull request as ready for review
July 22, 2026 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The bundled compatibility implementations are intended for platforms that do not provide these libc functions. Compiling them on macOS causes conflicts with the platform libc.
The fixed
platform_versionlinker arguments can also disagree with the deployment target selected by CMake or the active toolchain. Removing them leaves deployment-target selection in one place.Non-Apple builds retain the existing compatibility sources and behavior.