Skip to content

[Blockstore] Update eternal fio test canon for 20% compression - #7612

Merged
Maximus5 merged 1 commit into
mainfrom
users/maximus5/fio-compress-canon
Oct 26, 2026
Merged

[Blockstore] Update eternal fio test canon for 20% compression#7612
Maximus5 merged 1 commit into
mainfrom
users/maximus5/fio-compress-canon

Conversation

@Maximus5

@Maximus5 Maximus5 commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Problem

The fio test generator now uses 20% compression.
Two eternal-test canon files still expect 90%.
This mismatch fails the setup and rerun tests.

Solution

Update the expected fio commands in both canon files to use 20%.

Testing

Four selected tests passed.

╰─>$ ./ya make -tA cloud/blockstore/tools/testing/eternal_tests/test_runner/tests \
           -F '*fio-eternal-alternating-seq-rw-1tb-nfs-4kib-4clients-cluster1*'
------- [TM] {debug, default-linux-x86_64} cloud/blockstore/tools/testing/eternal_tests/test_runner/tests/py3test >> test.py::test_
...
Total 1 suite:
        1 - GOOD
Total 4 tests:
        4 - GOOD
Ok

┬─[max-moisiuk@max-moisiuk-ivm:~/g/nbs-fastshard]─[11:16:03]─[.venv]─[users/maximus5/fio-compress-canon >]
╰─>$ gl -2
* ff4270a4bc Max Moisiuk 2026-10-26  (HEAD -> users/maximus5/fio-compress-canon, official/users/maximus5/fio-compress-canon)  [Blockstore] Update eternal fio test canon for 20% compression
* 47d2c73bff Maksim Moisiuk 2026-10-26  (official/main, official/HEAD, main)  [Blockstore] Skip EOF checks for eternal test canondata (#7614)

@Maximus5
Maximus5 added this pull request to stack #7613 October 23, 2026 17:22
@Maximus5
Maximus5 requested a review from antonmyagkov October 23, 2026 17:22
@github-actions

github-actions Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

@Maximus5
Maximus5 force-pushed the users/maximus5/fio-compress-canon branch from 2b419fa to 7bb4925 Compare October 23, 2026 17:30
@Maximus5 Maximus5 added the recheck Add this label to relaunch checks, it will be automatically removed label Oct 23, 2026
antonmyagkov
antonmyagkov previously approved these changes Oct 23, 2026
View reviewed changes
@github-actions github-actions Bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

@Maximus5
Maximus5 force-pushed the users/maximus5/fio-compress-canon branch from 7bb4925 to 041ea58 Compare October 23, 2026 17:53
@Maximus5
Maximus5 removed this pull request from stack #7613 October 23, 2026 17:53
@Maximus5
Maximus5 changed the base branch from main to users/maximus5/eternal-canon-precommit October 23, 2026 17:54
@Maximus5
Maximus5 added this pull request to stack #7615 October 23, 2026 17:54
@github-actions

github-actions Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/,cloud/fastshard/ (test time: 273s): all tests PASSED for commit 041ea58.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
1798 1798 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 320s): all tests PASSED for commit 041ea58.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
1849 1849 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1561s): all tests PASSED for commit 041ea58.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
7682 7681 0 0 0 1 0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5286s): all tests PASSED for commit 041ea58.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
5068 5067 0 0 0 1 0

@Maximus5 Maximus5 mentioned this pull request Oct 23, 2026
Merged
Base automatically changed from users/maximus5/eternal-canon-precommit to main October 26, 2026 09:59
Maximus5 added a commit that referenced this pull request Oct 26, 2026
@Maximus5
[Blockstore] Skip EOF checks for eternal test canondata (#7614)
47d2c73 
### Notes
Failures of two tests
`rerun-fio-eternal-alternating-seq-rw-1tb-nfs-4kib-4clients-cluster1` &
`setup-fio-eternal-alternating-seq-rw-1tb-nfs-4kib-4clients-cluster1`
already exist on `main` branch.

Fix for these tests is in #7612. But to merge generated `canondata`
files we first need this PR to exclude test txt files from
`end-of-file-fixer` pre-commit linter.

The tests compare generated output with canondata, including the final
newline.

### Testing

```bash
python3 -c 'import yaml; yaml.safe_load(open(".pre-commit-config.yaml"))'
```

---

<sub>Stack created with <a
href="https://github.com/github/gh-stack">GitHub Stacks CLI</a> • <a
href="https://gh.io/stacks-feedback">Give Feedback 💬</a></sub>
@Maximus5
Maximus5 force-pushed the users/maximus5/fio-compress-canon branch from 041ea58 to c1881d7 Compare October 26, 2026 09:59
@github-actions

github-actions Bot commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

@Maximus5
[Blockstore] Update eternal fio test canon for 20% compression
ff4270a 
Problem:
The fio test generator now uses 20% compression.
Two eternal-test canon files still expect 90%.
This mismatch fails the setup and rerun tests.

Solution:
Update the expected fio commands in both canon files to use 20%.

Testing:
Four selected tests passed.

```bash
./ya make -tA \
    cloud/blockstore/tools/testing/eternal_tests/test_runner/tests \
    -F '*fio-eternal-alternating-seq-rw-1tb-nfs-4kib-4clients-cluster1*'
```
@Maximus5
Maximus5 force-pushed the users/maximus5/fio-compress-canon branch from c1881d7 to ff4270a Compare October 26, 2026 10:08
@Maximus5 Maximus5 added recheck Add this label to relaunch checks, it will be automatically removed blockstore Add this label to run only cloud/blockstore build and tests on PR and removed recheck Add this label to relaunch checks, it will be automatically removed labels Oct 26, 2026
@github-actions

github-actions Bot commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is an automated comment that will be appended during run.

Note

All workloads for linux-x86_64-relwithdebinfo have completed.

Tip

Planned checks for linux-x86_64-relwithdebinfo.

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1464s): all tests PASSED for commit ff4270a.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
7682 7681 0 0 0 1 0

@Maximus5
Maximus5 merged commit ba110aa into main Oct 26, 2026
19 of 22 checks passed
@Maximus5
Maximus5 deleted the users/maximus5/fio-compress-canon branch October 26, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonmyagkov antonmyagkov antonmyagkov approved these changes
@arigachnyy arigachnyy arigachnyy approved these changes

Assignees

No one assigned

Labels

blockstore Add this label to run only cloud/blockstore build and tests on PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Maximus5 @antonmyagkov @arigachnyy