Repository navigation
[Blockstore] Skip EOF checks for eternal test canondata - #7614
Conversation
Problem:
The end-of-file-fixer hook changes generated canondata files.
Their tests compare file contents byte for byte.
Solution:
Exclude eternal test runner canondata from end-of-file-fixer.
Testing:
YAML parsing and the staged diff check passed.
```bash
python3 -c 'import yaml; yaml.safe_load(open(".pre-commit-config.yaml"))'
```
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/,cloud/fastshard/ (test time: 280s): all tests PASSED for commit 34a8144.
🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 318s): all tests PASSED for commit 34a8144.
🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1503s): some tests FAILED for commit 34a8144.
🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 26s): some tests FAILED for commit 34a8144.
🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 14s): some tests FAILED for commit 34a8144.
🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5353s): all tests PASSED for commit 34a8144.
|
Notes
Failures of two tests
rerun-fio-eternal-alternating-seq-rw-1tb-nfs-4kib-4clients-cluster1&setup-fio-eternal-alternating-seq-rw-1tb-nfs-4kib-4clients-cluster1already exist onmainbranch.Fix for these tests is in #7612. But to merge generated
canondatafiles we first need this PR to exclude test txt files fromend-of-file-fixerpre-commit linter.The tests compare generated output with canondata, including the final newline.
Testing
python3 -c 'import yaml; yaml.safe_load(open(".pre-commit-config.yaml"))'Stack created with GitHub Stacks CLI • Give Feedback 💬