Skip to content

fix(ios): resolve Xcode compiler warnings #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ngocdevv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ios): resolve Xcode compiler warnings #1039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ios/RNPDFPdf/RNPDFPdfView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ - (void)handleCommand:(const NSString *)commandName args:(const NSArray *)args

- (void)setNativePage:(NSInteger)page
{
_page = page;
_page = static_cast<int>(page);
[self didSetProps:[NSArray arrayWithObject:@"page"]];
}

Expand Down Expand Up @@ -762,7 +762,7 @@ - (void)handleDoubleTapEmpty:(UITapGestureRecognizer *)recognizer {}
* Tap
* zoom reset or zoom in
*
* @param recognizer
* @param recognizer The double-tap gesture recognizer.
*/
- (void)handleDoubleTap:(UITapGestureRecognizer *)recognizer
{
Expand Down Expand Up @@ -835,7 +835,7 @@ - (void)handleDoubleTap:(UITapGestureRecognizer *)recognizer
* Single Tap
* stop zoom
*
* @param recognizer
* @param sender The single-tap gesture recognizer.
*/
- (void)handleSingleTap:(UITapGestureRecognizer *)sender
{
Expand All @@ -859,7 +859,7 @@ - (void)handleSingleTap:(UITapGestureRecognizer *)sender
* Pinch
*
*
* @param recognizer
* @param sender The pinch gesture recognizer.
*/
-(void)handlePinch:(UIPinchGestureRecognizer *)sender{
[self onScaleChanged:Nil];
Expand Down