fix(ios): resolve Xcode compiler warnings - #1039
Open
ngocdevv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@paramdocumentation.senderparameters.NSIntegerpage argument to the component'sintstorage type.Problem
Xcode reports documentation warnings for empty or mismatched
@paramentries, plus an implicit 64-bit-to-32-bit conversion warning insetNativePage:.Fix
The comments now document the correct parameters, and the page assignment uses an explicit
static_cast<int>. The Fabric command is declared asInt32, so the conversion matches the command's existing type contract while making the native boundary explicit.Testing
Compiled
RNPDFPdfView.mmwith Apple Clang from Xcode 26.6 using the CocoaPods-generated response file, React Native Fabric headers, iOS Simulator 26.5 SDK, and the target's warning settings (including documentation and 64-to-32-bit conversion warnings). The compile completed with no diagnostics.Closes #1023.