Repository navigation
fix: v0.9.0 freezes the console after a while at the menu; 0.9.1 - #81
Merged
Merged
Conversation
- v0.9.0 opened both services in componentsInit() and held them until exit. On a 2DS the whole console then froze after a while at the menu, HOME included, with no crash dump; the build before #80 did not. The system needs those sessions itself (dimming the screens after a while without input, among other things). - ptm:u is now opened by watchLid() for the unattended pass of a review-first sync only, and gsp::Lcd by setBacklights() for each call. The lid behaviour during that pass is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- v0.9.0 freezes the console after a while at the menu; 0.9.1 carries the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
v0.9.0 freezes the whole console after the app has sat at the menu for a while: no input is taken any more, HOME included. Seen on a 2DS, once after a sync and once after pressing START while a run was connecting. Luma recorded no crash dump, so it is a hang rather than a crash. The build before #80 does not freeze.
Cause
#80 opened two system services in
componentsInit()and held them until the app quit:ptm:u, to read the lid, andgsp::Lcd, to switch the backlights while the lid is closed during a review-first sync. The system usesgsp::Lcditself, among other things to dim the screens after a while without input. With the app holding a session, the system blocks.Fix
ptm:uis opened bywatchLid()when the unattended pass of a review-first sync starts, and closed when it ends.gsp::Lcdis opened bysetBacklights()for each backlight call and closed at once.APP_VERSIONis now 0.9.1. Tag the merge commitv0.9.1to release.Testing
makebuilds clean, andmake -C testspasses (322 tests).🤖 Generated with Claude Code