Skip to content

fix(provider-runtime): import bundled Node builtins through ESM #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onmax wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(provider-runtime): import bundled Node builtins through ESM #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/provider-runtime/src/package-artifact.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function publishedManifest(

describe("provider-runtime package artifact", () => {
it(
"installs and starts a Codex-only consumer without the Claude SDK",
"starts a Codex-only consumer with ESM Node builtins and no Claude SDK",
{ timeout: 120_000 },
async () => {
const temporaryDirectory = await NodeFSP.mkdtemp(
Expand Down Expand Up @@ -139,7 +139,14 @@ describe("provider-runtime package artifact", () => {
await NodeFSP.writeFile(
NodePath.join(consumerDirectory, "verify.mjs"),
[
'import { createProviderRuntime } from "@t3tools/provider-runtime";',
'import { registerHooks } from "node:module";',
"registerHooks({ resolve(specifier, context, nextResolve) {",
' if (context.conditions.includes("require") && /^(node:)?(process|buffer)$/.test(specifier)) {',
' throw new Error(`No such module "${specifier}"`);',
" }",
" return nextResolve(specifier, context);",
"} });",
'const { createProviderRuntime } = await import("@t3tools/provider-runtime");',
'const runtime = await createProviderRuntime({ provider: "codex" });',
"await runtime.close();",
].join("\n"),
Expand Down
4 changes: 3 additions & 1 deletion packages/provider-runtime/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { defineConfig } from "vite-plus";
import { defineConfig, esmExternalRequirePlugin } from "vite-plus";

export default defineConfig({
pack: {
entry: ["src/index.ts"],
outDir: "dist",
// Workers accept these Node builtins through ESM, but not createRequire.
plugins: [esmExternalRequirePlugin({ external: [/^(node:)?(?:process|buffer)$/] })],
deps: {
// Publish the Node adapters built against our locked Effect version. Their
// transitive prerelease ranges can otherwise install incompatible adapters.
Expand Down
Loading