Skip to content

fix(provider-runtime): import bundled Node builtins through ESM - #5

Open
onmax wants to merge 1 commit into
mainfrom
fix/provider-runtime-esm-builtins
Open

onmax wants to merge 1 commit into
mainfrom
fix/provider-runtime-esm-builtins

Conversation

@onmax

@onmax onmax commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Problem

The packed provider-runtime artifact generated createRequire calls for process and buffer. Workers startup failed because those builtins are available through the ESM runtime.

Change

Configure the existing Vite+ externalization plugin for both builtins. Extend the packed-artifact regression to reject imports that select the require condition.

 Packed provider-runtime artifact
-  createRequire("process") / createRequire("buffer")
+  ESM imports for process and buffer

Scope and approval

This fixes builtin import generation in the existing provider-runtime artifact. It adds no provider or runtime setting.

Verification

The packed-artifact regression fails before the fix and passes afterward. No live Workers startup check is recorded in the existing PR description.

Model: GPT-6.1-Sol (xhigh)
Harness: T3 Code Codex

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T00:42:04.561714Z c8c26c4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vitehub-bot

vitehub-bot Bot commented Oct 3, 2026

Copy link
Copy Markdown

Waiting to start.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Oct 3, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for c8c26c4.

This comment will update automatically after the next completed run.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant