Repository navigation
fix(vjsc): pin one tailwind and lightningcss for the workspace - #2971
Conversation
VJSC compiled CSS output with Tailwind 4.2.1 while the sandbox, site, and skins compiled Tailwind output with 4.3.x, so the two styling modes could disagree. The pnpm catalog now pins @tailwindcss/node, @tailwindcss/vite, tailwindcss, and lightningcss once, at exact versions, because VJSC relies on Tailwind's unstable design-system APIs. Tailwind 4.3 hoists variant rules out of an @apply rule that has no declaration of its own, and flattens variants onto a candidate class that sets none. Each semantic rule now starts with a sentinel declaration that keeps its variants nested and is dropped from the output, and compiled candidate diagnostics accept selectors anchored on the candidate class.
✅ Deploy Preview for vjs-registry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@videojs/cdn
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
📦 Bundle Size Report🎨 @videojs/html — 29 small size changes
Presets (7)
Media (18)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — 7 small size changes
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — 1 small size change
Entries (4)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
SummaryClassification: inconclusive. The Registry consumers job aborted before Playwright could run its browser assertions: linting the generated Failed run
Evidence
Likely causeVerified: this is a native/tooling crash in the generated default Next/Tailwind consumer's lint command, before any product assertion or visual snapshot ran. Inference: the dependency pin or generated default-theme source may expose an ESLint/Next/Tailwind toolchain defect, but this run does not establish a product regression or a stale expected result. The passing minimal Tailwind consumer makes a broad Tailwind setup failure less likely. Recommended actions
|
Summary
VJSC compiled CSS output with Tailwind 4.2.1, while the sandbox, site, and skins compiled Tailwind output with 4.3.x, so the two styling modes could disagree. This pins Tailwind and lightningcss once through the pnpm catalog and adapts VJSC to Tailwind 4.3.
First of three stacked PRs: this → #2970 → #2972.
Changes
@tailwindcss/node,@tailwindcss/vite,tailwindcss, andlightningcssfor the whole workspace. The versions are exact because VJSC relies on Tailwind's unstable design-system APIs.@applyrule that has no declaration of its own. Each semantic rule now starts with a sentinel declaration that keeps its variants nested, and the sentinel is removed from the output..candidate[data-open]) of a candidate that sets no declarations. Compiled-candidate diagnostics now accept any selector that contains the candidate class, instead of reporting a scope escape.The only output change is that Tailwind 4.3 simplifies
calc(var(--media-spacing) * 1)tovar(--media-spacing): 264 lines in each package's skin stylesheets and 400 in the registry.Testing
pnpm install --frozen-lockfileandpnpm build:packageson this branch alone@videojs/skins(67),@videojs/html(477),@videojs/react(598),@videojs/icons(12)pnpm typecheckandpnpm lintmain: only thecalc()simplification above🤖 Generated with Claude Code
Note
Medium Risk
Unifies the CSS compiler across packages and changes VJSC semantic rule emission and scope diagnostics, which can affect generated skin output and error reporting for edge-case selectors.
Overview
Pins Tailwind 4.3.3 and lightningcss 1.32.0 for the whole monorepo via the pnpm catalog, so VJSC (previously on 4.2.1) compiles CSS with the same engine as sandbox, skins, and site. Package manifests switch those deps to
catalog:and the lockfile drops older Tailwind oxide/node versions.VJSC is updated for Tailwind 4.3 behavior: each semantic
@applyrule gets a temporary--vjsc-rootdeclaration so variant output stays nested under the semantic class (then the sentinel is stripped from emitted CSS). Compiled-candidate diagnostics no longer require a bare.candidateroot rule—flattened selectors like.candidate[data-open]count as in-scope—and scope-escape errors fire only when a selector is not anchored to the candidate. A new test covers the flattened-variant case.Expected generated skin CSS churn is mostly Tailwind simplifying
calc(var(--media-spacing) * 1)tovar(--media-spacing).Reviewed by Cursor Bugbot for commit 2655933. Bugbot is set up for automated code reviews on this repo. Configure here.