Repository navigation
Conversation
✅ Deploy Preview for vjs-registry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary
Failed runRun 36056624221 · head Evidence
Likely causeVerified: at task-graph/config-load time in a fresh CI checkout, the exported VJSC Recommended actions
|
6178208 to
f012160
Compare
SummaryClassification: real regression. The E2E workflow cannot construct its task graph, so no Playwright tests run. Failed run
Evidence
Likely causeVerified: Vite+ loads Core’s config to build the task graph before the VJSC build can provide its generated Inference: The build-boundary refactor introduced a bootstrap-cycle regression for fresh CI checkouts. Recommended actions
|
@videojs/cdn
@videojs/cli
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
@videojs/cloudflare-video
@videojs/dash-video
@videojs/hlsjs-video
@videojs/mux-audio
@videojs/mux-video
@videojs/native-hls-video
@videojs/shaka-video
@videojs/spotify-audio
@videojs/tiktok-video
@videojs/twitch-video
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
@videojs/google-cast
@videojs/mux-data
commit: |
📦 Bundle Size Report🎨 @videojs/html — 52 small size changes
Presets (7)
Media (18)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — 29 small size changes
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — 2 small size changes
Entries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — 1 small size change
Entries (3)
📦 @videojs/mux — 1 small size change
📦 @videojs/mux-audio — 1 small size change
Entries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — 1 small size change
Entries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — 1 small size change
Entries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — 1 small size change
Entries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
8ecd83a to
6beff4c
Compare
kebabCase keeps the leading dash a vendor-prefixed CSS property needs. kebabCaseName converts identifiers such as PlayButton to play-button, which the HTML element tables use for public names.
Lower targets in three stages (source, lower, finalize) that share one bindings index and one set of imports. Split the style plugin into candidate, reference, virtual CSS, and file-cache modules. Move the HTML, React, and icon target tables into their own packages. Build skins on typed variant, metadata, graph, and registry APIs, with generated outputs and the source layout each declared once. Correctness fixes: checkout-independent scope ids and graph module order, style isolation errors in every build, errors for unconsumed parts and $render markers, a declared cascade order, bundle dedupe within parents, template siblings and nested templates, namespaced build metadata that keeps other plugins' data, contained and conditional CSS imports, and normalized generated-file ownership. Performance: a per-file render cache, one compile per theme for reusable React components, per-piece bundle analysis, and memoized style utilities take skins generate from about 5.0 s to 2.2 s wall.
Task configs load before any package builds, so in a fresh checkout vjsc has no dist and importing the plugin through `vjsc/plugins` fails to load the task graph. Core's config imports the plugin's source again, and the modules that source loads use inline type checks instead of `@videojs/utils`, which is not built yet either.
The cascade-order check treated every array and call argument holding two style references as a composition, and every shared property as a conflict. Alternatives passed to a chooser or kept in an array never meet on one element, and rules for exclusive attribute states, such as `[data-state="open"]` and `[data-state="closed"]`, or `[data-pip]` and `:not([data-pip])`, never apply together, yet both failed builds that compiled before the check existed. Only the arrays a `className` or `class` attribute composes count now, including nested and spread arrays and each branch of a conditional value, and declarations under exclusive attribute states of one element do not compete.
6beff4c to
fa7d829
Compare
Summary
Restructures VJSC, the compiler behind the skins, and the skins build after a review, and fixes the correctness issues the review found. Skins generate drops from about 5.0 s to 2.2 s wall (build step 4.4 s → 1.8 s), and the generated output no longer depends on the checkout path.
Second of three stacked PRs: #2971 (merged) → this → #2972.
Changes
vjsc:target-source,vjsc:target-lower, andvjsc:target-finalizereplace ten separate passes. They share one bindings index and one set of imports, and rule errors report source positions.path:line:columnand run once per style set.packages/html/vjsc,packages/react/vjsc, andpackages/icons/vjsc.kebabCaseNamein@videojs/utils(its own commit) converts component names to element names.$rendermarkers, are now errors.classNameorclassattribute composes count, including nested, spread, and conditional ones. Rules for exclusive attribute states, such as[data-state="open"]and[data-state="closed"], never conflict.meta.vjsc, so other plugins' resolver metadata survives.url()imports,layer()/supports()/media conditions, and commented-out imports are handled.@videojs/coreno longer packsdist/*/vjsc.*ordist/*/core/ui/*/component.*(144 files). Its published exports never reach them, and they import the privatevjsc.Intentional output changes
:where(.media-skin)shadow-host copies. React never renders those elements as shadow hosts, and HTML CSS is unchanged.:scoperules outside@scopeare gone.@supports {}/@media {}blocks left behind by deduplication are removed.Implementation details
VariantCodec.inherit()lets a relative import compile for a narrower variant than its importer. Skins uses it to compile reusable React components withoutskin.resolveIdandloadhooks now declare id filters. The handlers still check ids themselves, so Vite versions that ignore filters behave the same.vjscPlugintype parameters are now<Node, Variant>.readLocalCssImports(filename, root)now requiresroot.placeis now a method signature.Testing
pnpm install --frozen-lockfileandpnpm build:packages@videojs/skins(93),@videojs/html(482),@videojs/react(600),@videojs/core(1577),@videojs/icons(12),@videojs/utils(503),@videojs/installation(308), and the sitepnpm typecheck,pnpm lint,pnpm check:workspace, andpnpm test:shadcnflattenScopes, fix(vjsc): serialize HTML void elements without closing tags #2976 void elements, vite+ 1.0), generated output equals main's plus this PR's intended changes. 536 of 562 files are byte-identical to that. The rest match declaration for declaration once scope ids, empty blocks, and the root-relative block order are accounted for.mainthen too; it passes when the machine is quiet.🤖 Generated with Claude Code