Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

refactor(packages): restructure vjsc and the skins build - #2970

Closed
mihar-22 wants to merge 4 commits into
mainfrom
refactor/vjsc-build-boundary
Closed

mihar-22 wants to merge 4 commits into
mainfrom
refactor/vjsc-build-boundary

Conversation

@mihar-22

@mihar-22 mihar-22 commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Summary

Restructures VJSC, the compiler behind the skins, and the skins build after a review, and fixes the correctness issues the review found. Skins generate drops from about 5.0 s to 2.2 s wall (build step 4.4 s → 1.8 s), and the generated output no longer depends on the checkout path.

Second of three stacked PRs: #2971 (merged) → this → #2972.

Changes

  • Target lowering in three stages. vjsc:target-source, vjsc:target-lower, and vjsc:target-finalize replace ten separate passes. They share one bindings index and one set of imports, and rule errors report source positions.
  • Style pipeline split up. The style plugin is now separate candidate, reference, virtual-CSS, and file-cache modules. Diagnostics report path:line:column and run once per style set.
  • Target tables live with their packages: packages/html/vjsc, packages/react/vjsc, and packages/icons/vjsc. kebabCaseName in @videojs/utils (its own commit) converts component names to element names.
  • Skins build on typed VJSC APIs.
    • One compiler-options object is shared by the build and the Vite preset.
    • Variants and metadata keep their types through the graph and the registry.
    • Generated outputs and the skin source layout are each declared once.
    • Registry items no longer repeat their catalog's metadata.
  • Correctness fixes.
    • Scope IDs and the graph's module order no longer depend on the checkout path.
    • Style isolation errors fail every build, not only the dev server.
    • Parts no target lowered, and unconsumed $render markers, are now errors.
    • The CSS cascade order is declared once, and a composition that contradicts it fails the build. Only the arrays a className or class attribute composes count, including nested, spread, and conditional ones. Rules for exclusive attribute states, such as [data-state="open"] and [data-state="closed"], never conflict.
    • Bundle deduplication compares rules within their parent rules.
    • Templates beside other templates now lower; templates nested inside templates are errors.
    • VJSC's build data lives under meta.vjsc, so other plugins' resolver metadata survives.
    • Theme CSS imports must stay inside the graph root, and url() imports, layer()/supports()/media conditions, and commented-out imports are handled.
    • Generated-file ownership is checked on normalized paths.
  • Packaging. @videojs/core no longer packs dist/*/vjsc.* or dist/*/core/ui/*/component.* (144 files). Its published exports never reach them, and they import the private vjsc.
  • Performance.
    • Rendered CSS is cached per file.
    • Reusable React components compile once per theme instead of once per skin.
    • CSS bundling analyzes each stylesheet once, through a single lightningcss callback.
    • Per-rule style utilities and compiled diagnostics are memoized.

Intentional output changes

  • React CSS no longer carries the WebKit :where(.media-skin) shadow-host copies. React never renders those elements as shadow hosts, and HTML CSS is unchanged.
  • Dead :scope rules outside @scope are gone.
  • CSS blocks that style unrelated classes follow a fixed, root-relative module order. Some blocks move in the React CSS registry style files as a result.
  • Empty @supports {}/@media {} blocks left behind by deduplication are removed.
  • One registry docs line now reads "Video.js components" instead of "Video.js menu components".
Implementation details
  • VariantCodec.inherit() lets a relative import compile for a narrower variant than its importer. Skins uses it to compile reusable React components without skin.
  • resolveId and load hooks now declare id filters. The handlers still check ids themselves, so Vite versions that ignore filters behave the same.
  • Rolldown's module order varies with the absolute checkout path, so the graph now orders modules by their root-relative identity. Building this branch in two checkouts produces byte-identical output.
  • Two ideas were measured and dropped:
    • Skipping any lightningcss print→parse pass changes output, because the re-parse merges shorthands and splits selector lists.
    • Sharing module ASTs across plugins would have avoided only 7% of parses.
  • API changes (none published outside the repo; vjsc is private):
    • The Vite vjscPlugin type parameters are now <Node, Variant>.
    • readLocalCssImports(filename, root) now requires root.
    • Registry item place is now a method signature.

Testing

  • Built alone in a fresh checkout of this branch: pnpm install --frozen-lockfile and pnpm build:packages
  • Tests: vjsc (288), @videojs/skins (93), @videojs/html (482), @videojs/react (600), @videojs/core (1577), @videojs/icons (12), @videojs/utils (503), @videojs/installation (308), and the site
  • pnpm typecheck, pnpm lint, pnpm check:workspace, and pnpm test:shadcn
  • Generated skins output diffed against the previous output after every change, and compared across two checkouts
  • After rebasing onto main (feat(vjsc): flatten @scope in the packaged skins #2966 flattenScopes, fix(vjsc): serialize HTML void elements without closing tags #2976 void elements, vite+ 1.0), generated output equals main's plus this PR's intended changes. 536 of 562 files are byte-identical to that. The rest match declaration for declaration once scope ids, empty blocks, and the root-relative block order are accounted for.
  • Vite dev server: HTML and React skin roots, and a React component imported by a skin, transform cleanly
  • Not run: the Playwright E2E suites. The HTML i18n lazy-overlay test is timing-sensitive under heavy machine load and fails on main then too; it passes when the machine is quiet.

🤖 Generated with Claude Code

@netlify

netlify Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs-registry ready!

Name Link
🔨 Latest commit fa7d829
🔍 Latest deploy log https://app.netlify.com/projects/vjs-registry/deploys/6abc33417730ce000872112c
😎 Deploy Preview https://deploy-preview-2970--vjs-registry.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v10-sandbox Ready Ready Preview Sep 29, 2026 9:54pm UTC

Request Review

@netlify

netlify Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vjs10-site ready!

Name Link
🔨 Latest commit fa7d829
🔍 Latest deploy log https://app.netlify.com/projects/vjs10-site/deploys/6abc334117af900008cbe3fa
😎 Deploy Preview https://deploy-preview-2970--vjs10-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown
Contributor

Summary

real regression — the workflow stops before Playwright because Core’s Vite config cannot load vjsc/plugins from a clean install.

Failed run

Run 36056624221 · head 6178208a87fa9918bffec2921bfa1d74aefc91b7 · affected: @videojs/e2e#test:registry and the browser-suite build. Browser E2E, sandbox, and skin-parity tests were skipped.

Evidence

  • Both failed jobs report ERR_MODULE_NOT_FOUND for packages/core/node_modules/vjsc/dist/plugins/index.js while loading packages/core/vite.config.ts.
  • The run has no Playwright artifacts/traces because no Playwright job started.
  • This PR changes that config from a direct VJSC source import to import { vjscComponentSchemaPlugin } from "vjsc/plugins"; the vjsc package export resolves that specifier to dist/plugins/index.js.

Likely cause

Verified: at task-graph/config-load time in a fresh CI checkout, the exported VJSC dist/plugins/index.js has not been built. Inference: Vite+ must load Core’s config before its workspace build dependency can produce that file, so the new package-boundary import is unavailable too early.

Recommended actions

  • Make the schema plugin available during task-config discovery (for example, avoid a dist-dependent import there or bootstrap VJSC before config loading).
  • Reproduce from a clean install with pnpm build:packages; after that succeeds, rerun the registry and browser suites.

@github-actions

Copy link
Copy Markdown
Contributor

Summary

Classification: real regression. The E2E workflow cannot construct its task graph, so no Playwright tests run.

Failed run

Evidence

  • Both failed prerequisite jobs fail while loading packages/core/vite.config.ts: ERR_MODULE_NOT_FOUND for packages/core/node_modules/vjsc/dist/plugins/index.js after resolving vjsc/plugins.
  • The run produced no artifacts; no Playwright report or trace exists because browser jobs never started.
  • This PR changes Core’s config from a source import (../vjsc/src/plugins/component-schema.ts) to vjsc/plugins. VJSC’s ./plugins export targets ./dist/plugins/index.js.

Likely cause

Verified: Vite+ loads Core’s config to build the task graph before the VJSC build can provide its generated dist/plugins/index.js; the missing file aborts graph construction. workspaceTaskDependencies() does declare workspace dependencies, but graph construction does not reach scheduling.

Inference: The build-boundary refactor introduced a bootstrap-cycle regression for fresh CI checkouts.

Recommended actions

  • Make the config-time plugin import resolvable before task-graph construction (for example, retain an appropriate source-level config import or provide a bootstrap-safe resolution path).
  • Validate from a clean checkout with pnpm exec vp run '@videojs/e2e#test:registry' and pnpm build:packages; then rerun the workflow to reach the skipped browser suites.

@mihar-22
mihar-22 added this pull request to stack #2973 September 24, 2026 21:18
@pkg-pr-new

pkg-pr-new Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
@videojs/cdn

pnpm add https://pkg.pr.new/@videojs/cdn@2970

@videojs/cli

pnpm add https://pkg.pr.new/@videojs/cli@2970

@videojs/core

pnpm add https://pkg.pr.new/@videojs/core@2970

@videojs/element

pnpm add https://pkg.pr.new/@videojs/element@2970

@videojs/html

pnpm add https://pkg.pr.new/@videojs/html@2970

@videojs/media

pnpm add https://pkg.pr.new/@videojs/media@2970

@videojs/react

pnpm add https://pkg.pr.new/@videojs/react@2970

@videojs/spf

pnpm add https://pkg.pr.new/@videojs/spf@2970

@videojs/store

pnpm add https://pkg.pr.new/@videojs/store@2970

@videojs/utils

pnpm add https://pkg.pr.new/@videojs/utils@2970

@videojs/cloudflare-video

pnpm add https://pkg.pr.new/@videojs/cloudflare-video@2970

@videojs/dash-video

pnpm add https://pkg.pr.new/@videojs/dash-video@2970

@videojs/hlsjs-video

pnpm add https://pkg.pr.new/@videojs/hlsjs-video@2970

@videojs/mux-audio

pnpm add https://pkg.pr.new/@videojs/mux-audio@2970

@videojs/mux-video

pnpm add https://pkg.pr.new/@videojs/mux-video@2970

@videojs/native-hls-video

pnpm add https://pkg.pr.new/@videojs/native-hls-video@2970

@videojs/shaka-video

pnpm add https://pkg.pr.new/@videojs/shaka-video@2970

@videojs/spotify-audio

pnpm add https://pkg.pr.new/@videojs/spotify-audio@2970

@videojs/tiktok-video

pnpm add https://pkg.pr.new/@videojs/tiktok-video@2970

@videojs/twitch-video

pnpm add https://pkg.pr.new/@videojs/twitch-video@2970

@videojs/vimeo-video

pnpm add https://pkg.pr.new/@videojs/vimeo-video@2970

@videojs/wistia-video

pnpm add https://pkg.pr.new/@videojs/wistia-video@2970

@videojs/youtube-video

pnpm add https://pkg.pr.new/@videojs/youtube-video@2970

@videojs/google-cast

pnpm add https://pkg.pr.new/@videojs/google-cast@2970

@videojs/mux-data

pnpm add https://pkg.pr.new/@videojs/mux-data@2970

commit: fa7d829

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html — 52 small size changes
Path Base initial PR initial Initial diff Lazy diff
/video/minimal-skin.css 8.29 kB 8.26 kB -22 B (-0.3%) —
/video/skin.css 8.00 kB 7.97 kB -33 B (-0.4%) —
/video/minimal-skin 63.27 kB 63.18 kB -96 B (-0.1%) 0 B
/video/minimal-skin2 8.27 kB 8.26 kB -5 B (-0.1%) —
/video/player 9.97 kB 9.97 kB +1 B (+0.0%) 0 B
/video/skin 62.74 kB 62.81 kB +67 B (+0.1%) 0 B
/video/skin2 7.99 kB 7.95 kB -33 B (-0.4%) —
/audio/minimal-skin.css 6.07 kB 6.07 kB +2 B (+0.0%) —
/audio/skin.css 5.80 kB 5.80 kB +1 B (+0.0%) —
/audio/minimal-skin 47.00 kB 47.04 kB +47 B (+0.1%) 0 B
/audio/minimal-skin2 6.05 kB 6.06 kB +2 B (+0.0%) —
/audio/skin 46.73 kB 46.74 kB +10 B (+0.0%) 0 B
/background/player 4.46 kB 4.46 kB -1 B (-0.0%) 0 B
/live-video/minimal-skin.css 6.77 kB 6.75 kB -24 B (-0.3%) —
/live-video/skin.css 6.69 kB 6.65 kB -34 B (-0.5%) —
/live-video/minimal-skin 50.79 kB 50.75 kB -37 B (-0.1%) 0 B
/live-video/minimal-skin2 6.77 kB 6.76 kB -11 B (-0.2%) —
/live-video/player 9.33 kB 9.33 kB -6 B (-0.1%) 0 B
/live-video/skin 50.75 kB 50.66 kB -98 B (-0.2%) 0 B
/live-video/skin2 6.67 kB 6.64 kB -32 B (-0.5%) —
/live-audio/minimal-skin.css 4.77 kB 4.77 kB +5 B (+0.1%) —
/live-audio/skin.css 4.67 kB 4.68 kB +8 B (+0.2%) —
/live-audio/minimal-skin 36.17 kB 36.18 kB +12 B (+0.0%) 0 B
/live-audio/minimal-skin2 4.77 kB 4.77 kB +1 B (+0.0%) —
/live-audio/player 6.16 kB 6.16 kB +5 B (+0.1%) 0 B
/live-audio/skin 36.14 kB 36.11 kB -36 B (-0.1%) 0 B
/live-audio/skin2 4.66 kB 4.67 kB +16 B (+0.3%) —
/ui/alert-dialog 8.98 kB 8.97 kB -2 B (-0.0%) 0 B
/ui/dialog 8.92 kB 8.92 kB -1 B (-0.0%) 0 B
/ui/menu 19.17 kB 19.17 kB -4 B (-0.0%) 0 B
/ui/popover 8.76 kB 8.77 kB +5 B (+0.1%) 0 B
/ui/tooltip 10.13 kB 10.13 kB +4 B (+0.0%) 0 B
/media/mux-video 3.03 kB 3.02 kB -11 B (-0.4%) —
/media/mux-audio 2.68 kB 2.69 kB +6 B (+0.2%) —
/media/cloudflare-video 2.90 kB 2.91 kB +5 B (+0.2%) —
/media/dash-video 2.63 kB 2.62 kB -2 B (-0.1%) —
/media/hls-audio 23.47 kB 23.41 kB -61 B (-0.3%) —
/media/hls-video 33.65 kB 33.63 kB -22 B (-0.1%) —
/media/native-hls-video 7.57 kB 7.57 kB -8 B (-0.1%) —
/media/shaka-video 2.63 kB 2.63 kB +1 B (+0.0%) —
/media/spotify-audio 3.02 kB 3.02 kB -2 B (-0.1%) —
/media/tiktok-video 3.12 kB 3.13 kB +1 B (+0.0%) —
/media/twitch-video 2.93 kB 2.93 kB -1 B (-0.0%) —
/media/vimeo-video 2.90 kB 2.90 kB +4 B (+0.1%) —
/media/youtube-video 2.90 kB 2.90 kB +1 B (+0.0%) —
/video (default) 64.31 kB 64.22 kB -98 B (-0.1%) 0 B
/video (default + hls) 66.15 kB 66.06 kB -86 B (-0.1%) 0 B
/video (minimal) 64.75 kB 64.76 kB +10 B (+0.0%) 0 B
/video (minimal + hls) 66.50 kB 66.45 kB -52 B (-0.1%) 0 B
/audio (default) 48.18 kB 48.26 kB +80 B (+0.2%) 0 B
/audio (minimal) 48.48 kB 48.50 kB +21 B (+0.0%) 0 B
/background 11.86 kB 11.86 kB +5 B (+0.0%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 64.22 kB 56.03 kB
/video (default + hls) 66.06 kB 56.03 kB
/video (minimal) 64.76 kB 56.03 kB
/video (minimal + hls) 66.45 kB 56.03 kB
/audio (default) 48.26 kB 56.03 kB
/audio (minimal) 48.50 kB 56.03 kB
/background 11.86 kB 56.03 kB
Media (18)
Entry Initial
/media/mux-video 3.02 kB
/media/mux-audio 2.69 kB
/media/background-video 1.16 kB
/media/cloudflare-video 2.91 kB
/media/dash-video 2.62 kB
/media/hls-audio 23.41 kB
/media/hls-background-video 17.44 kB
/media/hls-video 33.63 kB
/media/hlsjs-video 2.63 kB
/media/mux-background-video 17.42 kB
/media/native-hls-video 7.57 kB
/media/shaka-video 2.63 kB
/media/spotify-audio 3.02 kB
/media/tiktok-video 3.13 kB
/media/twitch-video 2.93 kB
/media/vimeo-video 2.90 kB
/media/wistia-video 607 B
/media/youtube-video 2.90 kB
Players (5)
Entry Initial Lazy
/video/player 9.97 kB 56.03 kB
/audio/player 6.14 kB 56.03 kB
/background/player 4.46 kB 56.03 kB
/live-video/player 9.33 kB 56.03 kB
/live-audio/player 6.16 kB 56.03 kB
Skins (29)
Entry Type Initial Lazy
/video/minimal-skin.css css 8.26 kB —
/video/skin.css css 7.97 kB —
/video/minimal-skin js 63.18 kB 56.03 kB
/video/minimal-skin2 js 8.26 kB —
/video/skin js 62.81 kB 56.03 kB
/video/skin2 js 7.95 kB —
/audio/minimal-skin.css css 6.07 kB —
/audio/skin.css css 5.80 kB —
/audio/minimal-skin js 47.04 kB 56.03 kB
/audio/minimal-skin2 js 6.06 kB —
/audio/skin js 46.74 kB 56.03 kB
/audio/skin2 js 5.78 kB —
/background/skin.css css 141 B —
/background/skin js 10.11 kB 56.03 kB
/background/skin2 js 159 B —
/live-video/minimal-skin.css css 6.75 kB —
/live-video/skin.css css 6.65 kB —
/live-video/minimal-skin js 50.75 kB 56.03 kB
/live-video/minimal-skin2 js 6.76 kB —
/live-video/skin js 50.66 kB 56.03 kB
/live-video/skin2 js 6.64 kB —
/live-audio/minimal-skin.css css 4.77 kB —
/live-audio/skin.css css 4.68 kB —
/live-audio/minimal-skin js 36.18 kB 56.03 kB
/live-audio/minimal-skin2 js 4.77 kB —
/live-audio/skin js 36.11 kB 56.03 kB
/live-audio/skin2 js 4.67 kB —
/global.css css 239 B —
/shadow.css css 78 B —
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 11.52 kB 56.03 kB
/ui/alert-dialog 8.97 kB 56.03 kB
/ui/audio-track-radio-group 11.61 kB 56.03 kB
/ui/buffering-indicator 8.84 kB 56.03 kB
/ui/captions-button 11.76 kB 56.03 kB
/ui/captions-radio-group 11.65 kB 56.03 kB
/ui/cast-button 11.51 kB 56.03 kB
/ui/container 9.71 kB 56.03 kB
/ui/controls 9.03 kB 56.03 kB
/ui/controls-backdrop 1.69 kB 56.03 kB
/ui/controls-content 1.67 kB 56.03 kB
/ui/dialog 8.92 kB 56.03 kB
/ui/dialog-backdrop 1.70 kB 56.03 kB
/ui/dialog-close 2.06 kB 56.03 kB
/ui/dialog-description 1.69 kB 56.03 kB
/ui/dialog-popup 1.90 kB 56.03 kB
/ui/dialog-title 1.70 kB 56.03 kB
/ui/error-dialog 12.62 kB 56.03 kB
/ui/fullscreen-button 11.50 kB 56.03 kB
/ui/gesture 9.96 kB 56.03 kB
/ui/hotkey 10.37 kB 56.03 kB
/ui/live-button 10.02 kB 56.03 kB
/ui/menu 19.17 kB 56.03 kB
/ui/menu-checkbox-item 1.97 kB 56.03 kB
/ui/menu-content 7.65 kB 56.03 kB
/ui/menu-group 2.09 kB 56.03 kB
/ui/menu-group-label 1.64 kB —
/ui/menu-item 2.30 kB 56.03 kB
/ui/menu-item-indicator 1.38 kB 56.03 kB
/ui/menu-radio-group 3.01 kB 56.03 kB
/ui/menu-radio-item 2.13 kB 56.03 kB
/ui/menu-separator 1.30 kB 56.03 kB
/ui/mute-button 11.52 kB 56.03 kB
/ui/pip-button 11.48 kB 56.03 kB
/ui/play-button 11.46 kB 56.03 kB
/ui/playback-rate-button 11.56 kB 56.03 kB
/ui/playback-rate-radio-group 11.61 kB 56.03 kB
/ui/popover 8.77 kB 56.03 kB
/ui/poster 9.15 kB 56.03 kB
/ui/quality-radio-group 12.11 kB 56.03 kB
/ui/seek-button 11.50 kB 56.03 kB
/ui/seek-indicator 12.95 kB 56.03 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 11.88 kB 56.03 kB
/ui/slider-preview 2.01 kB 56.03 kB
/ui/status-announcer 10.86 kB 56.03 kB
/ui/status-indicator 13.25 kB 56.03 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.58 kB 56.03 kB
/ui/time 11.29 kB 56.03 kB
/ui/time-slider 13.38 kB 56.03 kB
/ui/time-slider-chapter-title 9.04 kB 56.03 kB
/ui/time-slider-chapters 9.88 kB 56.03 kB
/ui/title 8.44 kB 56.03 kB
/ui/tooltip 10.13 kB 56.03 kB
/ui/tooltip-label 1.21 kB —
/ui/tooltip-shortcut 1.18 kB —
/ui/volume-indicator 13.26 kB 56.03 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 15.14 kB 56.03 kB
/ui/volume-slider 12.58 kB 56.03 kB
⚛️ @videojs/react — 29 small size changes
Path Base initial PR initial Initial diff Lazy diff
/media/hls-background-video 17.48 kB 17.46 kB -14 B (-0.1%) —
/media/mux-background-video 17.50 kB 17.46 kB -35 B (-0.2%) —
/video/minimal-skin.css 8.12 kB 8.09 kB -25 B (-0.3%) —
/video/skin.css 7.81 kB 7.78 kB -30 B (-0.4%) —
/video/minimal-skin 58.69 kB 58.75 kB +61 B (+0.1%) 0 B
/video/skin 58.64 kB 58.68 kB +43 B (+0.1%) 0 B
/audio/minimal-skin.css 5.88 kB 5.89 kB +7 B (+0.1%) —
/audio/skin.css 5.60 kB 5.60 kB +8 B (+0.1%) —
/audio/minimal-skin 45.55 kB 45.60 kB +57 B (+0.1%) 0 B
/audio/skin 45.54 kB 45.54 kB +4 B (+0.0%) 0 B
/live-video/minimal-skin.css 6.60 kB 6.60 kB -7 B (-0.1%) —
/live-video/skin.css 6.51 kB 6.49 kB -20 B (-0.3%) —
/live-video/minimal-skin 48.54 kB 48.58 kB +41 B (+0.1%) 0 B
/live-video/skin 48.63 kB 48.53 kB -105 B (-0.2%) 0 B
/live-audio/minimal-skin.css 4.58 kB 4.59 kB +9 B (+0.2%) —
/live-audio/skin.css 4.47 kB 4.49 kB +18 B (+0.4%) —
/live-audio/minimal-skin 33.79 kB 33.76 kB -29 B (-0.1%) 0 B
/live-audio/skin 33.79 kB 33.77 kB -18 B (-0.1%) 0 B
/ui/menu 22.05 kB 22.03 kB -24 B (-0.1%) 0 B
/ui/popover 9.12 kB 9.12 kB -5 B (-0.1%) 0 B
/ui/slider 14.34 kB 14.39 kB +55 B (+0.4%) 0 B
/ui/tooltip 9.98 kB 9.99 kB +15 B (+0.1%) 0 B
/ui/volume-popover 15.53 kB 15.53 kB +2 B (+0.0%) 0 B
/ui/volume-slider 12.96 kB 12.96 kB +1 B (+0.0%) 0 B
/video (default) 58.76 kB 58.73 kB -38 B (-0.1%) 0 B
/video (default + hls) 59.21 kB 59.21 kB +5 B (+0.0%) 0 B
/video (minimal) 58.88 kB 58.87 kB -11 B (-0.0%) 0 B
/video (minimal + hls) 59.33 kB 59.34 kB +8 B (+0.0%) 0 B
/audio (minimal) 45.68 kB 45.70 kB +18 B (+0.0%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 58.73 kB 56.03 kB
/video (default + hls) 59.21 kB 56.03 kB
/video (minimal) 58.87 kB 56.03 kB
/video (minimal + hls) 59.34 kB 56.03 kB
/audio (default) 45.69 kB 56.03 kB
/audio (minimal) 45.70 kB 56.03 kB
/background 908 B 56.03 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 1.45 kB
/media/mux-video/spf 1.46 kB
/media/mux-audio/hls-js 1.12 kB
/media/mux-audio/spf 1.13 kB
/media/background-video 513 B
/media/cloudflare-video 1.81 kB
/media/dash-video 1.11 kB
/media/hls-audio 22.18 kB
/media/hls-background-video 17.46 kB
/media/hls-video 32.43 kB
/media/hlsjs-video 1.12 kB
/media/mux-audio 1.12 kB
/media/mux-background-video 17.46 kB
/media/mux-video 1.44 kB
/media/native-hls-video 6.21 kB
/media/shaka-video 1.11 kB
/media/spotify-audio 1.89 kB
/media/tiktok-video 1.81 kB
/media/twitch-video 1.84 kB
/media/vimeo-video 1.79 kB
/media/wistia-video 1.41 kB
/media/youtube-video 1.79 kB
Extensions (2)
Entry Initial
/extensions/google-cast 1.77 kB
/extensions/mux-data 1.80 kB
Players (5)
Entry Initial Lazy
/video/player 8.22 kB 56.03 kB
/audio/player 4.38 kB 56.03 kB
/background/player 2.64 kB 56.03 kB
/live-video/player 7.60 kB 56.03 kB
/live-audio/player 4.40 kB 56.03 kB
Skins (18)
Entry Type Initial Lazy
/video/minimal-skin.css css 8.09 kB —
/video/skin.css css 7.78 kB —
/video/minimal-skin js 58.75 kB 56.03 kB
/video/skin js 58.68 kB 56.03 kB
/audio/minimal-skin.css css 5.89 kB —
/audio/skin.css css 5.60 kB —
/audio/minimal-skin js 45.60 kB 56.03 kB
/audio/skin js 45.54 kB 56.03 kB
/background/skin.css css 97 B —
/background/skin js 518 B —
/live-video/minimal-skin.css css 6.60 kB —
/live-video/skin.css css 6.49 kB —
/live-video/minimal-skin js 48.58 kB 56.03 kB
/live-video/skin js 48.53 kB 56.03 kB
/live-audio/minimal-skin.css css 4.59 kB —
/live-audio/skin.css css 4.49 kB —
/live-audio/minimal-skin js 33.76 kB 56.03 kB
/live-audio/skin js 33.77 kB 56.03 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 11.22 kB 56.03 kB
/ui/alert-dialog 5.20 kB 56.03 kB
/ui/audio-track 8.35 kB 56.03 kB
/ui/audio-track-radio-group 10.78 kB 56.03 kB
/ui/buffering-indicator 8.40 kB 56.03 kB
/ui/captions-button 11.19 kB 56.03 kB
/ui/captions-radio-group 10.88 kB 56.03 kB
/ui/cast-button 11.22 kB 56.03 kB
/ui/controls 8.29 kB 56.03 kB
/ui/dialog 5.18 kB 56.03 kB
/ui/error-dialog 12.61 kB 56.03 kB
/ui/fullscreen-button 11.17 kB 56.03 kB
/ui/gesture 8.60 kB 56.03 kB
/ui/hotkey 8.99 kB 56.03 kB
/ui/live-button 9.53 kB 56.03 kB
/ui/menu 22.03 kB 56.03 kB
/ui/mute-button 11.22 kB 56.03 kB
/ui/pip-button 11.18 kB 56.03 kB
/ui/play-button 11.16 kB 56.03 kB
/ui/playback-rate 8.41 kB 56.03 kB
/ui/playback-rate-button 11.13 kB 56.03 kB
/ui/playback-rate-radio-group 10.85 kB 56.03 kB
/ui/popover 9.12 kB 56.03 kB
/ui/poster 8.61 kB 56.03 kB
/ui/quality 8.77 kB 56.03 kB
/ui/quality-radio-group 11.19 kB 56.03 kB
/ui/seek-button 11.18 kB 56.03 kB
/ui/seek-indicator 12.91 kB 56.03 kB
/ui/slider 14.39 kB 56.03 kB
/ui/status-announcer 10.81 kB 56.03 kB
/ui/status-indicator 13.32 kB 56.03 kB
/ui/thumbnail 9.77 kB 56.03 kB
/ui/time 10.60 kB 56.03 kB
/ui/time-slider 16.17 kB 56.03 kB
/ui/title 7.88 kB 56.03 kB
/ui/tooltip 9.99 kB 56.03 kB
/ui/volume-indicator 13.39 kB 56.03 kB
/ui/volume-popover 15.53 kB 56.03 kB
/ui/volume-slider 12.96 kB 56.03 kB
🧩 @videojs/core — no changes
Entries (76)
Entry Initial Lazy
. 13.39 kB —
/dom 23.47 kB 56.03 kB
/vjsc 1.90 kB —
/i18n 3.21 kB 56.03 kB
/i18n/locales/all 33.91 kB —
/i18n/locales/ar 1.16 kB —
/i18n/locales/az 1.08 kB —
/i18n/locales/bg 1.29 kB —
/i18n/locales/bn 1.25 kB —
/i18n/locales/bs 1.02 kB —
/i18n/locales/ca 1.04 kB —
/i18n/locales/cs 1.10 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 984 B —
/i18n/locales/de 1.06 kB —
/i18n/locales/el 1.42 kB —
/i18n/locales/en 801 B —
/i18n/locales/es 999 B —
/i18n/locales/et 1.02 kB —
/i18n/locales/eu 1.04 kB —
/i18n/locales/fa 1.21 kB —
/i18n/locales/fi 1.05 kB —
/i18n/locales/fr 1.01 kB —
/i18n/locales/gd 1.09 kB —
/i18n/locales/gl 1017 B —
/i18n/locales/he 1.10 kB —
/i18n/locales/hi 1.25 kB —
/i18n/locales/hr 1.05 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 953 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.16 kB —
/i18n/locales/ko 1.08 kB —
/i18n/locales/lt 1.04 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.23 kB —
/i18n/locales/nb 990 B —
/i18n/locales/ne 1.23 kB —
/i18n/locales/nl 1.01 kB —
/i18n/locales/nn 983 B —
/i18n/locales/oc 1.05 kB —
/i18n/locales/pl 1.11 kB —
/i18n/locales/pt 1.02 kB —
/i18n/locales/pt-BR 1.02 kB —
/i18n/locales/pt-PT 1.02 kB —
/i18n/locales/ro 1.04 kB —
/i18n/locales/ru 1.36 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.05 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.29 kB —
/i18n/locales/th 1.20 kB —
/i18n/locales/tr 1.00 kB —
/i18n/locales/uk 1.37 kB —
/i18n/locales/vi 1.10 kB —
/i18n/locales/zh 1.01 kB —
/i18n/locales/zh-CN 1.01 kB —
/i18n/locales/zh-TW 1.02 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 322 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 512 B
🔧 @videojs/utils — 2 small size changes
Path Base initial PR initial Initial diff Lazy diff
/dom 5.25 kB 5.24 kB -14 B (-0.3%) —
/string 239 B 278 B +39 B (+16.3%) —
Entries (13)
Entry Initial
/array 271 B
/dom 5.24 kB
/events 320 B
/function 414 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 278 B
/style 212 B
/time 1018 B
/number 199 B
📦 @videojs/cdn — no changes
📦 @videojs/cloudflare-video — no changes
📦 @videojs/dash-video — no changes
📦 @videojs/google-cast — no changes
📦 @videojs/hlsjs-video — no changes
📦 @videojs/media — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/dom 4.12 kB 4.11 kB -1 B (-0.0%) —
Entries (3)
Entry Initial
. 1.29 kB
/dom 4.11 kB
/media-tracks 2.05 kB
📦 @videojs/mux — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
. 1.24 kB 1.24 kB +1 B (+0.1%) —
📦 @videojs/mux-audio — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/spf 22.67 kB 22.68 kB +15 B (+0.1%) —
Entries (2)
Entry Initial
. 136.09 kB
/spf 22.68 kB
📦 @videojs/mux-data — no changes
📦 @videojs/mux-video — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/spf 32.74 kB 32.74 kB -2 B (-0.0%) —
Entries (2)
Entry Initial
. 135.91 kB
/spf 32.74 kB
📦 @videojs/native-hls-video — no changes
📦 @videojs/shaka-video — no changes
📦 @videojs/spf — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/hls-background-video 16.46 kB 16.45 kB -11 B (-0.1%) —
Entries (7)
Entry Initial
. 4.55 kB
/dom 7.67 kB
/hls 28.08 kB
/media-tracks 507 B
/hls-background-video 16.45 kB
/hls-audio 21.27 kB
/hls-video 31.46 kB
📦 @videojs/spotify-audio — no changes
📦 @videojs/tiktok-video — no changes
📦 @videojs/twitch-video — no changes
📦 @videojs/other — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
video.js 71.76 kB 71.75 kB -15 B (-0.0%) 0 B
Entries (3)
Entry Initial Lazy
video.js 71.75 kB 56.03 kB
video.js/package.json 608 B —
video.js/errors 1.03 kB —
📦 @videojs/vimeo-video — no changes
📦 @videojs/wistia-video — no changes
Entries (2)
Entry Initial
. 1.91 kB
/helpers 1.77 kB
📦 @videojs/youtube-video — no changes

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

Base automatically changed from fix/tailwind-catalog-pin to main September 24, 2026 21:56
@mihar-22
mihar-22 force-pushed the refactor/vjsc-build-boundary branch from 8ecd83a to 6beff4c Compare September 24, 2026 21:56
kebabCase keeps the leading dash a vendor-prefixed CSS property needs. kebabCaseName converts
identifiers such as PlayButton to play-button, which the HTML element tables use for public names.
Lower targets in three stages (source, lower, finalize) that share one bindings index and one set of
imports. Split the style plugin into candidate, reference, virtual CSS, and file-cache modules. Move
the HTML, React, and icon target tables into their own packages. Build skins on typed variant,
metadata, graph, and registry APIs, with generated outputs and the source layout each declared once.

Correctness fixes: checkout-independent scope ids and graph module order, style isolation errors in
every build, errors for unconsumed parts and $render markers, a declared cascade order, bundle
dedupe within parents, template siblings and nested templates, namespaced build metadata that keeps
other plugins' data, contained and conditional CSS imports, and normalized generated-file ownership.

Performance: a per-file render cache, one compile per theme for reusable React components, per-piece
bundle analysis, and memoized style utilities take skins generate from about 5.0 s to 2.2 s wall.
Task configs load before any package builds, so in a fresh checkout vjsc has no dist and importing
the plugin through `vjsc/plugins` fails to load the task graph. Core's config imports the plugin's
source again, and the modules that source loads use inline type checks instead of `@videojs/utils`,
which is not built yet either.
The cascade-order check treated every array and call argument holding two style references as a
composition, and every shared property as a conflict. Alternatives passed to a chooser or kept in
an array never meet on one element, and rules for exclusive attribute states, such as
`[data-state="open"]` and `[data-state="closed"]`, or `[data-pip]` and `:not([data-pip])`, never
apply together, yet both failed builds that compiled before the check existed. Only the arrays a
`className` or `class` attribute composes count now, including nested and spread arrays and each
branch of a conditional value, and declarations under exclusive attribute states of one element
do not compete.

This branch was successfully deployed

1 active deployment
Preview — fa7d8297 Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants