This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Extensions (2)
Players (5)
Skins (29)
UI Components (50)
⚛️ @videojs/react — 28 small size changes
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (26)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/media
Entries (23)
📦 @videojs/spf — no changesEntries (10)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
mihar-22
force-pushed
the
fix/react-commit-sync
branch
from
September 2, 2026 20:20
b9ead85 to
9dea605
Compare
Create popover, tooltip, and dialog APIs closed during render and commit the initial uncontrolled default or the current controlled value from an isomorphic layout effect. Server and abandoned renders no longer read focus, schedule transition frames, or invoke consumer callbacks, and the controlled-open sync now lands before paint instead of in a passive effect. The dialog change lives in useDialogRoot, which DialogRoot, AlertDialogRoot, and ErrorDialogRoot share, and each root's lifecycle coverage sits beside its existing tests. Refs #1679 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mihar-22
force-pushed
the
fix/react-popup-lifecycle
branch
from
September 2, 2026 20:29
c933054 to
cf7eb0e
Compare
mihar-22
marked this pull request as ready for review
September 2, 2026 20:29
mihar-22
marked this pull request as draft
September 2, 2026 20:38
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1679
Depends on #2316.
Summary
Keep Popover, Tooltip, Dialog, and AlertDialog initialization render-pure by applying default and controlled open state only after React commits. Server and abandoned renders no longer read focus, schedule transition frames, or invoke consumer callbacks.
Changes
open()inside theuseStateinitializeruseIsomorphicLayoutEffect(from fix(react): defer external writes until commit #2316), which also moves the controlled-open sync from a passive effect to a layout effectpackages/react/src/ui/dialog/use-dialog-root.ts, the hook now shared byDialogRoot,AlertDialogRoot, andErrorDialogRoot, replacing the earlieralert-dialog-root.tsxhunk thatmainrewroteinitialOpenRefpopover-root.test.tsx,tooltip-root.test.tsx,dialog-root.test.tsx,alert-dialog-root.test.tsxTesting
pnpm -F @videojs/react test: 70 files, 558 tests passedpnpm build --filter=@videojs/reactpnpm typecheckpnpm lint:fix:fileon touched files andgit diff --checkNote
Medium Risk
Touches open-state timing for widely used overlay primitives; behavior changes for SSR and first paint but is covered by targeted lifecycle tests.
Overview
Popover, Tooltip, Dialog, and AlertDialog no longer call
open()during theuseStateinitializer. Initial defaultOpen and controlledopenare applied inuseIsomorphicLayoutEffectafter commit, with a one-shotinitialOpenRefso uncontrolled defaults only open once (including under StrictMode replay).For Dialog (shared
useDialogRootfor Dialog, AlertDialog, and ErrorDialog), controlled-open sync moves from a passiveuseEffectto the same commit-phase layout path.New root-level tests assert SSR leaves default-open overlays closed (no popup markup,
onOpenChange,requestAnimationFrame, oractiveElement), abandoned renders do not open, and StrictMode still opens exactly once with a singleonOpenChange(true).Reviewed by Cursor Bugbot for commit cf7eb0e. Bugbot is set up for automated code reviews on this repo. Configure here.