Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

refactor(react)!: separate slider render and motion state - #2327

Closed
mihar-22 wants to merge 1 commit into
fix/react-ui-core-lifecyclefrom
refactor/react-slider-motion
Closed

mihar-22 wants to merge 1 commit into
fix/react-ui-core-lifecyclefrom
refactor/react-slider-motion

Conversation

@mihar-22

@mihar-22 mihar-22 commented Aug 21, 2026 •

Copy link
Copy Markdown
Member

Refs #1679

Depends on #2325.

Summary

  • Split React slider data into semantic render state and an explicit high-frequency motion channel.
  • Add useSliderMotion() for pointer-driven custom content while keeping ordinary render, className, and style callbacks stable.
  • Keep Thumb ARIA synchronized with live drag motion.
  • Give React ownership of fill and buffer CSS variables while the imperative binder owns only --media-slider-pointer.
  • Make slider projection cores render-local and keep retained drag/event machinery commit-synchronized.
  • Observe geometry only for edge-aligned thumbs.
  • Document the new hook and migration path. Core and HTML slider state remain unchanged.

Breaking changes

  • useSlider() returns motion instead of input.
  • computeState receives discrete SliderInteractionState rather than the full input object.
  • React slider callback state is now SliderRenderState and omits high-frequency pointer motion.
  • Pointer-driven custom UI should call useSliderMotion() inside a slider root.

Verification

  • React: 67 files, 547 tests passed.
  • Focused slider lifecycle/motion/variants: 5 files, 72 tests passed.
  • React build and workspace typecheck passed.
  • API generation and API builder: 225 tests passed.
  • Astro check: 0 errors.
  • Independent stacked-branch review found no actionable issues.

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v10-sandbox Ready Ready Preview Aug 21, 2026 10:23pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

🎨 @videojs/html — no changes
Presets (7)
Entry Initial Lazy
/video (default) 58.86 kB 56.87 kB
/video (default + hls) 197.77 kB 56.87 kB
/video (minimal) 58.55 kB 56.87 kB
/video (minimal + hls) 197.78 kB 56.87 kB
/audio (default) 48.78 kB 56.87 kB
/audio (minimal) 44.84 kB 56.87 kB
/background 5.75 kB 56.87 kB
Media (20)
Entry Initial Lazy
/media/mux-video 142.47 kB —
/media/mux-audio 142.09 kB —
/media/background-video 1.14 kB —
/media/cloudflare-video 6.25 kB —
/media/container 3.13 kB 56.87 kB
/media/dash-video 211.90 kB —
/media/google-cast 6.45 kB —
/media/hls-audio 21.84 kB —
/media/hls-background-video 16.79 kB —
/media/hls-video 27.77 kB —
/media/hlsjs-video 141.05 kB —
/media/mux-background-video 16.78 kB —
/media/mux-data 26.64 kB —
/media/native-hls-video 7.51 kB —
/media/shaka-video 199.34 kB —
/media/spotify-audio 6.23 kB —
/media/tiktok-video 6.28 kB —
/media/twitch-video 6.20 kB —
/media/vimeo-video 13.01 kB —
/media/youtube-video 6.76 kB —
Players (5)
Entry Initial Lazy
/video/player 10.37 kB 56.87 kB
/audio/player 7.08 kB 56.87 kB
/background/player 5.46 kB 56.87 kB
/live-video/player 9.75 kB 56.87 kB
/live-audio/player 7.10 kB 56.87 kB
Skins (29)
Entry Type Initial Lazy
/video/minimal-skin.css css 6.43 kB —
/video/skin.css css 6.22 kB —
/video/minimal-skin js 58.62 kB 56.87 kB
/video/minimal-skin.tailwind js 59.33 kB 56.87 kB
/video/skin js 58.75 kB 56.87 kB
/video/skin.tailwind js 59.50 kB 56.87 kB
/audio/minimal-skin.css css 4.71 kB —
/audio/skin.css css 4.63 kB —
/audio/minimal-skin js 44.85 kB 56.87 kB
/audio/minimal-skin.tailwind js 45.44 kB 56.87 kB
/audio/skin js 48.75 kB 56.87 kB
/audio/skin.tailwind js 49.40 kB 56.87 kB
/background/skin.css css 145 B —
/background/skin js 1.14 kB —
/live-video/minimal-skin.css css 6.43 kB —
/live-video/skin.css css 6.22 kB —
/live-video/minimal-skin js 52.78 kB 56.87 kB
/live-video/minimal-skin.tailwind js 53.20 kB 56.87 kB
/live-video/skin js 55.15 kB 56.87 kB
/live-video/skin.tailwind js 55.74 kB 56.87 kB
/live-audio/minimal-skin.css css 4.71 kB —
/live-audio/skin.css css 4.63 kB —
/live-audio/minimal-skin js 38.76 kB 56.87 kB
/live-audio/minimal-skin.tailwind js 38.23 kB 56.87 kB
/live-audio/skin js 42.33 kB 56.87 kB
/live-audio/skin.tailwind js 41.93 kB 56.87 kB
/global.css css 183 B —
/shared.css css 99 B —
/skin-element js 1.38 kB —
UI Components (43)
Entry Initial Lazy
/ui/airplay-button 11.06 kB 56.87 kB
/ui/alert-dialog 4.23 kB 56.87 kB
/ui/alert-dialog-close 1.95 kB 56.87 kB
/ui/alert-dialog-description 1.63 kB 56.87 kB
/ui/alert-dialog-title 1.65 kB 56.87 kB
/ui/audio-track-radio-group 11.22 kB 56.87 kB
/ui/buffering-indicator 8.49 kB 56.87 kB
/ui/captions-button 11.33 kB 56.87 kB
/ui/captions-radio-group 11.30 kB 56.87 kB
/ui/cast-button 11.05 kB 56.87 kB
/ui/compounds 35.26 kB 56.87 kB
/ui/controls 8.63 kB 56.87 kB
/ui/error-dialog 11.54 kB 56.87 kB
/ui/fullscreen-button 11.03 kB 56.87 kB
/ui/gesture 9.30 kB 56.87 kB
/ui/hotkey 9.74 kB 56.87 kB
/ui/menu 18.94 kB 56.87 kB
/ui/mute-button 11.07 kB 56.87 kB
/ui/pip-button 11.03 kB 56.87 kB
/ui/play-button 11.03 kB 56.87 kB
/ui/playback-rate-button 11.14 kB 56.87 kB
/ui/playback-rate-radio-group 11.21 kB 56.87 kB
/ui/popover 8.24 kB 56.87 kB
/ui/poster 8.56 kB 56.87 kB
/ui/quality-radio-group 11.80 kB 56.87 kB
/ui/seek-button 11.07 kB 56.87 kB
/ui/seek-indicator 12.45 kB 56.87 kB
/ui/seek-indicator-value 1.03 kB —
/ui/slider 11.88 kB 56.87 kB
/ui/status-announcer 10.43 kB 56.87 kB
/ui/status-indicator 12.76 kB 56.87 kB
/ui/status-indicator-value 1.02 kB —
/ui/thumbnail 9.79 kB 56.87 kB
/ui/time 10.77 kB 56.87 kB
/ui/time-slider 14.94 kB 56.87 kB
/ui/time-slider-chapter-title 8.66 kB 56.87 kB
/ui/time-slider-chapters 9.63 kB 56.87 kB
/ui/title 8.07 kB 56.87 kB
/ui/tooltip 9.60 kB 56.87 kB
/ui/volume-indicator 12.79 kB 56.87 kB
/ui/volume-indicator-fill 1.03 kB —
/ui/volume-indicator-value 1.02 kB —
/ui/volume-slider 12.53 kB 56.87 kB

⚛️ @videojs/react

Path Base initial PR initial Initial diff Lazy diff
/video/minimal-skin 46.61 kB 47.00 kB +398 B (+0.8%) 0 B
/video/minimal-skin.tailwind 53.50 kB 53.86 kB +367 B (+0.7%) 0 B
/video/skin 46.58 kB 47.05 kB +475 B (+1.0%) 0 B
/video/skin.tailwind 53.19 kB 53.54 kB +362 B (+0.7%) 0 B
/audio/minimal-skin 35.80 kB 36.23 kB +438 B (+1.2%) 0 B
/audio/minimal-skin.tailwind 40.88 kB 41.20 kB +325 B (+0.8%) 0 B
/audio/skin 35.69 kB 36.16 kB +479 B (+1.3%) 0 B
/audio/skin.tailwind 40.81 kB 41.24 kB +438 B (+1.0%) 0 B
/live-video/minimal-skin 38.55 kB 38.94 kB +398 B (+1.0%) 0 B
/live-video/minimal-skin.tailwind 45.05 kB 45.41 kB +363 B (+0.8%) 0 B
/live-video/skin 38.58 kB 38.94 kB +365 B (+0.9%) 0 B
/live-audio/minimal-skin 27.91 kB 28.24 kB +337 B (+1.2%) 0 B
/live-audio/minimal-skin.tailwind 31.73 kB 32.11 kB +392 B (+1.2%) 0 B
/live-audio/skin 27.97 kB 28.29 kB +326 B (+1.1%) 0 B
/live-audio/skin.tailwind 31.89 kB 32.20 kB +317 B (+1.0%) 0 B
/ui/slider 12.73 kB 13.05 kB +325 B (+2.5%) 0 B
/ui/time-slider 14.06 kB 14.46 kB +418 B (+2.9%) 0 B
/ui/volume-slider 11.98 kB 12.36 kB +383 B (+3.1%) 0 B
/video (default) 46.69 kB 47.12 kB +441 B (+0.9%) 0 B
/video (default + hls) 184.59 kB 184.99 kB +407 B (+0.2%) 0 B
/video (minimal) 46.73 kB 47.11 kB +388 B (+0.8%) 0 B
/video (minimal + hls) 184.49 kB 185.04 kB +569 B (+0.3%) 0 B
/audio (default) 35.80 kB 36.25 kB +459 B (+1.3%) 0 B
/audio (minimal) 35.88 kB 36.31 kB +439 B (+1.2%) 0 B
Small changes (1, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
/live-video/skin.tailwind 45.16 kB 45.41 kB +250 B (+0.5%) 0 B
Presets (7)
Entry Initial Lazy
/video (default) 47.12 kB 56.87 kB
/video (default + hls) 184.99 kB 56.87 kB
/video (minimal) 47.11 kB 56.87 kB
/video (minimal + hls) 185.04 kB 56.87 kB
/audio (default) 36.25 kB 56.87 kB
/audio (minimal) 36.31 kB 56.87 kB
/background 581 B 56.87 kB
Media (23)
Entry Initial
/media/mux-video/hls-js 140.63 kB
/media/mux-video/spf 27.12 kB
/media/mux-audio/hls-js 140.54 kB
/media/mux-audio/spf 21.10 kB
/media/background-video 402 B
/media/cloudflare-video 4.39 kB
/media/dash-video 210.20 kB
/media/google-cast 5.38 kB
/media/hls-audio 20.13 kB
/media/hls-background-video 16.42 kB
/media/hls-video 26.15 kB
/media/hlsjs-video 139.60 kB
/media/mux-audio 140.42 kB
/media/mux-background-video 16.47 kB
/media/mux-data 25.54 kB
/media/mux-video 140.76 kB
/media/native-hls-video 5.81 kB
/media/shaka-video 197.47 kB
/media/spotify-audio 4.27 kB
/media/tiktok-video 4.24 kB
/media/twitch-video 4.35 kB
/media/vimeo-video 11.24 kB
/media/youtube-video 4.92 kB
Players (5)
Entry Initial Lazy
/video/player 7.53 kB 56.87 kB
/audio/player 3.96 kB 56.87 kB
/background/player 2.28 kB 56.87 kB
/live-video/player 6.92 kB 56.87 kB
/live-audio/player 3.96 kB 56.87 kB
Skins (26)
Entry Type Initial Lazy
/video/minimal-skin.css css 6.34 kB —
/video/skin.css css 6.11 kB —
/video/minimal-skin js 47.00 kB 56.87 kB
/video/minimal-skin.tailwind js 53.86 kB 56.87 kB
/video/skin js 47.05 kB 56.87 kB
/video/skin.tailwind js 53.54 kB 56.87 kB
/audio/minimal-skin.css css 4.56 kB —
/audio/skin.css css 4.48 kB —
/audio/minimal-skin js 36.23 kB 56.87 kB
/audio/minimal-skin.tailwind js 41.20 kB 56.87 kB
/audio/skin js 36.16 kB 56.87 kB
/audio/skin.tailwind js 41.24 kB 56.87 kB
/background/skin.css css 90 B —
/background/skin js 277 B —
/live-video/minimal-skin.css css 6.34 kB —
/live-video/skin.css css 6.11 kB —
/live-video/minimal-skin js 38.94 kB 56.87 kB
/live-video/minimal-skin.tailwind js 45.41 kB 56.87 kB
/live-video/skin js 38.94 kB 56.87 kB
/live-video/skin.tailwind js 45.41 kB 56.87 kB
/live-audio/minimal-skin.css css 4.56 kB —
/live-audio/skin.css css 4.48 kB —
/live-audio/minimal-skin js 28.24 kB 56.87 kB
/live-audio/minimal-skin.tailwind js 32.11 kB 56.87 kB
/live-audio/skin js 28.29 kB 56.87 kB
/live-audio/skin.tailwind js 32.20 kB 56.87 kB
UI Components (37)
Entry Initial Lazy
/ui/airplay-button 10.30 kB 56.87 kB
/ui/alert-dialog 3.36 kB 56.87 kB
/ui/audio-track 7.91 kB 56.87 kB
/ui/audio-track-radio-group 9.07 kB 56.87 kB
/ui/buffering-indicator 7.77 kB 56.87 kB
/ui/captions-button 10.26 kB 56.87 kB
/ui/captions-radio-group 9.19 kB 56.87 kB
/ui/cast-button 10.27 kB 56.87 kB
/ui/controls 7.45 kB 56.87 kB
/ui/error-dialog 10.36 kB 56.87 kB
/ui/fullscreen-button 10.24 kB 56.87 kB
/ui/gesture 7.79 kB 56.87 kB
/ui/hotkey 8.21 kB 56.87 kB
/ui/live-button 8.71 kB 56.87 kB
/ui/menu 18.30 kB 56.87 kB
/ui/mute-button 10.28 kB 56.87 kB
/ui/pip-button 10.24 kB 56.87 kB
/ui/play-button 10.20 kB 56.87 kB
/ui/playback-rate 7.96 kB 56.87 kB
/ui/playback-rate-button 10.22 kB 56.87 kB
/ui/playback-rate-radio-group 9.11 kB 56.87 kB
/ui/popover 7.95 kB 56.87 kB
/ui/poster 7.56 kB 56.87 kB
/ui/quality 8.40 kB 56.87 kB
/ui/quality-radio-group 9.54 kB 56.87 kB
/ui/seek-button 10.26 kB 56.87 kB
/ui/seek-indicator 11.84 kB 56.87 kB
/ui/slider 13.05 kB 56.87 kB
/ui/status-announcer 10.01 kB 56.87 kB
/ui/status-indicator 12.11 kB 56.87 kB
/ui/thumbnail 8.79 kB 56.87 kB
/ui/time 9.75 kB 56.87 kB
/ui/time-slider 14.46 kB 56.87 kB
/ui/title 7.21 kB 56.87 kB
/ui/tooltip 8.69 kB 56.87 kB
/ui/volume-indicator 12.21 kB 56.87 kB
/ui/volume-slider 12.36 kB 56.87 kB
🧩 @videojs/core — no changes
Entries (76)
Entry Initial Lazy
. 12.90 kB —
/dom 20.90 kB 56.87 kB
/vjsc 1.64 kB —
/i18n 3.20 kB 56.87 kB
/i18n/locales/all 34.97 kB —
/i18n/locales/ar 1.22 kB —
/i18n/locales/az 1.09 kB —
/i18n/locales/bg 1.29 kB —
/i18n/locales/bn 1.23 kB —
/i18n/locales/bs 1.00 kB —
/i18n/locales/ca 1.07 kB —
/i18n/locales/cs 1.07 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 1006 B —
/i18n/locales/de 1.09 kB —
/i18n/locales/el 1.49 kB —
/i18n/locales/en 785 B —
/i18n/locales/es 1018 B —
/i18n/locales/et 1.05 kB —
/i18n/locales/eu 1.03 kB —
/i18n/locales/fa 1.22 kB —
/i18n/locales/fi 1.04 kB —
/i18n/locales/fr 1.07 kB —
/i18n/locales/gd 1.10 kB —
/i18n/locales/gl 1022 B —
/i18n/locales/he 1.14 kB —
/i18n/locales/hi 1.30 kB —
/i18n/locales/hr 1.02 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 919 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.18 kB —
/i18n/locales/ko 1.14 kB —
/i18n/locales/lt 1.02 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.30 kB —
/i18n/locales/nb 987 B —
/i18n/locales/ne 1.29 kB —
/i18n/locales/nl 1.00 kB —
/i18n/locales/nn 987 B —
/i18n/locales/oc 1.08 kB —
/i18n/locales/pl 1.14 kB —
/i18n/locales/pt 1.03 kB —
/i18n/locales/pt-BR 1.03 kB —
/i18n/locales/pt-PT 1.01 kB —
/i18n/locales/ro 1.07 kB —
/i18n/locales/ru 1.40 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.07 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.32 kB —
/i18n/locales/th 1.29 kB —
/i18n/locales/tr 1.08 kB —
/i18n/locales/uk 1.41 kB —
/i18n/locales/vi 1.11 kB —
/i18n/locales/zh 1.02 kB —
/i18n/locales/zh-CN 1.02 kB —
/i18n/locales/zh-TW 1.02 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 280 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 996 B
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 365 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 4.73 kB
/events 320 B
/function 386 B
/i18n 194 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 1.01 kB
/number 199 B
📦 @videojs/media — no changes
Entries (20)
Entry Initial
. 1.07 kB
/dom 121 B
/dom/audio-host 1.10 kB
/dom/cloudflare 3.69 kB
/dom/custom-media-element 2.09 kB
/dom/dash 209.83 kB
/dom/google-cast 4.06 kB
/dom/hls-js 139.17 kB
/dom/media-host 1.20 kB
/dom/media-played-ranges 576 B
/dom/mux 162.62 kB
/dom/native-hls 5.25 kB
/dom/shaka 197.02 kB
/dom/spotify 3.58 kB
/dom/tiktok 3.57 kB
/dom/twitch 3.62 kB
/dom/video-host 1.39 kB
/dom/vimeo 10.62 kB
/dom/youtube 4.25 kB
/media-tracks 2.05 kB
📦 @videojs/spf — no changes
Entries (10)
Entry Initial
. 4.53 kB
/dom 6.58 kB
/hls 21.83 kB
/media-tracks 504 B
/hls-background-video 15.86 kB
/hls-audio 19.60 kB
/hls-video 25.64 kB
/mux-audio 20.54 kB
/mux-background-video 15.85 kB
/mux-video 26.50 kB

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

@pkg-pr-new

pkg-pr-new Bot commented Aug 21, 2026

Copy link
Copy Markdown
@videojs/core

pnpm add https://pkg.pr.new/@videojs/core@2327

@videojs/element

pnpm add https://pkg.pr.new/@videojs/element@2327

@videojs/html

pnpm add https://pkg.pr.new/@videojs/html@2327

@videojs/media

pnpm add https://pkg.pr.new/@videojs/media@2327

@videojs/react

pnpm add https://pkg.pr.new/@videojs/react@2327

@videojs/spf

pnpm add https://pkg.pr.new/@videojs/spf@2327

@videojs/store

pnpm add https://pkg.pr.new/@videojs/store@2327

@videojs/utils

pnpm add https://pkg.pr.new/@videojs/utils@2327

commit: c29558b

@mihar-22

mihar-22 commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

Closing in its current form after re-reviewing against current main. The semantic/motion split is still the right direction and useSliderMotion is a reasonable public hook, but this branch cannot be rebased safely:

Plan: once the #2325 utility layer lands, reopen as two PRs on main. First a non-breaking PR for React-owned fill/buffer CSS variables and edge-only geometry observation, then useSliderMotion with a deprecated input alias and a short RFC for the computeState change, with edge-alignment measurement moved into SliderApi so core stays the single owner. Refs #1679.

This branch was successfully deployed

1 active deployment
Preview — c29558b4 Deployed Aug 21, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant