Skip to content

fix: build new players on video.js 10 when video.js 8 runs elsewhere - #14

Open
mihar-22 wants to merge 1 commit into
mainfrom
fix/v8-elsewhere-new-players
Open

mihar-22 wants to merge 1 commit into
mainfrom
fix/v8-elsewhere-new-players

Conversation

@mihar-22

@mihar-22 mihar-22 commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Fixes videojs/v10#12

Summary

With Video.js 8 on another page, agents built the new player on Video.js 8 too (6 of 6 attempts in the rc.4 ask-v8-elsewhere eval task). They read "means the project is on v8" as a reason to match it. The section now says v8 markers describe existing players only.

Changes

  • New players use Video.js 10. Existing Video.js 8 players stay as they are unless the user asks to migrate them.
  • Agents confirm before rewriting an existing player when they can ask, then follow the Migrate from Video.js 8 guide.
  • The handoff says when the project now runs both versions.
  • The "leaked in" check applies to new players, so leaving an existing v8 page alone doesn't fail it.

Testing

  • node scripts/validate-plugin.mjs passes (SKILL.md is 7.8 KB and 144 lines, within the 10,000-byte and 200-line limits).
  • I haven't re-run the eval task against this wording.

The matching agents init guidance change is in videojs/video.js#9472.

🤖 Generated with Claude Code

"Watch for Video.js 8" read as "this project is on v8", so with no user
to confirm, agents built new players on Video.js 8 to match an existing
page. Say that v8 markers describe existing players only: new players
use Video.js 10, existing v8 players stay untouched unless the user asks
to migrate, and the handoff mentions when both versions run.

Fixes #12

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants