feat: pass session context to needsApproval by vercel-gh-bot-3[bot] · Pull Request #285 · vercel/eve

vercel-gh-bot-3 · 2026-06-25T12:40:14Z

What changed

NeedsApprovalContext gains a session field, giving the approval predicate the same session metadata available in execute via ToolContext. The field is sourced from buildCallbackContext() inside buildNeedsApprovalFn at approval-check time, so it always reflects the active ALS scope.

Before:

needsApproval: ({ toolName, toolInput, approvedTools }) => { ... }

After:

needsApproval: ({ toolName, toolInput, approvedTools, session }) => { ... }

Why

Mukund raised a real pain point: without principal info in needsApproval, the only way to skip approval for schedules was to define a separate tool variant per principal via defineDynamic. That forces RBAC duplication at the tool level for something that should be a one-liner. Now the predicate can check session.auth.current?.principalId directly:

needsApproval: ({ session }) =>
  session.auth.current?.principalId !== "eve:app",

Schedule-initiated sessions carry principalId: "eve:app" and principalType: "runtime", so this gates approval on whether a person or the runtime triggered the run.

Files changed

packages/eve/src/public/definitions/tool.ts: adds session: SessionContext["session"] to NeedsApprovalContext, with a doc comment linking it to execute
packages/eve/src/harness/tools.ts: imports buildCallbackContext and reads session from it inside buildNeedsApprovalFn
packages/eve/src/harness/tools.test.ts, code-mode.test.ts, input-requests.test.ts, tool-loop.test.ts: add vi.mock("#context/build-callback-context.js") so tests run without an ALS scope; update toHaveBeenCalledExactlyOnceWith assertions to include session
packages/eve/src/context/dynamic-tool-lifecycle.test.ts: adds session to two direct needsApproval call sites
docs/tools/human-in-the-loop.md: documents the new session field and adds a "Skipping approval for schedules" section with a code example
.changeset/needs-approval-session-ctx.md: patch changeset

Breaking change

NeedsApprovalContext gains a required session field. Authors who define a custom needsApproval function and destructure only { toolName, toolInput, approvedTools } are unaffected at runtime (TypeScript will warn at compile time if they type the argument explicitly). The helpers always(), never(), and once() ignore all context fields so they are unaffected.

Requested by U0AT7H56S90 via slack.
Opened by e0.

vercel · 2026-06-25T12:40:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
eve-docs	Ready	Preview, Comment, Open in v0	Jun 25, 2026 12:41pm

github-actions · 2026-06-25T12:42:30Z

Bundle + Package Summary: `apps/fixtures/weather-agent`

Key takeaways

No notable deltas vs main (86a1e70).

Delta vs `main (86a1e70)`

Area	Metric	Baseline	Current	Delta
Package	Packed tarball	3.38 MB	3.39 MB	+670 B ⚠️
Package	Unpacked publish size	12.27 MB	12.27 MB	+1.4 kB ⚠️
Package	Installed footprint	52.12 MB	52.12 MB	+1.4 kB ⚠️
Package	Published files	2303	2303	0
Package	Installed files	5508	5508	0
Runtime	Unique function payloads	2	2	0
Runtime	Total function bytes	9.61 MB	9.61 MB	-120 B ✅
Runtime	Public routes	9	9	0

Changed function payloads vs main (86a1e70) (2)

Function	Status	Baseline	Current	Delta	Route changes
`functions/__server.func`	changed	3.98 MB	3.98 MB	-144 B ✅	none
`functions/.well-known/workflow/v1/flow.func`	changed	5.63 MB	5.63 MB	+24 B ⚠️	none

Build Metadata

Preset: vercel
Nitro: nitro@3.0.260610-beta
Output directory: apps/fixtures/weather-agent/.vercel/output
Build metadata timestamp: 2026-06-25T12:42:04.776Z
Route aliases: 9 public, 1 internal (10 total aliases)
Vercel routes in config: 10
Severity legend: 🔴 dominant/large, 🟠 notable, 🟡 watch, ⚪ small

Package Drill-Down

Package Details

Package: eve@0.13.8
Package directory: packages/eve
Tarball: 3.39 MB (eve-0.13.8.tgz)
Unpacked payload: 12.27 MB across 2303 published files
Installed footprint: 52.12 MB across 5508 installed files
Installed root package: 10.99 MB
Installed dependencies: 41.13 MB
Runtime dependencies: 1
Peer dependencies: 12 (11 optional)

Installed footprint is measured from an isolated temporary npm install of the packed tarball.

Heavy installed dependencies

@rolldown/binding-linux-x64-gnu: 20.26 MB (38.9%)
eve: 10.99 MB (21.1%)
ai: 6.20 MB (11.9%)
zod: 5.04 MB (9.7%)
nitro: 2.41 MB (4.6%)

Publish payload breakdown

Published file size
🟠 dist/src/compiled/experimental-ai-sdk-code-mo... [####....................] 1.51 MB 12.3%
🟡 dist/src/compiled/@workflow/core/runtime.js      [##......................] 788.4 kB 6.4%
🟡 dist/src/compiled/@vercel/sandbox/index.js       [##......................] 632.0 kB 5.2%
🟡 dist/src/compiled/@chat-adapter/slack/index.js   [#.......................] 438.4 kB 3.6%
🟡 dist/src/compiled/_chunks/workflow/attribute-... [#.......................] 371.6 kB 3.0%
🔴 Other published files                            [########################] 8.53 MB 69.5%

Installed footprint breakdown

Installed package size
🔴 @rolldown/binding-linux-x64-gnu [########################] 20.26 MB 38.9%
🔴 eve                             [#############...........] 10.99 MB 21.1%
🔴 ai                              [#######.................] 6.20 MB 11.9%
🔴 zod                             [######..................] 5.04 MB 9.7%
🟠 nitro                           [###.....................] 2.41 MB 4.6%
🟡 rolldown                        [#.......................] 771.7 kB 1.5%
🔴 Other installed packages        [########................] 6.46 MB 12.4%

Runtime dependencies (1)

Package	Range	Notes
`nitro`	`3.0.260610-beta`

Peer dependencies (12)

Package	Range	Notes
`@opentelemetry/api`	`^1.0.0`	optional peer
`@sveltejs/kit`	`^2.0.0`	optional peer
`ai`	`catalog:`
`braintrust`	`^3.0.0`	optional peer
`just-bash`	`^3.0.0`	optional peer
`microsandbox`	`^0.5.0`	optional peer
`next`	`^16.0.0`	optional peer
`nuxt`	`^4.0.0`	optional peer
`react`	`^19.0.0`	optional peer
`svelte`	`^5.0.0`	optional peer
`vite`	`^8.0.0`	optional peer
`vue`	`^3.5.0`	optional peer

Function Drill-Down

Payload Size Graph

Unique function payload size and share of total
🔴 functions/.well-known/workflow/v1/flow.func     [########################] 5.63 MB 58.6%
🔴 functions/__server.func                         [#################.......] 3.98 MB 41.4%

Top Function Payloads

🟠 functions/.well-known/workflow/v1/flow.func • 1 public route • 5.63 MB

Metric	Value
Public routes	`/.well-known/workflow/v1/flow`
Runtime	`nodejs24.x`
Handler	`index.mjs`
Payload	5.63 MB
Function files	5.63 MB across 26 files
Traced dependencies	0 B
Signal	🟠 Bundled file `__eve_nitro_handler__.mjs` is 1.87 MB (33.2%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 __eve_nitro_handler__.mjs              [########################] 1.87 MB 33.2%
🟠 _chunks/runtime.mjs                    [#############...........] 975.4 kB 17.3%
🟡 _chunks/sandbox.mjs                    [##########..............] 766.0 kB 13.6%
🟡 _chunks/attribute-changes-DUxG-Gic.mjs [######..................] 473.2 kB 8.4%
🟡 _libs/@ai-sdk/gateway+[...].mjs        [#####...................] 409.9 kB 7.3%
🟠 Other bundled files                    [###############.........] 1.13 MB 20.1%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x",
  "environment": {
    "NODE_OPTIONS": "--experimental-require-module"
  },
  "maxDuration": "max",
  "experimentalTriggers": [
    {
      "type": "queue/v2beta",
      "topic": "__eve_wkf_workflow_*",
      "consumer": "default",
      "retryAfterSeconds": 5,
      "initialDelaySeconds": 0
    }
  ]
}

🟠 functions/__server.func • 8 public routes, 1 internal alias • 3.98 MB

Metric	Value
Public routes	`/` `/eve/v1/callback/[token]` `/eve/v1/connections/[name]/callback/[token]` `/eve/v1/health` `/eve/v1/info` `/eve/v1/session` `/eve/v1/session/[sessionId]` `/eve/v1/session/[sessionId]/stream`
Internal aliases	`/__server`
Runtime	`nodejs24.x`
Handler	`index.mjs`
Payload	3.98 MB
Function files	3.98 MB across 21 files
Traced dependencies	0 B
Signal	🟠 Bundled file `index.mjs` is 1.51 MB (37.9%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 index.mjs                              [########################] 1.51 MB 37.9%
🟠 _chunks/runtime.mjs                    [##############..........] 883.8 kB 22.2%
🟠 _chunks/sandbox.mjs                    [############............] 766.0 kB 19.3%
🟡 _chunks/attribute-changes-DUxG-Gic.mjs [#######.................] 448.9 kB 11.3%
⚪ _libs/zod.mjs                          [##......................] 114.2 kB 2.9%
🟡 Other bundled files                    [####....................] 258.8 kB 6.5%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x"
}

feat: pass session context to needsApproval

c597166

vercel Bot deployed to Preview June 25, 2026 12:41 View deployment

ruiconti closed this Jun 25, 2026

ruiconti mentioned this pull request Jun 25, 2026

feat(eve): expose session to approval predicates #292

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: pass session context to needsApproval#285

feat: pass session context to needsApproval#285
vercel-gh-bot-3[bot] wants to merge 1 commit into
mainfrom
e0/needs-approval-session-ctx

vercel-gh-bot-3 Bot commented Jun 25, 2026

Uh oh!

vercel Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 25, 2026

Package Details

Payload Size Graph

Top Function Payloads

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

vercel-gh-bot-3 Bot commented Jun 25, 2026

What changed

Why

Files changed

Breaking change

Uh oh!

vercel Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026

Bundle + Package Summary: apps/fixtures/weather-agent

Delta vs main (86a1e70)

Package Details

Payload Size Graph

Top Function Payloads

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jun 25, 2026 •

edited

Loading

Bundle + Package Summary: `apps/fixtures/weather-agent`

Delta vs `main (86a1e70)`