Skip to content

Close new-criteria gaps for standard 1.21.0: B14, R08, W09 - #38

Merged
trsdn merged 1 commit into
mainfrom
standard/1.21.0
Sep 22, 2026
Merged

trsdn merged 1 commit into
mainfrom
standard/1.21.0

Conversation

@trsdn

@trsdn trsdn commented Sep 22, 2026

Copy link
Copy Markdown
Owner

Summary

Part of reassessing this repository against Repository Quality Standard v1.21.0, up from v1.6.0. This PR closes the three gaps that fourteen new criteria (B14-B16, P10-P13, R07-R09, S11-S13, W09) turned up that needed a real change; the rest of the new criteria already pass. The conformance record follows in a separate pull request.

  • B14: AGENTS.md now names the five release secrets and what replaces each one and where.
  • R08: README now states the release mechanism (Developer ID signature + Apple notarisation) and gives the codesign/spctl commands a consumer can run to check it. Verified directly against the published v1.2.0 artifact.
  • W09: the site loaded the vendored Instrument Workshop tokens unmodified, which now fails the criterion that replaced the old shared-design-language mandate. docs/assets/site.css overrides the accent colour for a project-specific look, checked above 8:1 contrast in both light and dark mode, and recorded as a deviation in docs/assets/VENDORED.md.

Related issue

None; found during a fleet reassessment against v1.21.0.

Validation

  • The project's documented validation command succeeds locally
  • Tests were added or updated for behavior changes

How the change was verified: scripts/validate.sh --fast (skips the release build and UI smoke tests, both of which launch the app) — all steps passed. codesign --verify --deep --strict, xcrun stapler validate, and spctl --assess were run against the downloaded, unpacked v1.2.0 release artifact, not launched. Contrast for the new accent colours was computed with the WCAG relative-luminance formula (light: 10.4:1, dark: 8.75:1, both against a 4.5:1 floor).

Impact

  • User or operational risk: none; documentation and a CSS override only, no application code changed.
  • Security or privacy impact: none. The AGENTS.md change documents an existing credential-recovery path rather than changing one.
  • Compatibility or migration impact: none.

Documentation

  • README, docs, and changelog are updated where the change is user-visible

Note: no CHANGELOG entry, because none of this is user-facing application behaviour (README/AGENTS.md/site styling only), consistent with this repository's own changelog scope.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CdiwBVuH6DCEtFPPwxbXKc

B14: name the five release secrets in AGENTS.md and state what replaces
each one and where, so an exposed credential has a documented recovery
path.

R08: tell a consumer what a published release proves and how to check
it themselves. README now names the mechanism (Developer ID signature
plus Apple notarisation) and gives the codesign/spctl commands that
verify it, next to the existing checksum instructions.

W09: the site loaded the vendored Instrument Workshop tokens with no
project-specific override, which is now a Fail under the criterion
that replaced the old shared-design-language mandate (decision 0013).
docs/assets/site.css overrides the accent colour for light and dark
mode, both checked above 8:1 contrast, and is recorded as a deviation
in docs/assets/VENDORED.md. It is hand-authored and explicitly not
part of the vendored, machine-owned set.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CdiwBVuH6DCEtFPPwxbXKc
@trsdn
trsdn merged commit db160db into main Sep 22, 2026
8 checks passed
@trsdn
trsdn deleted the standard/1.21.0 branch September 22, 2026 08:29
trsdn added a commit that referenced this pull request Sep 22, 2026
Up from v1.6.0. State moves from Healthy to Needs work: not a
regression, but the latest published release (v1.2.0) predates a
source commit that added product-identity metadata (repository URL,
issue-tracker URL, licence identifier) to Info.plist. I02 and I03 now
fail and R01/I04 are partial, all for the same reason: a value that
exists only in source is not evidence the artifact carries it, and the
artifact this assessment read does not carry it yet. The build
mechanism itself is correct and verified against both a local Debug
build and the published v1.2.0 zip; the fix is a new release, which is
a maintainer decision this assessment does not make.

Also updates for the fourteen criteria added since v1.6.0 (B14-B16,
P10-P13, R07-R09, S11-S13, W09), three of which needed the fixes made
in #38: B14, R08, W09.


Claude-Session: https://claude.ai/code/session_01CdiwBVuH6DCEtFPPwxbXKc

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant