Reassess against Repository Quality Standard 1.21.0 - #39
Merged
Merged
Conversation
Up from v1.6.0. State moves from Healthy to Needs work: not a regression, but the latest published release (v1.2.0) predates a source commit that added product-identity metadata (repository URL, issue-tracker URL, licence identifier) to Info.plist. I02 and I03 now fail and R01/I04 are partial, all for the same reason: a value that exists only in source is not evidence the artifact carries it, and the artifact this assessment read does not carry it yet. The build mechanism itself is correct and verified against both a local Debug build and the published v1.2.0 zip; the fix is a new release, which is a maintainer decision this assessment does not make. Also updates for the fourteen criteria added since v1.6.0 (B14-B16, P10-P13, R07-R09, S11-S13, W09), three of which needed the fixes made in #38: B14, R08, W09. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CdiwBVuH6DCEtFPPwxbXKc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records the reassessment against Repository Quality Standard v1.21.0, up from v1.6.0, following #38. State moves from Healthy to Needs work: not a regression in the code, but a genuine finding.
Finding.
PtionsPlus/Info.plistgainedTRSRepositoryURL,TRSIssuesURL, andTRSLicenseIdentifierin commita5e9a25, after thev1.2.0tag was cut and not an ancestor of it. This assessment downloaded the publishedv1.2.0Ptions+.zip, unpacked it without launching it, and confirmed withplutil -pthat itsInfo.plistcarries none of the three keys and ships no bundled licence text — while a local Debug build from currentmaindoes carry all three, confirming the build mechanism itself works.I02andI03are recordedfail, andR01/I04partial, all for this one reason. Per the standard's own rule, "a value that appears only in source is not evidence that the artifact carries it."scripts/verify-version.sh --appalready gates the next release on all four values agreeing with source, so the fix is cutting a new release, a maintainer decision this pull request does not make.Also records the thirteen other criteria added since v1.6.0 (
B14-B16,P10-P13,R07-R09,S11-S13,W09), allpassornaafter #38's fixes, and reverifiesR05directly against the publishedv1.2.0artifact (codesign --verify,xcrun stapler validate,spctl --assess, all passing,source=Notarized Developer ID).Related issue
Follows #38.
Validation
How the change was verified:
python3 scripts/conformance.py --checkagainst the record and thev1.21.0catalog (git show v1.21.0:standard.yml) reportsNeeds work (fail=2, na=23, partial=2, pass=80), badge in sync. No application code changed.Impact
Documentation
🤖 Generated with Claude Code
https://claude.ai/code/session_01CdiwBVuH6DCEtFPPwxbXKc