Conversation
This includes some minor functionname changes & cleanups
…ections in fieldsets
This solves having a map being passed in several places, making the code more readable and it also removes code duplication for generating the final output from the keyset. Switched to SHA256, as MD5 has been deprecated for any kind of use a long time ago. (and the overhead with current cpu's is so minimal that we really will not notice it).
We move the logic to ctx where it belongs as it is the context that determines if one is sysadmin not the user. This resolves a clash when trying to update users's sysadmin bits and just is more logical in the first place.
massar
changed the title
massar
changed the title
Member
Author
|
Applied already in #82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to resolve #94
Builds upon #86, #87, #89, #90 and #92; please merge those first as the amount of diff will be a lot less in this case and only one commit.