Conversation
This includes some minor functionname changes & cleanups
massar
changed the title
|
|
||
| // Pw_details provides details about te password dictionary checker (used by system_report) | ||
| func Pw_details() (msg string) { | ||
| fmt.Sprintf("Password Dictionary Checker: Loaded %d Weak Password Dictionaries with %d unique passwords", pw_dicts, len(pw_dict)) |
There was a problem hiding this comment.
go vet gives:
lib/pw_dict.go:83: result of fmt.Sprintf call not used
| fmt.Printf("Example - took: %s", te) | ||
| } | ||
|
|
||
| func ExampleTrackTimeDeferred() { |
There was a problem hiding this comment.
lib/misc_test.go:174: ExampleTrackTimeDeferred refers to unknown identifier: TrackTimeDeferred
There was a problem hiding this comment.
Resolved by making it ExampleTrackTime_deferred.
| type Example struct { | ||
| ID int `label:"ID" pfset:"nobody" pfget:"user" hint:"The identify of this field"` | ||
| AField string `label:"Field" pfset:"user" pfget:"user" hint:"A Field a user can modify"` | ||
| AnotherField string `label:"Another pfset:"sysadmin" pfget:"user" hint:"Another Field that only a sysadmin could modify, but any user can read"` |
There was a problem hiding this comment.
go vet:
lib/struct_test.go:19: struct field tag label:"Another pfset:"sysadmin" pfget:"user" hint:"Another Field that only a sysadmin could modify, but any user can read" not compatible with reflect.StructTag.Get: bad syntax for struct tag pair
exit status 1
There was a problem hiding this comment.
Missing " after Another.
Fixed in commit pushed out; as it is minor that it should not involve any further commits.
| @@ -0,0 +1,33 @@ | |||
| package pitchforkui | |||
|
|
|||
| func ExamplePfUI_Page_show() { | |||
There was a problem hiding this comment.
go vet
ui/ui_test.go:3: ExamplePfUI_Page_show refers to unknown field or method: PfUI.Page
There was a problem hiding this comment.
We'll need to update the call in PfUI from Page_show to PageShow for this to work; which will have global reach throughout all UI code as it is called from everywhere.
We can file a ticket for this, because if we do that that in this commit it will be even dirtier.
There was a problem hiding this comment.
Applied in separate branch (as it requires trident changes and other application changes too):
Commit: cf63c3f
MR that has this: #111
Note that this also needs: tridentli/trident#84
Primarily to make Golang Example for PageShow possible
|
Bypassed the failing test ui/ui_test.go. Now getting failed selenium tests. Error searching user for nomination. (Attached image). Error viewing e-mail on member profile: |
|
Add a pf_82 branch to trident tridentli/trident#85 Note that this also pulls in the Page_show -> PageShow fix so that a circumvention of the 'go vet' tests should not be needed. This reminds me to setup a silenium test VM so that we can run these tests automatically. |
We'll address this properly in #127
bapril
left a comment
bapril
left a comment
There was a problem hiding this comment.
Way more code than I'd like in a "doc update". All stuff that needed to get fixed. I'll live with it, passes tests.
2 participants
This includes some minor functionname changes & cleanups