Repository navigation
fix(scanner): insert semicolon before identifiers starting with in - #372
Closed
matthew-se wants to merge 1 commit into
Closed
matthew-se wants to merge 1 commit into
matthew-se wants to merge 1 commit into
Conversation
The automatic semicolon check treats a line starting with `in` or `instanceof` as a binary operator unless the next character is a letter. Digits, `_` and `$` also continue an identifier, so a line starting with `in_b`, `in1`, `in$` or `instanceof_` suppressed the semicolon and the statement or type member failed to parse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A line that starts with an identifier beginning with
infollowed by a digit,_or$(orinstanceoffollowed by one of those) is misread as a continuation of the previous line, so no automatic semicolon is inserted:On
masterthis parses as(MISSING "}")followed by alabeled_statement. The same happens for expression statements starting within_b,in1,in$orinstanceof_.scan_automatic_semicolononly treatsin…/instanceof…as an identifier when the next character satisfiesiswalpha. This PR widens both checks to identifier characters (iswalnum,_,$). Realin/instanceofoperators across a newline still suppress the semicolon; the new corpus test covers both.Tests
tree-sitter test(0.24.4): 114/114 pass, including the two new cases. Both fail onmaster.tree-sitter parse --rebuildof the CI example repos (desktop, redux, vscode; 15,190.ts/.tsxfiles, same excludes as CI) gives the same 51 failing files before and after.typescriptandtsxgrammars.tree-sitter-javascript's
src/scanner.chas the same check. The same fix is in tree-sitter/tree-sitter-javascript#389.🤖 Generated with Claude Code