fix(scanner): insert semicolon before identifiers starting with in - #389
Closed
matthew-se wants to merge 1 commit into
Closed
matthew-se wants to merge 1 commit into
matthew-se wants to merge 1 commit into
Conversation
The automatic semicolon check treats a line starting with `in` or `instanceof` as a binary operator unless the next character is a letter. Digits, `_` and `$` also continue an identifier, so a line starting with `in_b`, `in1`, `in$` or `instanceof_` suppressed the semicolon and the statement failed to parse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A line that starts with an identifier beginning with
infollowed by a digit,_or$(orinstanceoffollowed by one of those) is misread as a continuation of the previous line, so no automatic semicolon is inserted:On
masterthis parses with anERRORnode. The same happens forin1,in$andinstanceof_.scan_automatic_semicolononly treatsin…/instanceof…as an identifier when the next character satisfiesiswalpha. This PR widens both checks to identifier characters (iswalnum,_,$). The four cases are added to the existing "Alphabetical infix operators split across lines" test, which still checks that realin/instanceofoperators split across lines suppress the semicolon.Tests
tree-sitter test(0.25.8): 123/123 pass. The extended test fails onmaster.tree-sitter parse --rebuildoverexamples/plus the npm/cli clone from CI (1,554.js/.jsxfiles) gives the same single failing file before and after.eslint grammar.jspasses.tree-sitter-typescript has its own copy of this scanner code. The same fix is in tree-sitter/tree-sitter-typescript#372.
🤖 Generated with Claude Code