Skip to content

Add Node.js 24 to GitHub Actions CI #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterDaveHello wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Add Node.js 24 to GitHub Actions CI #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x, 22.x]
node-version: [14.x, 16.x, 18.x, 20.x, 22.x, 24.x]

@AndrewSouthpaw AndrewSouthpaw Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with this.

@PeterDaveHello PeterDaveHello Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewSouthpaw. I deliberately scoped this PR to the node-version matrix as a minimal, atomic Node.js 24 compatibility update, so it can land with a clean baseline.

The doctoc:dry-run step only runs on 22.x today, so touching it here still wouldn’t fully align the workflow. I’d prefer to keep this PR focused and handle the dry-run coverage properly in a follow-up PR, where the version coverage can be aligned intentionally.

Does that work for you?

@AndrewSouthpaw AndrewSouthpaw Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty nit-picky on the meta of structuring PRs, but IMO the point of the dry-run is to run on the latest Node. It's trivial to bump the version in this PR, it doesn't particularly increase scope.

@PeterDaveHello PeterDaveHello Jun 28, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you raising this, @AndrewSouthpaw. The dry-run does benefit from running against a recent Node version, but the condition is still hardcoded. Changing it from 22.x to 24.x would just swap one pinned version for another without making the rule explicit. “Latest” could mean the latest LTS, Current, or simply the top of the matrix.

This PR is meant to do one thing cleanly: confirm that 24.x works across the matrix with a solid compatibility baseline. Keeping the change focused makes it easier to review, understand, and revert independently if needed.

A follow-up PR would be the better place to decide the dry-run rule deliberately and, ideally, move away from hardcoding altogether. I can open it right after this lands so the dry-run coverage gets its own review rather than being folded into this compatibility update.

# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down