Add Node.js 24 to GitHub Actions CI#365
Conversation
Add 24.x to the GitHub Actions Node.js matrix.
There was a problem hiding this comment.
Pull request overview
Extends the GitHub Actions CI workflow matrix to run the test suite against Node.js 24.x, keeping CI coverage aligned with current supported Node releases.
Changes:
- Added
24.xto the Node.js version matrix in the CI workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| strategy: | ||
| matrix: | ||
| node-version: [14.x, 16.x, 18.x, 20.x, 22.x] | ||
| node-version: [14.x, 16.x, 18.x, 20.x, 22.x, 24.x] |
There was a problem hiding this comment.
Thanks @AndrewSouthpaw. I deliberately scoped this PR to the node-version matrix as a minimal, atomic Node.js 24 compatibility update, so it can land with a clean baseline.
The doctoc:dry-run step only runs on 22.x today, so touching it here still wouldn’t fully align the workflow. I’d prefer to keep this PR focused and handle the dry-run coverage properly in a follow-up PR, where the version coverage can be aligned intentionally.
Does that work for you?
There was a problem hiding this comment.
This is pretty nit-picky on the meta of structuring PRs, but IMO the point of the dry-run is to run on the latest Node. It's trivial to bump the version in this PR, it doesn't particularly increase scope.
There was a problem hiding this comment.
Appreciate you raising this, @AndrewSouthpaw. The dry-run does benefit from running against a recent Node version, but the condition is still hardcoded. Changing it from 22.x to 24.x would just swap one pinned version for another without making the rule explicit. “Latest” could mean the latest LTS, Current, or simply the top of the matrix.
This PR is meant to do one thing cleanly: confirm that 24.x works across the matrix with a solid compatibility baseline. Keeping the change focused makes it easier to review, understand, and revert independently if needed.
A follow-up PR would be the better place to decide the dry-run rule deliberately and, ideally, move away from hardcoding altogether. I can open it right after this lands so the dry-run coverage gets its own review rather than being folded into this compatibility update.
| strategy: | ||
| matrix: | ||
| node-version: [14.x, 16.x, 18.x, 20.x, 22.x] | ||
| node-version: [14.x, 16.x, 18.x, 20.x, 22.x, 24.x] |
Add 24.x to the GitHub Actions Node.js matrix.