Update types.ts#30
Open
davie-robertson wants to merge 1 commit into
Open
Conversation
The current type definition for the `shouldNavigate` method in the `Plugin` interface is causing type errors with certain valid implementations. The issue is that the current definition doesn't correctly account for directly returned Promises in the condition function. By simplifying the type to `() => boolean | Promise<boolean>`, we allow for both synchronous and asynchronous condition functions without needing a nested function structure. This change will resolve type errors while maintaining compatibility with existing implementations and allowing for more flexible usage patterns. Old pattern remains for backwards compatibility.
Merged
Owner
|
Sorry, I had missed this PR, would you be willing to fix the conflicts? Then we can get this merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current type definition for the
shouldNavigatemethod in thePlugininterface is causing type errors with certain valid implementations. The issue is that the current definition doesn't correctly account for directly returned Promises in the condition function. By simplifying the type to() => boolean | Promise<boolean>, we allow for both synchronous and asynchronous condition functions without needing a nested function structure.This change will resolve type errors while maintaining compatibility with existing implementations and allowing for more flexible usage patterns.