Router bug fixes#31
Merged
Merged
Conversation
* Fix type of `shouldNavigate()` to allow for it to be async (the code already supports this) * Fix type of `condition` to properly allow for both sync and async boolean returns (missing parens around the sync case) * Make multiple redirects work properly by switching to the new route's plugins after a redirect (in the original code, reassigning the `plugins` array doesn't actually change the array used by the for loop)
nj-reve
commented
May 12, 2025
| redirect: string, | ||
| condition: () => boolean | (() => Promise<Boolean>), | ||
| }; | ||
| shouldNavigate?: ((context: Context) => ShouldNavigateResult) | ((context: Context) => Promise<ShouldNavigateResult>); |
Contributor
Author
There was a problem hiding this comment.
This could also have just been (context: Context) => ShouldNavigateResult | Promise<ShouldNavigateResult> but I was following the existing pattern from condition.
Owner
|
Thank you! This was published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi - when using the router we ran into a few issues that should be fixed by this PR:
shouldNavigate()to allow for it to be async (the code already supports this)conditionto properly allow for both sync and async boolean returns (missing parens around the sync case)pluginsarray doesn't actually change the array used by the for loop)Thanks!