Repository navigation
test: run the shared writer suite on Redis - #3
Merged
moetemp merged 1 commit intoNov 9, 2026
Merged
Conversation
moetemp
force-pushed
the
moe/brook/review/r2-withdrawals
branch
from
October 27, 2026 07:43
665fb1d to
9b5fcbc
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
from
October 27, 2026 07:43
63e643c to
570651e
Compare
moetemp
force-pushed
the
moe/brook/review/r2-withdrawals
branch
from
October 27, 2026 08:17
9b5fcbc to
b63c189
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
from
October 27, 2026 08:17
570651e to
d1dc1c2
Compare
moetemp
force-pushed
the
moe/brook/review/r2-withdrawals
branch
from
October 27, 2026 16:55
b63c189 to
602c740
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
from
October 27, 2026 16:55
d1dc1c2 to
87ea54d
Compare
moetemp
force-pushed
the
moe/brook/review/r2-withdrawals
branch
from
October 27, 2026 23:47
602c740 to
0983d95
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
2 times, most recently
from
October 28, 2026 08:56
6e3ee49 to
847d490
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
from
October 29, 2026 08:40
847d490 to
ddbb3c5
Compare
moetemp
force-pushed
the
moe/brook/review/r2-withdrawals
branch
2 times, most recently
from
October 29, 2026 09:18
baa1d3c to
f5c9cf3
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
from
October 29, 2026 09:18
ddbb3c5 to
295970e
Compare
moetemp
force-pushed
the
moe/brook/review/r2-withdrawals
branch
from
October 29, 2026 10:04
f5c9cf3 to
476d7b5
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
2 times, most recently
from
October 29, 2026 15:17
421aa6a to
9af1aea
Compare
moetemp
force-pushed
the
moe/brook/review/r2-withdrawals
branch
2 times, most recently
from
October 29, 2026 16:13
8f1f7bd to
3b554a4
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
from
October 29, 2026 16:13
9af1aea to
58b216e
Compare
moetemp
changed the title
xumaple
approved these changes
Nov 3, 2026
1 of 3 tasks
moetemp
changed the base branch from
moe/brook/review/r2-withdrawals
to
moe/brook/review/r1-redis-store
November 9, 2026 08:14
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
from
November 9, 2026 08:14
42585c3 to
0620162
Compare
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR runs the writer suite of
temporalio-streamson the Redis Store, standalone and on a cluster. The resend cases wrap each backend's Store in a fault-injecting Store, so they run on Redis too. The test runtime has a 5-minute Retention, so the big-record case doesn't keep megabytes on a local server for 7 days.scripts/patch-sdk-rust.shnow patches inmoetemp/sdk-rust#227.It depends on #1 and on
moetemp/sdk-rust#227.Why?
The writers resend a batch after a Store failure, and the Store must write it once. This checks that on Redis.
How did you test it?
The writer suite runs with
cargo test -- --include-ignoredon the servers ofscripts/redis-test-servers.sh, standalone with a replica and on a cluster of three primaries with one replica each. CI also runs Redis 7.0 and a FIPS build.