Repository navigation
Conversation
moetemp
marked this pull request as draft
October 28, 2026 21:55
moetemp
force-pushed
the
moe/brook/review/r4-runtime-suites
branch
from
October 29, 2026 08:40
21cc10b to
d4c0e48
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
2 times, most recently
from
October 29, 2026 09:18
ddbb3c5 to
295970e
Compare
moetemp
force-pushed
the
moe/brook/review/r4-runtime-suites
branch
2 times, most recently
from
October 29, 2026 10:04
633dfec to
e5067b9
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
from
October 29, 2026 10:04
295970e to
421aa6a
Compare
moetemp
force-pushed
the
moe/brook/review/r4-runtime-suites
branch
from
October 29, 2026 15:17
e5067b9 to
e39cec5
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
from
October 29, 2026 15:17
421aa6a to
9af1aea
Compare
The SDK methods of `temporalio-streams` keep the same rules on the Redis Store, standalone and on a cluster.
moetemp
force-pushed
the
moe/brook/review/r4-runtime-suites
branch
from
October 29, 2026 16:13
e39cec5 to
ebcd906
Compare
moetemp
force-pushed
the
moe/brook/review/r3-writer-suite
branch
from
October 29, 2026 16:13
9af1aea to
58b216e
Compare
moetemp
marked this pull request as ready for review
October 30, 2026 05:02
Collaborator
Author
|
Parked with the sdk-rust layers it tests (moetemp/sdk-rust#222 to #225). The branch stays, and this PR comes back with them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR runs the scope, Workflow write, reader and buffer suites of
temporalio-streamson the Redis Store, standalone and on a cluster. The Store doesn't change, since the new SDK calls use only the Store calls it already has. Every case runs on Redis. The lost-answer and shutdown cases build their runtimes on each backend's Store, so none runs on memory here.scripts/patch-sdk-rust.shnow patches inmoetemp/sdk-rust#225.It depends on #3 and on
moetemp/sdk-rust#225.Part of the Brook review series.
Why?
Producer scopes, the Workflow write calls, readers and buffered publishers must keep their rules on every Store. This checks them on Redis.
How did you test it?
cargo fmt,clippy,testanddocpass against Redis 8, standalone and on a three-node cluster, withstreams-k15-buffersatebb26f8f. CI also runs Redis 7.0 and a FIPS build.