-
Notifications
You must be signed in to change notification settings - Fork 1
Added additional env vars to control the frequency of detector activating #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
symstu-tempesta
wants to merge
2
commits into
main
Choose a base branch
from
25-new-env-vars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,7 +71,7 @@ async def persistent_users_table_drop(self): | |
| async def persistent_users_table_truncate(self): | ||
| return await self.conn.query( | ||
| """ | ||
| truncate table persistent_users | ||
| truncate table if exists persistent_users | ||
| """ | ||
| ) | ||
|
|
||
|
|
@@ -108,7 +108,7 @@ async def user_agents_table_create(self): | |
| async def user_agents_table_truncate(self): | ||
| return await self.conn.query( | ||
| """ | ||
| truncate table user_agents | ||
| truncate table if exists user_agents | ||
| """ | ||
| ) | ||
|
|
||
|
|
@@ -126,7 +126,7 @@ async def user_agents_all(self): | |
| ) | ||
|
|
||
| async def access_log_truncate(self): | ||
| return await self.conn.query("truncate table access_log") | ||
| return await self.conn.query("truncate table if exists access_log") | ||
|
|
||
| async def blocked_users_create_table(self): | ||
| return await self.conn.query( | ||
|
|
@@ -167,7 +167,7 @@ async def bot_white_list_create_table(self): | |
| ) | ||
|
|
||
| async def bot_white_list_truncate(self): | ||
| return await self.conn.query("truncate table bots_white_list") | ||
| return await self.conn.query("truncate table if exists bots_white_list") | ||
|
|
||
| async def bot_white_list_insert(self, values: list[IPv4or6Network]): | ||
| return await self.conn.insert( | ||
|
|
@@ -200,3 +200,23 @@ async def bot_white_list_ip_trie_create(self): | |
|
|
||
| async def bot_white_list_ip_trie_refresh(self): | ||
| return await self.conn.query('SYSTEM RELOAD DICTIONARY bots_white_list_trie;') | ||
|
|
||
| async def access_log_create(self): | ||
| return await self.conn.query( | ||
| "CREATE TABLE IF NOT EXISTS access_log " | ||
| "(timestamp DateTime64(3, 'UTC')," | ||
| " address IPv6," | ||
| " method UInt8," | ||
| " version UInt8," | ||
| " status UInt16," | ||
| " response_content_length UInt64," | ||
| " response_time UInt32," | ||
| " vhost String," | ||
| " uri String," | ||
| " referer String," | ||
| " user_agent String," | ||
| " tft UInt64," | ||
| " tfh UInt64," | ||
| " dropped_events UInt64" | ||
| ") ENGINE = MergeTree() ORDER BY timestamp" | ||
| ) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should raise (log) and error and exit in case if there is no such table. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so no
BLOCKING_WINDOW_DURATION_SECdefines the history period, i.e. if it is 10 seconds, then the history is at (-20, -10]. In #25 it makes sense to configure say, (-4200, -600] - we need a second option for this