Added additional env vars to control the frequency of detector activating#33
Open
symstu-tempesta wants to merge 2 commits into
Open
Added additional env vars to control the frequency of detector activating#33symstu-tempesta wants to merge 2 commits into
symstu-tempesta wants to merge 2 commits into
Conversation
symstu-tempesta
force-pushed
the
25-new-env-vars
branch
2 times, most recently
from
cc26605 to
aca57a6
Compare
symstu-tempesta
force-pushed
the
25-new-env-vars
branch
from
aca57a6 to
f73cced
Compare
krizhanovsky
requested changes
Jun 5, 2026
krizhanovsky
left a comment
krizhanovsky
left a comment
Contributor
There was a problem hiding this comment.
I have a couple of comments, where I think we should do different things
| " tfh UInt64," | ||
| " dropped_events UInt64" | ||
| ") ENGINE = MergeTree() ORDER BY timestamp" | ||
| ) |
Contributor
There was a problem hiding this comment.
I think we should raise (log) and error and exit in case if there is no such table. tfw_logger creates the database and we'll have hard times to synchronize the table formats and also this might open an opportunity for hard races, when both the daemons start.
| @@ -68,6 +68,11 @@ BLOCKING_TYPES=["tft"] | |||
| # users should be fetched for the period 2025-01-01 00:00:00 to 2025-01-01 00:00:10 | |||
| BLOCKING_WINDOW_DURATION_SEC=10 | |||
Contributor
There was a problem hiding this comment.
OK, so no BLOCKING_WINDOW_DURATION_SEC defines the history period, i.e. if it is 10 seconds, then the history is at (-20, -10]. In #25 it makes sense to configure say, (-4200, -600] - we need a second option for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.