Skip to content
This repository was archived by the owner on Nov 12, 2026. It is now read-only.

Compositor: rounded windows that hug the MacBook display, one token-driven radius (rebased #555) - #623

Closed
techmore wants to merge 3 commits into
devfrom
codex/compositor-corners-20261027
Closed

techmore wants to merge 3 commits into
devfrom
codex/compositor-corners-20261027

Conversation

@techmore

Copy link
Copy Markdown
Owner

Rebases and completes #555 on current dev, and unifies the corner radius.

What was wrong

The session used three different radii: a 20 px display mask (dev's provisional screen_corners.rs), a window clip that had been 12 and was hand-changed to 20 on 2026-10-22, a 20 px GTK theme, and SDK tokens saying 14/12. Windows were not clipped by the Rust compositor at all.

Changes

Checked

cargo fmt; clippy -D warnings on default and native-drm; 165 compositor tests (new: override parsing); all msdk tests.

Not done

Not installed; the running session is untouched. No visual check on the built-in display and no app matrix (GTK, libadwaita, third-party, maximized/fullscreen, dialogs, popovers). 20 is a calibration starting point, not a measured panel radius. Supersedes #555.

techmore and others added 3 commits October 23, 2026 06:28
…isplay policy

The Rust compositor now draws the corner system of SDK-CORNERS.md: a screen mask on
the built-in output (above windows, dock, panels and the lock screen), a GLES texture
shader that clips toplevels to corners.window (circular or continuous superellipse),
corners.screen where a window corner meets a display corner, corners.popover for
popups, panels rounded only away from the screen edge, external outputs square.
Tokens come from msdk/data/tokens.json. Geometry is unit-tested; nested run
verified in a private Xvfb, not on the built-in display.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… token-driven corner radius (screen/window 20) replacing the provisional mask
@techmore

Copy link
Copy Markdown
Owner Author

Try-out package for the owner (not installed): the CI-built pantheon-rust-compositor deb from run 40499911528 (commit dba2830), a rollback copy of the currently installed files, and steps are in ~/mseries-tryout/ on the J314S. Note the package includes all compositor changes since the installed gitd28e997e (Oct 23), not just corners.

@techmore

Copy link
Copy Markdown
Owner Author

Note

🤖 Claude Opus 5.5 (Claude Code) responding on behalf of techmore

This PR accidentally commits 582 Cargo build files under rust/msdk/target/. That is why it shows 596 changed files. The real change is about 14 files: rust/pantheon-compositor/src, the corner tokens in rust/msdk/data, Cargo.lock and two docs.

To clean the branch before merging:

git rm -r --cached rust/msdk/target
git commit -m "Drop committed Cargo build output"

#628 changes .gitignore to ignore target/ everywhere, so this can't happen again.

techmore added a commit that referenced this pull request Oct 27, 2026
PR #623 committed 582 files from rust/msdk/target because only rust/target/ was ignored.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
techmore added a commit that referenced this pull request Oct 27, 2026
…riven radius (#641)

* Compositor: rounded windows that hug the display, token-driven radius (rebased from #623 without build artifacts); screenshots skip the screen-corner mask

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Screenshots skip the screen-corner mask; move tests to the end of screenshot_pixels; nested output-change cancel

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
@techmore

Copy link
Copy Markdown
Owner Author

Superseded by #641, which merged the same source changes (rebased on dev) without the ~580 rust/msdk/target build files that this branch committed by mistake (my error: SDK tests were run inside the worktree and git add -A picked up the output). Closing and deleting the branch so the artifacts don't linger. The compositor corners work, the 20 px token and the PANTHEON_SCREEN_CORNER_RADIUS override are all on dev via #641.

@techmore techmore closed this Oct 27, 2026
@techmore
techmore deleted the codex/compositor-corners-20261027 branch October 27, 2026 23:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant