Skip to content

fix: allow VALUES clause in CTEs in SQLite #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgress454 wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −1
Open

fix: allow VALUES clause in CTEs in SQLite #2631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pegjs/sqlite.pegjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,14 @@ set_op
return s ? `union ${s.toLowerCase()}` : 'union'
}

select_core
Copy link
Copy Markdown
Contributor Author

@sgress454 sgress454 Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select-core docs: https://sqlite.org/syntax/select-core.html

(it's basically either SELECT or VALUES)

= select_stmt
/ v:value_clause {
return { type: 'values', values: v.values }
}

union_stmt
= head:select_stmt tail:(__ set_op __ select_stmt)* __ ob: order_by_clause? __ l:limit_clause? {
= head:select_core tail:(__ set_op __ select_core)* __ ob: order_by_clause? __ l:limit_clause? {
let cur = head
for (let i = 0; i < tail.length; i++) {
cur._next = tail[i][3]
Expand Down
9 changes: 9 additions & 0 deletions test/sqlite.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,4 +300,13 @@ describe('sqlite', () => {
expect(getParsedSql(sql)).to.be.equal(sql)
});
});
it('should support CTE with VALUES', () => {
const sql = `WITH RECURSIVE cnt(x) AS (
VALUES(1)
UNION ALL
SELECT x+1 FROM cnt WHERE x < 10
)
SELECT x FROM cnt;`
expect(getParsedSql(sql)).to.be.equal(`WITH RECURSIVE "cnt"("x") AS ((1)) SELECT "x" FROM "cnt"`)
})
})