fix: allow VALUES clause in CTEs in SQLite#2631
Open
sgress454 wants to merge 1 commit into
Open
Conversation
sgress454
commented
Jan 26, 2026
| return s ? `union ${s.toLowerCase()}` : 'union' | ||
| } | ||
|
|
||
| select_core |
Contributor
Author
There was a problem hiding this comment.
select-core docs: https://sqlite.org/syntax/select-core.html
(it's basically either SELECT or VALUES)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
VALUESinside of common table expressions (CTEs) in SQLite. A unit test is added that includes bothVALUESand forUNIONclauses inside a CTE, since the fix involves updating theunion_stmtrule.Note that the
union_stmtrule seems to be more referring to compound statements in general (which includeUNION,UNION ALL,INTERSECTandEXCEPT) rather than justUNION, but renaming that is much higher touch so I just updated it in place.