Skip to content

i18n: escape double quotes in prop2po output so msgfmt keeps them #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacalata merged 2 commits into from
Nov 2, 2026
Merged

i18n: escape double quotes in prop2po output so msgfmt keeps them #486

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b05ebf8
i18n: escape double quotes in prop2po output so msgfmt keeps them
jacalata Oct 26, 2026
e9023b0
Merge development into jac/escape-quotes-in-po
jacalata Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bin/i18n/prop2po.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
TO DO: contribute changes back and go back to installing from pypi
"""

import re

import click
from datetime import datetime

Expand Down Expand Up @@ -47,7 +49,9 @@ def to_po(source, destination, encoding, language, project, copyright):
parts = line.split('=', 1)
# TODO it fails on comments/lines with less than two parts after splitting
try:
destination.write('#:\n' + 'msgid "' + parts[0] + '"\n' 'msgstr "' + parts[1][:-1] + '"\n\n')
# a bare " would end the .po string early; msgfmt then skips the line and the .mo keeps the wrong text
msgstr = re.sub(r'(?<!\\)"', r'\\"', parts[1][:-1])
destination.write('#:\n' + 'msgid "' + parts[0] + '"\n' 'msgstr "' + msgstr + '"\n\n')
except IndexError as e:
print("FAILED on line{}".format(line))

Expand Down
Loading