Repository navigation
i18n: escape double quotes in prop2po output so msgfmt keeps them - #486
Merged
Merged
Conversation
prop2po wrote values into the .po unescaped, so a value containing " ended the
msgstr early. msgfmt.py's literal_eval then failed (ERROR (skipped)) and the .mo
stored the wrong text: editsite.options.subscription_email kept stray wrapping
quotes, and session.options.site lost its ("") in every locale. Escape bare
quotes in prop2po and regenerate the catalogs.
Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
bcantoni
approved these changes
Oct 27, 2026
Drop tracked .mo files; development no longer tracks them (generated, gitignored). Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prop2powrites.propertiesvalues into the.powithout escaping, so a value containing"ends themsgstrearly.msgfmt.pythen fails to parse the line (ERROR (skipped)) and the.mostores the wrong text.Two strings were affected on
development:editsite.options.subscription_emailwas stored with stray wrapping quotes.session.options.sitelost its("")in every locale.Bare quotes are now escaped in
prop2po, and the catalogs are regenerated. The English.moentries now match the source.🤖 Generated with Claude Code